From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Cengiz Can <cengiz.can@canonical.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind
Date: Tue, 28 Jul 2026 11:47:35 +0200 [thread overview]
Message-ID: <amh6txid90mJjd62@shikoro> (raw)
In-Reply-To: <20260727231026.470146-1-cengiz.can@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
> debugfs_create_file_unsafe("buf_size", 0600, priv->debug_dir, priv, &fops_buf_size);
> debugfs_create_file_unsafe("capture", 0200, priv->debug_dir, priv, &fops_capture);
> - debugfs_create_file_unsafe("trigger", 0200, priv->debug_dir, priv, &fops_trigger);
> + debugfs_create_file("trigger", 0200, priv->debug_dir, priv, &fops_trigger);
What about removing the other _unsafe calls as well? TBH, I can't recall
why I used them. Doesn't make sense from today's perspective.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-07-28 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 23:10 [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind Cengiz Can
2026-07-28 9:47 ` Wolfram Sang [this message]
2026-07-28 15:02 ` Cengiz Can
2026-07-28 23:38 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amh6txid90mJjd62@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=brgl@kernel.org \
--cc=cengiz.can@canonical.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.