From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Cengiz Can <cengiz.can@canonical.com>
Cc: Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind
Date: Wed, 29 Jul 2026 01:38:36 +0200 [thread overview]
Message-ID: <amk9fLBRR0B-uNpP@shikoro> (raw)
In-Reply-To: <7f31351f-43ef-41f7-b30a-2a9a008d4f3d@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
> Switching them to debugfs_create_file() would just add a second
> get/put around the one they already do, so I would leave them.
>
> Happy to send a follow-up if you'd prefer them consistent.
I would prefer them to be consistent. The overhead is negligible IMO.
If you prefer to leave them, ok, too. Then, I'd just ask you to add a
comment why this one file is different than the others. Because it
stands out and it is not directly obvious why.
Thank you for looking into this!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-07-28 23:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 23:10 [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind Cengiz Can
2026-07-28 9:47 ` Wolfram Sang
2026-07-28 15:02 ` Cengiz Can
2026-07-28 23:38 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amk9fLBRR0B-uNpP@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=brgl@kernel.org \
--cc=cengiz.can@canonical.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.