* [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c
@ 2026-07-24 12:08 ` Adrián Larumbe
0 siblings, 0 replies; 10+ messages in thread
From: Adrián Larumbe @ 2026-07-24 12:08 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Lucas Stach,
Russell King, Christian Gmeiner, Jianmin Lv, Qianhai Wu,
Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Lyude Paul, Danilo Krummrich, Boris Brezillon,
Steven Price, Liviu Dudau, Sandy Huang, Heiko Stübner,
Andy Yan, Thierry Reding, Mikko Perttunen, Jonathan Hunter,
Zack Rusin, Broadcom internal kernel review list, Matthew Brost,
Thomas Hellström, Rodrigo Vivi, Oleksandr Andrushchenko,
Sumit Semwal
Cc: amd-gfx, dri-devel, linux-kernel, etnaviv, linux-arm-msm,
freedreno, nouveau, linux-rockchip, linux-arm-kernel, linux-tegra,
intel-xe, xen-devel, linux-media, linaro-mm-sig,
Adrián Larumbe
None of the semantics of the function tell of it being a PRIME-exclusive
entry point. In fact, most drivers seem to be using it to translate a list
of pages into an sg table that can be used for GPU mapping later on, rather
than just for sharing an object's pages with another driver.
Move it across files and rename accordingly.
Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
---
drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces.
It is a generic helper that converts a page array into a scatter/gather
table via dma_map_sg_attrs. Nothing in its implementation touches struct
dma_buf or import/export logic.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++---
drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++
drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
drivers/gpu/drm/drm_prime.c | 38 -----------------------------
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +--
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++-
drivers/gpu/drm/loongson/lsdc_gem.c | 3 +--
drivers/gpu/drm/msm/msm_gem.c | 2 +-
drivers/gpu/drm/msm/msm_gem_prime.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +--
drivers/gpu/drm/panthor/panthor_gem.c | 6 ++---
drivers/gpu/drm/radeon/radeon_prime.c | 5 ++--
drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++---
drivers/gpu/drm/tegra/gem.c | 4 +--
drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +--
drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++---
drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
include/drm/drm_gem.h | 5 +++-
include/drm/drm_prime.h | 2 --
19 files changed, 68 insertions(+), 70 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
index b33c300e26e2..c9a98aec7eb6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
@@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach,
switch (bo->tbo.resource->mem_type) {
case TTM_PL_TT:
- sgt = drm_prime_pages_to_sg(obj->dev,
- bo->tbo.ttm->pages,
- bo->tbo.ttm->num_pages);
+ sgt = drm_pages_to_sg(obj->dev,
+ bo->tbo.ttm->pages,
+ bo->tbo.ttm->num_pages);
if (IS_ERR(sgt))
return sgt;
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index 018df97d590d..22c8a3b5f667 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
}
EXPORT_SYMBOL(drm_gem_put_pages);
+/**
+ * drm_pages_to_sg - converts a page array into an sg list
+ * @dev: DRM device
+ * @pages: pointer to the array of page pointers to convert
+ * @nr_pages: length of the page vector
+ *
+ * This helper creates an sg table object from a set of pages.
+ * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
+ */
+struct sg_table *drm_pages_to_sg(struct drm_device *dev,
+ struct page **pages, unsigned int nr_pages)
+{
+ struct sg_table *sg;
+ size_t max_segment = 0;
+ int err;
+
+ sg = kmalloc_obj(struct sg_table);
+ if (!sg)
+ return ERR_PTR(-ENOMEM);
+
+ if (dev)
+ max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
+ if (max_segment == 0)
+ max_segment = UINT_MAX;
+ err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
+ (unsigned long)nr_pages << PAGE_SHIFT,
+ max_segment, GFP_KERNEL);
+ if (err) {
+ kfree(sg);
+ sg = ERR_PTR(err);
+ }
+ return sg;
+}
+EXPORT_SYMBOL(drm_pages_to_sg);
+
static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
struct drm_gem_object **objs)
{
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
index 22ec52e2ffb8..144d088a477f 100644
--- a/drivers/gpu/drm/drm_gem_shmem_helper.c
+++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
@@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem)
drm_WARN_ON(obj->dev, drm_gem_is_imported(obj));
- return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
+ return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
}
EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table);
diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
index 9b44c78cd77f..54539a8929c1 100644
--- a/drivers/gpu/drm/drm_prime.c
+++ b/drivers/gpu/drm/drm_prime.c
@@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
.vunmap = drm_gem_dmabuf_vunmap,
};
-/**
- * drm_prime_pages_to_sg - converts a page array into an sg list
- * @dev: DRM device
- * @pages: pointer to the array of page pointers to convert
- * @nr_pages: length of the page vector
- *
- * This helper creates an sg table object from a set of pages
- * the driver is responsible for mapping the pages into the
- * importers address space for use with dma_buf itself.
- *
- * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
- */
-struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
- struct page **pages, unsigned int nr_pages)
-{
- struct sg_table *sg;
- size_t max_segment = 0;
- int err;
-
- sg = kmalloc_obj(struct sg_table);
- if (!sg)
- return ERR_PTR(-ENOMEM);
-
- if (dev)
- max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
- if (max_segment == 0)
- max_segment = UINT_MAX;
- err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
- (unsigned long)nr_pages << PAGE_SHIFT,
- max_segment, GFP_KERNEL);
- if (err) {
- kfree(sg);
- sg = ERR_PTR(err);
- }
- return sg;
-}
-EXPORT_SYMBOL(drm_prime_pages_to_sg);
-
/**
* drm_prime_get_contiguous_size - returns the contiguous size of the buffer
* @sgt: sg_table describing the buffer to check
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index b0436a1e103f..a8e8614f8210 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -3,7 +3,6 @@
* Copyright (C) 2015-2018 Etnaviv Project
*/
-#include <drm/drm_prime.h>
#include <drm/drm_print.h>
#include <linux/dma-mapping.h>
#include <linux/shmem_fs.h>
@@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
struct sg_table *sgt;
- sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
+ sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages);
if (IS_ERR(sgt)) {
dev_err(dev->dev, "failed to allocate sgt: %ld\n",
PTR_ERR(sgt));
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
index 6757ae6ec304..f44484325ddb 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
@@ -3,6 +3,7 @@
* Copyright (C) 2014-2018 Etnaviv Project
*/
+#include <drm/drm_gem.h>
#include <drm/drm_prime.h>
#include <linux/dma-buf.h>
#include <linux/module.h>
@@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
return ERR_PTR(-EINVAL);
- return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
+ return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
}
int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c
index 2fb03487c983..37160228244c 100644
--- a/drivers/gpu/drm/loongson/lsdc_gem.c
+++ b/drivers/gpu/drm/loongson/lsdc_gem.c
@@ -9,7 +9,6 @@
#include <drm/drm_dumb_buffers.h>
#include <drm/drm_file.h>
#include <drm/drm_gem.h>
-#include <drm/drm_prime.h>
#include <drm/drm_print.h>
#include "lsdc_drv.h"
@@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj)
return ERR_PTR(-ENOMEM);
}
- return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
+ return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
}
static void lsdc_gem_object_free(struct drm_gem_object *obj)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index efd3d3c9a449..7e3418290c22 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
msm_obj->pages = p;
- msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages);
+ msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages);
if (IS_ERR(msm_obj->sgt)) {
void *ptr = ERR_CAST(msm_obj->sgt);
diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
index 036d34c674d9..d25393a9e549 100644
--- a/drivers/gpu/drm/msm/msm_gem_prime.c
+++ b/drivers/gpu/drm/msm/msm_gem_prime.c
@@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)
if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */
return ERR_PTR(-ENOMEM);
- return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages);
+ return drm_pages_to_sg(obj->dev, msm_obj->pages, npages);
}
int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
index caab60fc62f6..b95f2f07df74 100644
--- a/drivers/gpu/drm/nouveau/nouveau_prime.c
+++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
@@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj)
{
struct nouveau_bo *nvbo = nouveau_gem_object(obj);
- return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
- nvbo->bo.ttm->num_pages);
+ return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
+ nvbo->bo.ttm->num_pages);
}
struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
index 9855df738194..ec530d254fa4 100644
--- a/drivers/gpu/drm/panthor/panthor_gem.c
+++ b/drivers/gpu/drm/panthor/panthor_gem.c
@@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo)
if (ret)
return ERR_PTR(ret);
- sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
- bo->base.size >> PAGE_SHIFT);
+ sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages,
+ bo->base.size >> PAGE_SHIFT);
if (IS_ERR(sgt))
return sgt;
@@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj)
drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages);
drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count));
- return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
+ return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
}
static int panthor_gem_vmap_locked(struct drm_gem_object *obj,
diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
index a77881f035e7..4cfc4282a59c 100644
--- a/drivers/gpu/drm/radeon/radeon_prime.c
+++ b/drivers/gpu/drm/radeon/radeon_prime.c
@@ -26,6 +26,7 @@
#include <linux/dma-buf.h>
+#include <drm/drm_gem.h>
#include <drm/drm_prime.h>
#include <drm/radeon_drm.h>
@@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
{
struct radeon_bo *bo = gem_to_radeon_bo(obj);
- return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
- bo->tbo.ttm->num_pages);
+ return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
+ bo->tbo.ttm->num_pages);
}
struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
index b188539dca0b..7897da0becf4 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
@@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj)
rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT;
- rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev,
- rk_obj->pages, rk_obj->num_pages);
+ rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev,
+ rk_obj->pages, rk_obj->num_pages);
if (IS_ERR(rk_obj->sgt)) {
ret = PTR_ERR(rk_obj->sgt);
goto err_put_pages;
@@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj)
int ret;
if (rk_obj->pages)
- return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
+ return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
sgt = kzalloc_obj(*sgt);
if (!sgt)
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 436394e04812..701af672b4e5 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -17,7 +17,7 @@
#include <drm/drm_drv.h>
#include <drm/drm_dumb_buffers.h>
-#include <drm/drm_prime.h>
+#include <drm/drm_gem.h>
#include "drm.h"
#include "gem.h"
@@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo)
bo->num_pages = bo->gem.size >> PAGE_SHIFT;
- bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
+ bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
if (IS_ERR(bo->sgt)) {
err = PTR_ERR(bo->sgt);
goto put_pages;
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
index 39f8c46550c2..c9e7f2e3668c 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
@@ -28,7 +28,7 @@
#include "vmwgfx_bo.h"
#include "vmwgfx_drv.h"
-#include "drm/drm_prime.h"
+#include "drm/drm_gem.h"
#include "drm/drm_gem_ttm_helper.h"
#include <linux/debugfs.h>
@@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj)
if (vmw_tt->vsgt.sgt)
return vmw_tt->vsgt.sgt;
- return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
+ return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
}
static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map)
diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
index 8a920e58245c..f0fe80706b79 100644
--- a/drivers/gpu/drm/xe/xe_dma_buf.c
+++ b/drivers/gpu/drm/xe/xe_dma_buf.c
@@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach,
switch (bo->ttm.resource->mem_type) {
case XE_PL_TT:
- sgt = drm_prime_pages_to_sg(obj->dev,
- bo->ttm.ttm->pages,
- obj->size >> PAGE_SHIFT);
+ sgt = drm_pages_to_sg(obj->dev,
+ bo->ttm.ttm->pages,
+ obj->size >> PAGE_SHIFT);
if (IS_ERR(sgt))
return sgt;
diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
index eec4c1da3f9e..a4a7c7f2c91c 100644
--- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
+++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
@@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
if (!xen_obj->pages)
return ERR_PTR(-ENOMEM);
- return drm_prime_pages_to_sg(gem_obj->dev,
+ return drm_pages_to_sg(gem_obj->dev,
xen_obj->pages, xen_obj->num_pages);
}
diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
index 885244e375d3..7b9cc6335689 100644
--- a/include/drm/drm_gem.h
+++ b/include/drm/drm_gem.h
@@ -155,7 +155,7 @@ struct drm_gem_object_funcs {
* here cannot be used for sg tables pointing at driver private memory
* ranges.
*
- * See also drm_prime_pages_to_sg().
+ * See also drm_pages_to_sg().
*/
struct sg_table *(*get_sg_table)(struct drm_gem_object *obj);
@@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj);
void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
bool dirty, bool accessed);
+struct sg_table *drm_pages_to_sg(struct drm_device *dev,
+ struct page **pages, unsigned int nr_pages);
+
void drm_gem_lock(struct drm_gem_object *obj);
void drm_gem_unlock(struct drm_gem_object *obj);
diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
index f50f862f0d8b..603e16a40ae7 100644
--- a/include/drm/drm_prime.h
+++ b/include/drm/drm_prime.h
@@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map);
int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
-struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
- struct page **pages, unsigned int nr_pages);
struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj,
int flags);
---
base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d
change-id: 20260724-get_pages-e2e91c53eaa3
Best regards,
--
Adrián Larumbe <adrian.larumbe@collabora.com>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 10+ messages in thread* ✓ CI.KUnit: success for drm/gem: Move pages_to_sg helper into drm_gem.c
2026-07-24 12:08 ` Adrián Larumbe
(?)
@ 2026-07-24 12:33 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2026-07-24 12:33 UTC (permalink / raw)
To: Adrián Larumbe; +Cc: intel-xe
== Series Details ==
Series: drm/gem: Move pages_to_sg helper into drm_gem.c
URL : https://patchwork.freedesktop.org/series/171076/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[12:32:19] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:32:23] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:32:55] Starting KUnit Kernel (1/1)...
[12:32:55] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:32:55] ================== guc_buf (11 subtests) ===================
[12:32:55] [PASSED] test_smallest
[12:32:55] [PASSED] test_largest
[12:32:56] [PASSED] test_granular
[12:32:56] [PASSED] test_unique
[12:32:56] [PASSED] test_overlap
[12:32:56] [PASSED] test_reusable
[12:32:56] [PASSED] test_too_big
[12:32:56] [PASSED] test_flush
[12:32:56] [PASSED] test_lookup
[12:32:56] [PASSED] test_data
[12:32:56] [PASSED] test_class
[12:32:56] ===================== [PASSED] guc_buf =====================
[12:32:56] =================== guc_dbm (7 subtests) ===================
[12:32:56] [PASSED] test_empty
[12:32:56] [PASSED] test_default
[12:32:56] ======================== test_size ========================
[12:32:56] [PASSED] 4
[12:32:56] [PASSED] 8
[12:32:56] [PASSED] 32
[12:32:56] [PASSED] 256
[12:32:56] ==================== [PASSED] test_size ====================
[12:32:56] ======================= test_reuse ========================
[12:32:56] [PASSED] 4
[12:32:56] [PASSED] 8
[12:32:56] [PASSED] 32
[12:32:56] [PASSED] 256
[12:32:56] =================== [PASSED] test_reuse ====================
[12:32:56] =================== test_range_overlap ====================
[12:32:56] [PASSED] 4
[12:32:56] [PASSED] 8
[12:32:56] [PASSED] 32
[12:32:56] [PASSED] 256
[12:32:56] =============== [PASSED] test_range_overlap ================
[12:32:56] =================== test_range_compact ====================
[12:32:56] [PASSED] 4
[12:32:56] [PASSED] 8
[12:32:56] [PASSED] 32
[12:32:56] [PASSED] 256
[12:32:56] =============== [PASSED] test_range_compact ================
[12:32:56] ==================== test_range_spare =====================
[12:32:56] [PASSED] 4
[12:32:56] [PASSED] 8
[12:32:56] [PASSED] 32
[12:32:56] [PASSED] 256
[12:32:56] ================ [PASSED] test_range_spare =================
[12:32:56] ===================== [PASSED] guc_dbm =====================
[12:32:56] =================== guc_idm (6 subtests) ===================
[12:32:56] [PASSED] bad_init
[12:32:56] [PASSED] no_init
[12:32:56] [PASSED] init_fini
[12:32:56] [PASSED] check_used
[12:32:56] [PASSED] check_quota
[12:32:56] [PASSED] check_all
[12:32:56] ===================== [PASSED] guc_idm =====================
[12:32:56] =============== guc_klv_helpers (9 subtests) ===============
[12:32:56] [PASSED] test_count
[12:32:56] [PASSED] test_encode_u32
[12:32:56] [PASSED] test_encode_u64
[12:32:56] [PASSED] test_encode_string
[12:32:56] [PASSED] test_encode_object_raw
[12:32:56] [PASSED] test_encode_object_klv
[12:32:56] [PASSED] test_encode_object_nested
[12:32:56] [PASSED] test_encode_object_basic
[12:32:56] [PASSED] test_print
[12:32:56] ================= [PASSED] guc_klv_helpers =================
[12:32:56] ================== no_relay (3 subtests) ===================
[12:32:56] [PASSED] xe_drops_guc2pf_if_not_ready
[12:32:56] [PASSED] xe_drops_guc2vf_if_not_ready
[12:32:56] [PASSED] xe_rejects_send_if_not_ready
[12:32:56] ==================== [PASSED] no_relay =====================
[12:32:56] ================== pf_relay (14 subtests) ==================
[12:32:56] [PASSED] pf_rejects_guc2pf_too_short
[12:32:56] [PASSED] pf_rejects_guc2pf_too_long
[12:32:56] [PASSED] pf_rejects_guc2pf_no_payload
[12:32:56] [PASSED] pf_fails_no_payload
[12:32:56] [PASSED] pf_fails_bad_origin
[12:32:56] [PASSED] pf_fails_bad_type
[12:32:56] [PASSED] pf_txn_reports_error
[12:32:56] [PASSED] pf_txn_sends_pf2guc
[12:32:56] [PASSED] pf_sends_pf2guc
[12:32:56] [SKIPPED] pf_loopback_nop (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:32:56] [SKIPPED] pf_loopback_echo (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:32:56] [SKIPPED] pf_loopback_fail (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:32:56] [SKIPPED] pf_loopback_busy (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:32:56] [SKIPPED] pf_loopback_retry (requires CONFIG_DRM_XE_DEBUG_SRIOV)
[12:32:56] ==================== [PASSED] pf_relay =====================
[12:32:56] ================== vf_relay (3 subtests) ===================
[12:32:56] [PASSED] vf_rejects_guc2vf_too_short
[12:32:56] [PASSED] vf_rejects_guc2vf_too_long
[12:32:56] [PASSED] vf_rejects_guc2vf_no_payload
[12:32:56] ==================== [PASSED] vf_relay =====================
[12:32:56] ================ pf_gt_config (9 subtests) =================
[12:32:56] [PASSED] fair_contexts_1vf
[12:32:56] [PASSED] fair_doorbells_1vf
[12:32:56] [PASSED] fair_ggtt_1vf
[12:32:56] ====================== fair_vram_1vf ======================
[12:32:56] [PASSED] 3.50 GiB
[12:32:56] [PASSED] 11.5 GiB
[12:32:56] [PASSED] 15.5 GiB
[12:32:56] [PASSED] 31.5 GiB
[12:32:56] [PASSED] 63.5 GiB
[12:32:56] [PASSED] 1.91 GiB
[12:32:56] ================== [PASSED] fair_vram_1vf ==================
[12:32:56] ================ fair_vram_1vf_admin_only =================
[12:32:56] [PASSED] 3.50 GiB
[12:32:56] [PASSED] 11.5 GiB
[12:32:56] [PASSED] 15.5 GiB
[12:32:56] [PASSED] 31.5 GiB
[12:32:56] [PASSED] 63.5 GiB
[12:32:56] [PASSED] 1.91 GiB
[12:32:56] ============ [PASSED] fair_vram_1vf_admin_only =============
[12:32:56] ====================== fair_contexts ======================
[12:32:56] [PASSED] 1 VF
[12:32:56] [PASSED] 2 VFs
[12:32:56] [PASSED] 3 VFs
[12:32:56] [PASSED] 4 VFs
[12:32:56] [PASSED] 5 VFs
[12:32:56] [PASSED] 6 VFs
[12:32:56] [PASSED] 7 VFs
[12:32:56] [PASSED] 8 VFs
[12:32:56] [PASSED] 9 VFs
[12:32:56] [PASSED] 10 VFs
[12:32:56] [PASSED] 11 VFs
[12:32:56] [PASSED] 12 VFs
[12:32:56] [PASSED] 13 VFs
[12:32:56] [PASSED] 14 VFs
[12:32:56] [PASSED] 15 VFs
[12:32:56] [PASSED] 16 VFs
[12:32:56] [PASSED] 17 VFs
[12:32:56] [PASSED] 18 VFs
[12:32:56] [PASSED] 19 VFs
[12:32:56] [PASSED] 20 VFs
[12:32:56] [PASSED] 21 VFs
[12:32:56] [PASSED] 22 VFs
[12:32:56] [PASSED] 23 VFs
[12:32:56] [PASSED] 24 VFs
[12:32:56] [PASSED] 25 VFs
[12:32:56] [PASSED] 26 VFs
[12:32:56] [PASSED] 27 VFs
[12:32:56] [PASSED] 28 VFs
[12:32:56] [PASSED] 29 VFs
[12:32:56] [PASSED] 30 VFs
[12:32:56] [PASSED] 31 VFs
[12:32:56] [PASSED] 32 VFs
[12:32:56] [PASSED] 33 VFs
[12:32:56] [PASSED] 34 VFs
[12:32:56] [PASSED] 35 VFs
[12:32:56] [PASSED] 36 VFs
[12:32:56] [PASSED] 37 VFs
[12:32:56] [PASSED] 38 VFs
[12:32:56] [PASSED] 39 VFs
[12:32:56] [PASSED] 40 VFs
[12:32:56] [PASSED] 41 VFs
[12:32:56] [PASSED] 42 VFs
[12:32:56] [PASSED] 43 VFs
[12:32:56] [PASSED] 44 VFs
[12:32:56] [PASSED] 45 VFs
[12:32:56] [PASSED] 46 VFs
[12:32:56] [PASSED] 47 VFs
[12:32:56] [PASSED] 48 VFs
[12:32:56] [PASSED] 49 VFs
[12:32:56] [PASSED] 50 VFs
[12:32:56] [PASSED] 51 VFs
[12:32:56] [PASSED] 52 VFs
[12:32:56] [PASSED] 53 VFs
[12:32:56] [PASSED] 54 VFs
[12:32:56] [PASSED] 55 VFs
[12:32:56] [PASSED] 56 VFs
[12:32:56] [PASSED] 57 VFs
[12:32:56] [PASSED] 58 VFs
[12:32:56] [PASSED] 59 VFs
[12:32:56] [PASSED] 60 VFs
[12:32:56] [PASSED] 61 VFs
[12:32:56] [PASSED] 62 VFs
[12:32:56] [PASSED] 63 VFs
[12:32:56] ================== [PASSED] fair_contexts ==================
[12:32:56] ===================== fair_doorbells ======================
[12:32:56] [PASSED] 1 VF
[12:32:56] [PASSED] 2 VFs
[12:32:56] [PASSED] 3 VFs
[12:32:56] [PASSED] 4 VFs
[12:32:56] [PASSED] 5 VFs
[12:32:56] [PASSED] 6 VFs
[12:32:56] [PASSED] 7 VFs
[12:32:56] [PASSED] 8 VFs
[12:32:56] [PASSED] 9 VFs
[12:32:56] [PASSED] 10 VFs
[12:32:56] [PASSED] 11 VFs
[12:32:56] [PASSED] 12 VFs
[12:32:56] [PASSED] 13 VFs
[12:32:56] [PASSED] 14 VFs
[12:32:56] [PASSED] 15 VFs
[12:32:56] [PASSED] 16 VFs
[12:32:56] [PASSED] 17 VFs
[12:32:56] [PASSED] 18 VFs
[12:32:56] [PASSED] 19 VFs
[12:32:56] [PASSED] 20 VFs
[12:32:56] [PASSED] 21 VFs
[12:32:56] [PASSED] 22 VFs
[12:32:56] [PASSED] 23 VFs
[12:32:56] [PASSED] 24 VFs
[12:32:56] [PASSED] 25 VFs
[12:32:56] [PASSED] 26 VFs
[12:32:56] [PASSED] 27 VFs
[12:32:56] [PASSED] 28 VFs
[12:32:56] [PASSED] 29 VFs
[12:32:56] [PASSED] 30 VFs
[12:32:56] [PASSED] 31 VFs
[12:32:56] [PASSED] 32 VFs
[12:32:56] [PASSED] 33 VFs
[12:32:56] [PASSED] 34 VFs
[12:32:56] [PASSED] 35 VFs
[12:32:56] [PASSED] 36 VFs
[12:32:56] [PASSED] 37 VFs
[12:32:56] [PASSED] 38 VFs
[12:32:56] [PASSED] 39 VFs
[12:32:56] [PASSED] 40 VFs
[12:32:56] [PASSED] 41 VFs
[12:32:56] [PASSED] 42 VFs
[12:32:56] [PASSED] 43 VFs
[12:32:56] [PASSED] 44 VFs
[12:32:56] [PASSED] 45 VFs
[12:32:56] [PASSED] 46 VFs
[12:32:56] [PASSED] 47 VFs
[12:32:56] [PASSED] 48 VFs
[12:32:56] [PASSED] 49 VFs
[12:32:56] [PASSED] 50 VFs
[12:32:56] [PASSED] 51 VFs
[12:32:56] [PASSED] 52 VFs
[12:32:56] [PASSED] 53 VFs
[12:32:56] [PASSED] 54 VFs
[12:32:56] [PASSED] 55 VFs
[12:32:56] [PASSED] 56 VFs
[12:32:56] [PASSED] 57 VFs
[12:32:56] [PASSED] 58 VFs
[12:32:56] [PASSED] 59 VFs
[12:32:56] [PASSED] 60 VFs
[12:32:56] [PASSED] 61 VFs
[12:32:56] [PASSED] 62 VFs
[12:32:56] [PASSED] 63 VFs
[12:32:56] ================= [PASSED] fair_doorbells ==================
[12:32:56] ======================== fair_ggtt ========================
[12:32:56] [PASSED] 1 VF
[12:32:56] [PASSED] 2 VFs
[12:32:56] [PASSED] 3 VFs
[12:32:56] [PASSED] 4 VFs
[12:32:56] [PASSED] 5 VFs
[12:32:56] [PASSED] 6 VFs
[12:32:56] [PASSED] 7 VFs
[12:32:56] [PASSED] 8 VFs
[12:32:56] [PASSED] 9 VFs
[12:32:56] [PASSED] 10 VFs
[12:32:56] [PASSED] 11 VFs
[12:32:56] [PASSED] 12 VFs
[12:32:56] [PASSED] 13 VFs
[12:32:56] [PASSED] 14 VFs
[12:32:56] [PASSED] 15 VFs
[12:32:56] [PASSED] 16 VFs
[12:32:56] [PASSED] 17 VFs
[12:32:56] [PASSED] 18 VFs
[12:32:56] [PASSED] 19 VFs
[12:32:56] [PASSED] 20 VFs
[12:32:56] [PASSED] 21 VFs
[12:32:56] [PASSED] 22 VFs
[12:32:56] [PASSED] 23 VFs
[12:32:56] [PASSED] 24 VFs
[12:32:56] [PASSED] 25 VFs
[12:32:56] [PASSED] 26 VFs
[12:32:56] [PASSED] 27 VFs
[12:32:56] [PASSED] 28 VFs
[12:32:56] [PASSED] 29 VFs
[12:32:56] [PASSED] 30 VFs
[12:32:56] [PASSED] 31 VFs
[12:32:56] [PASSED] 32 VFs
[12:32:56] [PASSED] 33 VFs
[12:32:56] [PASSED] 34 VFs
[12:32:56] [PASSED] 35 VFs
[12:32:56] [PASSED] 36 VFs
[12:32:56] [PASSED] 37 VFs
[12:32:56] [PASSED] 38 VFs
[12:32:56] [PASSED] 39 VFs
[12:32:56] [PASSED] 40 VFs
[12:32:56] [PASSED] 41 VFs
[12:32:56] [PASSED] 42 VFs
[12:32:56] [PASSED] 43 VFs
[12:32:56] [PASSED] 44 VFs
[12:32:56] [PASSED] 45 VFs
[12:32:56] [PASSED] 46 VFs
[12:32:56] [PASSED] 47 VFs
[12:32:56] [PASSED] 48 VFs
[12:32:56] [PASSED] 49 VFs
[12:32:56] [PASSED] 50 VFs
[12:32:56] [PASSED] 51 VFs
[12:32:56] [PASSED] 52 VFs
[12:32:56] [PASSED] 53 VFs
[12:32:56] [PASSED] 54 VFs
[12:32:56] [PASSED] 55 VFs
[12:32:56] [PASSED] 56 VFs
[12:32:56] [PASSED] 57 VFs
[12:32:56] [PASSED] 58 VFs
[12:32:56] [PASSED] 59 VFs
[12:32:56] [PASSED] 60 VFs
[12:32:56] [PASSED] 61 VFs
[12:32:56] [PASSED] 62 VFs
[12:32:56] [PASSED] 63 VFs
[12:32:56] ==================== [PASSED] fair_ggtt ====================
[12:32:56] ======================== fair_vram ========================
[12:32:56] [PASSED] 1 VF
[12:32:56] [PASSED] 2 VFs
[12:32:56] [PASSED] 3 VFs
[12:32:56] [PASSED] 4 VFs
[12:32:56] [PASSED] 5 VFs
[12:32:56] [PASSED] 6 VFs
[12:32:56] [PASSED] 7 VFs
[12:32:56] [PASSED] 8 VFs
[12:32:56] [PASSED] 9 VFs
[12:32:56] [PASSED] 10 VFs
[12:32:56] [PASSED] 11 VFs
[12:32:56] [PASSED] 12 VFs
[12:32:56] [PASSED] 13 VFs
[12:32:56] [PASSED] 14 VFs
[12:32:56] [PASSED] 15 VFs
[12:32:56] [PASSED] 16 VFs
[12:32:56] [PASSED] 17 VFs
[12:32:56] [PASSED] 18 VFs
[12:32:56] [PASSED] 19 VFs
[12:32:56] [PASSED] 20 VFs
[12:32:56] [PASSED] 21 VFs
[12:32:56] [PASSED] 22 VFs
[12:32:56] [PASSED] 23 VFs
[12:32:56] [PASSED] 24 VFs
[12:32:56] [PASSED] 25 VFs
[12:32:56] [PASSED] 26 VFs
[12:32:56] [PASSED] 27 VFs
[12:32:56] [PASSED] 28 VFs
[12:32:56] [PASSED] 29 VFs
[12:32:56] [PASSED] 30 VFs
[12:32:56] [PASSED] 31 VFs
[12:32:56] [PASSED] 32 VFs
[12:32:56] [PASSED] 33 VFs
[12:32:56] [PASSED] 34 VFs
[12:32:56] [PASSED] 35 VFs
[12:32:56] [PASSED] 36 VFs
[12:32:56] [PASSED] 37 VFs
[12:32:56] [PASSED] 38 VFs
[12:32:56] [PASSED] 39 VFs
[12:32:56] [PASSED] 40 VFs
[12:32:56] [PASSED] 41 VFs
[12:32:56] [PASSED] 42 VFs
[12:32:56] [PASSED] 43 VFs
[12:32:56] [PASSED] 44 VFs
[12:32:56] [PASSED] 45 VFs
[12:32:56] [PASSED] 46 VFs
[12:32:56] [PASSED] 47 VFs
[12:32:56] [PASSED] 48 VFs
[12:32:56] [PASSED] 49 VFs
[12:32:56] [PASSED] 50 VFs
[12:32:56] [PASSED] 51 VFs
[12:32:56] [PASSED] 52 VFs
[12:32:56] [PASSED] 53 VFs
[12:32:56] [PASSED] 54 VFs
[12:32:56] [PASSED] 55 VFs
[12:32:56] [PASSED] 56 VFs
[12:32:56] [PASSED] 57 VFs
[12:32:56] [PASSED] 58 VFs
[12:32:56] [PASSED] 59 VFs
[12:32:56] [PASSED] 60 VFs
[12:32:56] [PASSED] 61 VFs
[12:32:56] [PASSED] 62 VFs
[12:32:56] [PASSED] 63 VFs
[12:32:56] ==================== [PASSED] fair_vram ====================
[12:32:56] ================== [PASSED] pf_gt_config ===================
[12:32:56] ===================== lmtt (1 subtest) =====================
[12:32:56] ======================== test_ops =========================
[12:32:56] [PASSED] 2-level
[12:32:56] [PASSED] multi-level
[12:32:56] ==================== [PASSED] test_ops =====================
[12:32:56] ====================== [PASSED] lmtt =======================
[12:32:56] ================= sriov_packet (1 subtest) =================
[12:32:56] [PASSED] test_descriptor_init
[12:32:56] ================== [PASSED] sriov_packet ===================
[12:32:56] ================= pf_service (11 subtests) =================
[12:32:56] [PASSED] pf_negotiate_any
[12:32:56] [PASSED] pf_negotiate_base_match
[12:32:56] [PASSED] pf_negotiate_base_newer
[12:32:56] [PASSED] pf_negotiate_base_next
[12:32:56] [SKIPPED] pf_negotiate_base_older (no older minor)
[12:32:56] [PASSED] pf_negotiate_base_prev
[12:32:56] [PASSED] pf_negotiate_latest_match
[12:32:56] [PASSED] pf_negotiate_latest_newer
[12:32:56] [PASSED] pf_negotiate_latest_next
[12:32:56] [SKIPPED] pf_negotiate_latest_older (no older minor)
[12:32:56] [SKIPPED] pf_negotiate_latest_prev (no prev major)
[12:32:56] =================== [PASSED] pf_service ====================
[12:32:56] ================= xe_guc_g2g (2 subtests) ==================
[12:32:56] ============== xe_live_guc_g2g_kunit_default ==============
[12:32:56] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[12:32:56] ============== xe_live_guc_g2g_kunit_allmem ===============
[12:32:56] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[12:32:56] =================== [SKIPPED] xe_guc_g2g ===================
[12:32:56] =================== xe_mocs (2 subtests) ===================
[12:32:56] ================ xe_live_mocs_kernel_kunit ================
[12:32:56] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[12:32:56] ================ xe_live_mocs_reset_kunit =================
[12:32:56] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[12:32:56] ==================== [SKIPPED] xe_mocs =====================
[12:32:56] ================= xe_migrate (2 subtests) ==================
[12:32:56] ================= xe_migrate_sanity_kunit =================
[12:32:56] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[12:32:56] ================== xe_validate_ccs_kunit ==================
[12:32:56] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[12:32:56] =================== [SKIPPED] xe_migrate ===================
[12:32:56] ================== xe_dma_buf (1 subtest) ==================
[12:32:56] ==================== xe_dma_buf_kunit =====================
[12:32:56] ================ [SKIPPED] xe_dma_buf_kunit ================
[12:32:56] =================== [SKIPPED] xe_dma_buf ===================
[12:32:56] ================= xe_bo_shrink (1 subtest) =================
[12:32:56] =================== xe_bo_shrink_kunit ====================
[12:32:56] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[12:32:56] ================== [SKIPPED] xe_bo_shrink ==================
[12:32:56] ==================== xe_bo (2 subtests) ====================
[12:32:56] ================== xe_ccs_migrate_kunit ===================
[12:32:56] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[12:32:56] ==================== xe_bo_evict_kunit ====================
[12:32:56] =============== [SKIPPED] xe_bo_evict_kunit ================
[12:32:56] ===================== [SKIPPED] xe_bo ======================
[12:32:56] ==================== args (13 subtests) ====================
[12:32:56] [PASSED] count_args_test
[12:32:56] [PASSED] call_args_example
[12:32:56] [PASSED] call_args_test
[12:32:56] [PASSED] drop_first_arg_example
[12:32:56] [PASSED] drop_first_arg_test
[12:32:56] [PASSED] first_arg_example
[12:32:56] [PASSED] first_arg_test
[12:32:56] [PASSED] last_arg_example
[12:32:56] [PASSED] last_arg_test
[12:32:56] [PASSED] pick_arg_example
[12:32:56] [PASSED] if_args_example
[12:32:56] [PASSED] if_args_test
[12:32:56] [PASSED] sep_comma_example
[12:32:56] ====================== [PASSED] args =======================
[12:32:56] =================== xe_pci (3 subtests) ====================
[12:32:56] ==================== check_graphics_ip ====================
[12:32:56] [PASSED] 12.00 Xe_LP
[12:32:56] [PASSED] 12.10 Xe_LP+
[12:32:56] [PASSED] 12.55 Xe_HPG
[12:32:56] [PASSED] 12.60 Xe_HPC
[12:32:56] [PASSED] 12.70 Xe_LPG
[12:32:56] [PASSED] 12.71 Xe_LPG
[12:32:56] [PASSED] 12.74 Xe_LPG+
[12:32:56] [PASSED] 20.01 Xe2_HPG
[12:32:56] [PASSED] 20.02 Xe2_HPG
[12:32:56] [PASSED] 20.04 Xe2_LPG
[12:32:56] [PASSED] 30.00 Xe3_LPG
[12:32:56] [PASSED] 30.01 Xe3_LPG
[12:32:56] [PASSED] 30.03 Xe3_LPG
[12:32:56] [PASSED] 30.04 Xe3_LPG
[12:32:56] [PASSED] 30.05 Xe3_LPG
[12:32:56] [PASSED] 35.10 Xe3p_LPG
[12:32:56] [PASSED] 35.11 Xe3p_XPC
[12:32:56] ================ [PASSED] check_graphics_ip ================
[12:32:56] ===================== check_media_ip ======================
[12:32:56] [PASSED] 12.00 Xe_M
[12:32:56] [PASSED] 12.55 Xe_HPM
[12:32:56] [PASSED] 13.00 Xe_LPM+
[12:32:56] [PASSED] 13.01 Xe2_HPM
[12:32:56] [PASSED] 20.00 Xe2_LPM
[12:32:56] [PASSED] 30.00 Xe3_LPM
[12:32:56] [PASSED] 30.02 Xe3_LPM
[12:32:56] [PASSED] 35.00 Xe3p_LPM
[12:32:56] [PASSED] 35.03 Xe3p_HPM
[12:32:56] ================= [PASSED] check_media_ip ==================
[12:32:56] =================== check_platform_desc ===================
[12:32:56] [PASSED] 0x9A60 (TIGERLAKE)
[12:32:56] [PASSED] 0x9A68 (TIGERLAKE)
[12:32:56] [PASSED] 0x9A70 (TIGERLAKE)
[12:32:56] [PASSED] 0x9A40 (TIGERLAKE)
[12:32:56] [PASSED] 0x9A49 (TIGERLAKE)
[12:32:56] [PASSED] 0x9A59 (TIGERLAKE)
[12:32:56] [PASSED] 0x9A78 (TIGERLAKE)
[12:32:56] [PASSED] 0x9AC0 (TIGERLAKE)
[12:32:56] [PASSED] 0x9AC9 (TIGERLAKE)
[12:32:56] [PASSED] 0x9AD9 (TIGERLAKE)
[12:32:56] [PASSED] 0x9AF8 (TIGERLAKE)
[12:32:56] [PASSED] 0x4C80 (ROCKETLAKE)
[12:32:56] [PASSED] 0x4C8A (ROCKETLAKE)
[12:32:56] [PASSED] 0x4C8B (ROCKETLAKE)
[12:32:56] [PASSED] 0x4C8C (ROCKETLAKE)
[12:32:56] [PASSED] 0x4C90 (ROCKETLAKE)
[12:32:56] [PASSED] 0x4C9A (ROCKETLAKE)
[12:32:56] [PASSED] 0x4680 (ALDERLAKE_S)
[12:32:56] [PASSED] 0x4682 (ALDERLAKE_S)
[12:32:56] [PASSED] 0x4688 (ALDERLAKE_S)
[12:32:56] [PASSED] 0x468A (ALDERLAKE_S)
[12:32:56] [PASSED] 0x468B (ALDERLAKE_S)
[12:32:56] [PASSED] 0x4690 (ALDERLAKE_S)
[12:32:56] [PASSED] 0x4692 (ALDERLAKE_S)
[12:32:56] [PASSED] 0x4693 (ALDERLAKE_S)
[12:32:56] [PASSED] 0x46A0 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46A1 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46A2 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46A3 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46A6 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46A8 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46AA (ALDERLAKE_P)
[12:32:56] [PASSED] 0x462A (ALDERLAKE_P)
[12:32:56] [PASSED] 0x4626 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x4628 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46B0 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46B1 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46B2 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46B3 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46C0 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46C1 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46C2 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46C3 (ALDERLAKE_P)
[12:32:56] [PASSED] 0x46D0 (ALDERLAKE_N)
[12:32:56] [PASSED] 0x46D1 (ALDERLAKE_N)
[12:32:56] [PASSED] 0x46D2 (ALDERLAKE_N)
[12:32:56] [PASSED] 0x46D3 (ALDERLAKE_N)
[12:32:56] [PASSED] 0x46D4 (ALDERLAKE_N)
[12:32:56] [PASSED] 0xA721 (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7A1 (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7A9 (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7AC (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7AD (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA720 (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7A0 (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7A8 (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7AA (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA7AB (ALDERLAKE_P)
[12:32:56] [PASSED] 0xA780 (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA781 (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA782 (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA783 (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA788 (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA789 (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA78A (ALDERLAKE_S)
[12:32:56] [PASSED] 0xA78B (ALDERLAKE_S)
[12:32:56] [PASSED] 0x4905 (DG1)
[12:32:56] [PASSED] 0x4906 (DG1)
[12:32:56] [PASSED] 0x4907 (DG1)
[12:32:56] [PASSED] 0x4908 (DG1)
[12:32:56] [PASSED] 0x4909 (DG1)
[12:32:56] [PASSED] 0x56C0 (DG2)
[12:32:56] [PASSED] 0x56C2 (DG2)
[12:32:56] [PASSED] 0x56C1 (DG2)
[12:32:56] [PASSED] 0x7D51 (METEORLAKE)
[12:32:56] [PASSED] 0x7DD1 (METEORLAKE)
[12:32:56] [PASSED] 0x7D41 (METEORLAKE)
[12:32:56] [PASSED] 0x7D67 (METEORLAKE)
[12:32:56] [PASSED] 0xB640 (METEORLAKE)
[12:32:56] [PASSED] 0x56A0 (DG2)
[12:32:56] [PASSED] 0x56A1 (DG2)
[12:32:56] [PASSED] 0x56A2 (DG2)
[12:32:56] [PASSED] 0x56BE (DG2)
[12:32:56] [PASSED] 0x56BF (DG2)
[12:32:56] [PASSED] 0x5690 (DG2)
[12:32:56] [PASSED] 0x5691 (DG2)
[12:32:56] [PASSED] 0x5692 (DG2)
[12:32:56] [PASSED] 0x56A5 (DG2)
[12:32:56] [PASSED] 0x56A6 (DG2)
[12:32:56] [PASSED] 0x56B0 (DG2)
[12:32:56] [PASSED] 0x56B1 (DG2)
[12:32:56] [PASSED] 0x56BA (DG2)
[12:32:56] [PASSED] 0x56BB (DG2)
[12:32:56] [PASSED] 0x56BC (DG2)
[12:32:56] [PASSED] 0x56BD (DG2)
[12:32:56] [PASSED] 0x5693 (DG2)
[12:32:56] [PASSED] 0x5694 (DG2)
[12:32:56] [PASSED] 0x5695 (DG2)
[12:32:56] [PASSED] 0x56A3 (DG2)
[12:32:56] [PASSED] 0x56A4 (DG2)
[12:32:56] [PASSED] 0x56B2 (DG2)
[12:32:56] [PASSED] 0x56B3 (DG2)
[12:32:56] [PASSED] 0x5696 (DG2)
[12:32:56] [PASSED] 0x5697 (DG2)
[12:32:56] [PASSED] 0xB69 (PVC)
[12:32:56] [PASSED] 0xB6E (PVC)
[12:32:56] [PASSED] 0xBD4 (PVC)
[12:32:56] [PASSED] 0xBD5 (PVC)
[12:32:56] [PASSED] 0xBD6 (PVC)
[12:32:56] [PASSED] 0xBD7 (PVC)
[12:32:56] [PASSED] 0xBD8 (PVC)
[12:32:56] [PASSED] 0xBD9 (PVC)
[12:32:56] [PASSED] 0xBDA (PVC)
[12:32:56] [PASSED] 0xBDB (PVC)
[12:32:56] [PASSED] 0xBE0 (PVC)
[12:32:56] [PASSED] 0xBE1 (PVC)
[12:32:56] [PASSED] 0xBE5 (PVC)
[12:32:56] [PASSED] 0x7D40 (METEORLAKE)
[12:32:56] [PASSED] 0x7D45 (METEORLAKE)
[12:32:56] [PASSED] 0x7D55 (METEORLAKE)
[12:32:56] [PASSED] 0x7D60 (METEORLAKE)
[12:32:56] [PASSED] 0x7DD5 (METEORLAKE)
[12:32:56] [PASSED] 0x6420 (LUNARLAKE)
[12:32:56] [PASSED] 0x64A0 (LUNARLAKE)
[12:32:56] [PASSED] 0x64B0 (LUNARLAKE)
[12:32:56] [PASSED] 0xE202 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE209 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE20B (BATTLEMAGE)
[12:32:56] [PASSED] 0xE20C (BATTLEMAGE)
[12:32:56] [PASSED] 0xE20D (BATTLEMAGE)
[12:32:56] [PASSED] 0xE210 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE211 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE212 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE216 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE220 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE221 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE222 (BATTLEMAGE)
[12:32:56] [PASSED] 0xE223 (BATTLEMAGE)
[12:32:56] [PASSED] 0xB080 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB081 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB082 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB083 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB084 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB085 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB086 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB087 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB08F (PANTHERLAKE)
[12:32:56] [PASSED] 0xB090 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB0A0 (PANTHERLAKE)
[12:32:56] [PASSED] 0xB0B0 (PANTHERLAKE)
[12:32:56] [PASSED] 0xFD80 (PANTHERLAKE)
[12:32:56] [PASSED] 0xFD81 (PANTHERLAKE)
[12:32:56] [PASSED] 0xD740 (NOVALAKE_S)
[12:32:56] [PASSED] 0xD741 (NOVALAKE_S)
[12:32:56] [PASSED] 0xD742 (NOVALAKE_S)
[12:32:56] [PASSED] 0xD743 (NOVALAKE_S)
[12:32:56] [PASSED] 0xD745 (NOVALAKE_S)
[12:32:56] [PASSED] 0xD74A (NOVALAKE_S)
[12:32:56] [PASSED] 0xD74B (NOVALAKE_S)
[12:32:56] [PASSED] 0x674C (CRESCENTISLAND)
[12:32:56] [PASSED] 0x674D (CRESCENTISLAND)
[12:32:56] [PASSED] 0x674E (CRESCENTISLAND)
[12:32:56] [PASSED] 0x674F (CRESCENTISLAND)
[12:32:56] [PASSED] 0x6750 (CRESCENTISLAND)
[12:32:56] [PASSED] 0xD750 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD751 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD752 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD753 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD754 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD755 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD756 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD757 (NOVALAKE_P)
[12:32:56] [PASSED] 0xD75F (NOVALAKE_P)
[12:32:56] =============== [PASSED] check_platform_desc ===============
[12:32:56] ===================== [PASSED] xe_pci ======================
[12:32:56] ============= xe_rtp_tables_test (5 subtests) ==============
[12:32:56] ================== xe_rtp_table_gt_test ===================
[12:32:56] [PASSED] gt_was/14011060649
[12:32:56] [PASSED] gt_was/14011059788
[12:32:56] [PASSED] gt_was/14015795083
[12:32:56] [PASSED] gt_was/16021867713
[12:32:56] [PASSED] gt_was/14019449301
[12:32:56] [PASSED] gt_was/16028005424
[12:32:56] [PASSED] gt_was/14026578760
[12:32:56] [PASSED] gt_was/1409420604
[12:32:56] [PASSED] gt_was/1408615072
[12:32:56] [PASSED] gt_was/22010523718
[12:32:56] [PASSED] gt_was/14011006942
[12:32:56] [PASSED] gt_was/14014830051
[12:32:56] [PASSED] gt_was/18018781329
[12:32:56] [PASSED] gt_was/1509235366
[12:32:56] [PASSED] gt_was/18018781329
[12:32:56] [PASSED] gt_was/16016694945
[12:32:56] [PASSED] gt_was/14018575942
[12:32:56] [PASSED] gt_was/22016670082
[12:32:56] [PASSED] gt_was/22016670082
[12:32:56] [PASSED] gt_was/14017421178
[12:32:56] [PASSED] gt_was/16025250150
[12:32:56] [PASSED] gt_was/14021871409
[12:32:56] [PASSED] gt_was/16021865536
[12:32:56] [PASSED] gt_was/14021486841
[12:32:56] [PASSED] gt_was/14025160223
[12:32:56] [PASSED] gt_was/14026144927, 16029437861, 14026127056
[12:32:56] [PASSED] gt_was/14025635424
[12:32:56] [PASSED] gt_was/16028005424
[12:32:56] ============== [PASSED] xe_rtp_table_gt_test ===============
[12:32:56] ================== xe_rtp_table_gt_test ===================
[12:32:56] [PASSED] gt_tunings/Tuning: Blend Fill Caching Optimization Disable
[12:32:56] [PASSED] gt_tunings/Tuning: 32B Access Enable
[12:32:56] [PASSED] gt_tunings/Tuning: L3 cache
[12:32:56] [PASSED] gt_tunings/Tuning: L3 cache - media
[12:32:56] [PASSED] gt_tunings/Tuning: Compression Overfetch
[12:32:56] [PASSED] gt_tunings/Tuning: Compression Overfetch - media
[12:32:56] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3
[12:32:56] [PASSED] gt_tunings/Tuning: Enable compressible partial write overfetch in L3 - media
[12:32:56] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only
[12:32:56] [PASSED] gt_tunings/Tuning: L2 Overfetch Compressible Only - media
[12:32:56] [PASSED] gt_tunings/Tuning: Stateless compression control
[12:32:56] [PASSED] gt_tunings/Tuning: Stateless compression control - media
[12:32:56] [PASSED] gt_tunings/Tuning: L3 RW flush all Cache
[12:32:56] [PASSED] gt_tunings/Tuning: L3 RW flush all cache - media
[12:32:56] [PASSED] gt_tunings/Tuning: Set STLB Bank Hash Mode to 4KB
[12:32:56] ============== [PASSED] xe_rtp_table_gt_test ===============
[12:32:56] ================== xe_rtp_table_oob_test ==================
[12:32:56] [PASSED] oob_was/1607983814
[12:32:56] [PASSED] oob_was/16010904313
[12:32:56] [PASSED] oob_was/18022495364
[12:32:56] [PASSED] oob_was/22012773006
[12:32:56] [PASSED] oob_was/14014475959
[12:32:56] [PASSED] oob_was/22011391025
[12:32:56] [PASSED] oob_was/22012727170
[12:32:56] [PASSED] oob_was/22012727685
[12:32:56] [PASSED] oob_was/22016596838
[12:32:56] [PASSED] oob_was/18020744125
[12:32:56] [PASSED] oob_was/1409600907
[12:32:56] [PASSED] oob_was/22014953428
[12:32:56] [PASSED] oob_was/16017236439
[12:32:56] [PASSED] oob_was/14019821291
[12:32:56] [PASSED] oob_was/14015076503
[12:32:56] [PASSED] oob_was/14018913170
[12:32:56] [PASSED] oob_was/14018094691
[12:32:56] [PASSED] oob_was/18024947630
[12:32:56] [PASSED] oob_was/16022287689
[12:32:56] [PASSED] oob_was/13011645652
[12:32:56] [PASSED] oob_was/14022293748
[12:32:56] [PASSED] oob_was/22019794406
[12:32:56] [PASSED] oob_was/22019338487
[12:32:56] [PASSED] oob_was/16023588340
[12:32:56] [PASSED] oob_was/14019789679
[12:32:56] [PASSED] oob_was/14022866841
[12:32:56] [PASSED] oob_was/16021333562
[12:32:56] [PASSED] oob_was/14016712196
[12:32:56] [PASSED] oob_was/14015568240
[12:32:56] [PASSED] oob_was/18013179988
[12:32:56] [PASSED] oob_was/1508761755
[12:32:56] [PASSED] oob_was/16023105232
[12:32:56] [PASSED] oob_was/16026508708
[12:32:56] [PASSED] oob_was/14020001231
[12:32:56] [PASSED] oob_was/16023683509
[12:32:56] [PASSED] oob_was/14025515070
[12:32:56] [PASSED] oob_was/15015404425_disable
[12:32:56] [PASSED] oob_was/16026007364
[12:32:56] [PASSED] oob_was/14020316580
[12:32:56] [PASSED] oob_was/14025883347
[12:32:56] [PASSED] oob_was/16029380221
[12:32:56] [PASSED] oob_was/22022079272
[12:32:56] [PASSED] oob_was/16029897822
[12:32:56] ============== [PASSED] xe_rtp_table_oob_test ==============
[12:32:56] ================ xe_rtp_table_dev_oob_test ================
[12:32:56] [PASSED] device_oob_was/22010954014
[12:32:56] [PASSED] device_oob_was/15015404425
[12:32:56] [PASSED] device_oob_was/22019338487_display
[12:32:56] [PASSED] device_oob_was/14022085890
[12:32:56] [PASSED] device_oob_was/14026539277
[12:32:56] [PASSED] device_oob_was/14026633728
[12:32:56] [PASSED] device_oob_was/14026746987
[12:32:56] [PASSED] device_oob_was/14026779378
[12:32:56] ============ [PASSED] xe_rtp_table_dev_oob_test ============
[12:32:56] ========== xe_rtp_table_missing_upper_bound_test ==========
[12:32:56] [PASSED] register_whitelist/WaAllowPMDepthAndInvocationCountAccessFromUMD, 1408556865
[12:32:56] [PASSED] register_whitelist/1508744258, 14012131227, 1808121037
[12:32:56] [PASSED] register_whitelist/1806527549
[12:32:56] [PASSED] register_whitelist/allow_read_ctx_timestamp
[12:32:56] [PASSED] register_whitelist/allow_read_queue_timestamp
[12:32:56] [PASSED] register_whitelist/16014440446
[12:32:56] [PASSED] register_whitelist/16017236439
[12:32:56] [PASSED] register_whitelist/16020183090
[12:32:56] [PASSED] register_whitelist/14024997852
[12:32:56] [PASSED] register_whitelist/14024997852
[12:32:56] ====== [PASSED] xe_rtp_table_missing_upper_bound_test ======
[12:32:56] =============== [PASSED] xe_rtp_tables_test ================
[12:32:56] =================== xe_rtp (3 subtests) ====================
[12:32:56] =================== xe_rtp_rules_tests ====================
[12:32:56] [PASSED] no
[12:32:56] [PASSED] yes
[12:32:56] [PASSED] no-and-no
[12:32:56] [PASSED] no-and-yes
[12:32:56] [PASSED] yes-and-no
[12:32:56] [PASSED] yes-and-yes
[12:32:56] [PASSED] no-or-no
[12:32:56] [PASSED] no-or-yes
[12:32:56] [PASSED] yes-or-no
[12:32:56] [PASSED] yes-or-yes
[12:32:56] [PASSED] no-yes-or-yes-no
[12:32:56] [PASSED] no-yes-or-yes-yes
[12:32:56] [PASSED] yes-yes-or-no-yes
[12:32:56] [PASSED] yes-yes-or-yes-yes
[12:32:56] [PASSED] no-no-or-yes-or-no
[12:32:56] [PASSED] or
[12:32:56] [PASSED] or-yes
[12:32:56] [PASSED] or-no
[12:32:56] [PASSED] yes-or
[12:32:56] [PASSED] no-or
[12:32:56] [PASSED] no-or-or-yes
[12:32:56] [PASSED] yes-or-or-no
[12:32:56] [PASSED] no-or-or-no
[12:32:56] [PASSED] missing-context-engine-class
[12:32:56] [PASSED] missing-context-engine-class-or-yes
[12:32:56] [PASSED] missing-context-engine-class-or-or-yes
[12:32:56] =============== [PASSED] xe_rtp_rules_tests ================
[12:32:56] =============== xe_rtp_process_to_sr_tests ================
[12:32:56] [PASSED] coalesce-same-reg
[12:32:56] [PASSED] coalesce-same-reg-literal-and-func
[12:32:56] [PASSED] no-match-no-add
[12:32:56] [PASSED] two-regs-two-entries
[12:32:56] [PASSED] clr-one-set-other
[12:32:56] [PASSED] set-field
[12:32:56] [PASSED] conflict-duplicate
[12:32:56] [PASSED] conflict-not-disjoint
[12:32:56] [PASSED] conflict-not-disjoint-literal-and-func
[12:32:56] [PASSED] conflict-reg-type
[12:32:56] [PASSED] bad-mcr-reg-forced-to-regular
[12:32:56] [PASSED] bad-regular-reg-forced-to-mcr
[12:32:56] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[12:32:56] ================== xe_rtp_process_tests ===================
[12:32:56] [PASSED] active1
[12:32:56] [PASSED] active2
[12:32:56] [PASSED] active-inactive
[12:32:56] [PASSED] inactive-active
[12:32:56] [PASSED] inactive-active-inactive
[12:32:56] [PASSED] inactive-inactive-inactive
[12:32:56] ============== [PASSED] xe_rtp_process_tests ===============
[12:32:56] ===================== [PASSED] xe_rtp ======================
[12:32:56] ==================== xe_wa (1 subtest) =====================
[12:32:56] ======================== xe_wa_gt =========================
[12:32:56] [PASSED] TIGERLAKE B0
[12:32:56] [PASSED] DG1 A0
[12:32:56] [PASSED] DG1 B0
[12:32:56] [PASSED] ALDERLAKE_S A0
[12:32:56] [PASSED] ALDERLAKE_S B0
[12:32:56] [PASSED] ALDERLAKE_S C0
[12:32:56] [PASSED] ALDERLAKE_S D0
[12:32:56] [PASSED] ALDERLAKE_P A0
[12:32:56] [PASSED] ALDERLAKE_P B0
[12:32:56] [PASSED] ALDERLAKE_P C0
[12:32:56] [PASSED] ALDERLAKE_S RPLS D0
[12:32:56] [PASSED] ALDERLAKE_P RPLU E0
[12:32:56] [PASSED] DG2 G10 C0
[12:32:56] [PASSED] DG2 G11 B1
[12:32:56] [PASSED] DG2 G12 A1
[12:32:56] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:32:56] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[12:32:56] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[12:32:56] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[12:32:56] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[12:32:56] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[12:32:56] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[12:32:56] ==================== [PASSED] xe_wa_gt =====================
[12:32:56] ====================== [PASSED] xe_wa ======================
[12:32:56] ============================================================
[12:32:56] Testing complete. Ran 741 tests: passed: 723, skipped: 18
[12:32:56] Elapsed time: 37.416s total, 4.427s configuring, 32.323s building, 0.647s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[12:32:56] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:32:58] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:33:23] Starting KUnit Kernel (1/1)...
[12:33:23] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:33:23] ============ drm_test_pick_cmdline (2 subtests) ============
[12:33:23] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[12:33:23] =============== drm_test_pick_cmdline_named ===============
[12:33:23] [PASSED] NTSC
[12:33:23] [PASSED] NTSC-J
[12:33:23] [PASSED] PAL
[12:33:23] [PASSED] PAL-M
[12:33:23] =========== [PASSED] drm_test_pick_cmdline_named ===========
[12:33:23] ============== [PASSED] drm_test_pick_cmdline ==============
[12:33:23] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[12:33:23] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[12:33:23] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[12:33:23] =========== drm_validate_clone_mode (2 subtests) ===========
[12:33:23] ============== drm_test_check_in_clone_mode ===============
[12:33:23] [PASSED] in_clone_mode
[12:33:23] [PASSED] not_in_clone_mode
[12:33:23] ========== [PASSED] drm_test_check_in_clone_mode ===========
[12:33:23] =============== drm_test_check_valid_clones ===============
[12:33:23] [PASSED] not_in_clone_mode
[12:33:23] [PASSED] valid_clone
[12:33:23] [PASSED] invalid_clone
[12:33:23] =========== [PASSED] drm_test_check_valid_clones ===========
[12:33:23] ============= [PASSED] drm_validate_clone_mode =============
[12:33:23] ============= drm_validate_modeset (1 subtest) =============
[12:33:23] [PASSED] drm_test_check_connector_changed_modeset
[12:33:23] ============== [PASSED] drm_validate_modeset ===============
[12:33:23] ====== drm_test_bridge_get_current_state (1 subtest) =======
[12:33:23] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[12:33:23] ======== [PASSED] drm_test_bridge_get_current_state ========
[12:33:23] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[12:33:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[12:33:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[12:33:23] [PASSED] drm_test_drm_bridge_helper_hdmi_output_bus_fmts
[12:33:23] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[12:33:23] ============== drm_bridge_alloc (2 subtests) ===============
[12:33:23] [PASSED] drm_test_drm_bridge_alloc_basic
[12:33:23] [PASSED] drm_test_drm_bridge_alloc_get_put
[12:33:23] ================ [PASSED] drm_bridge_alloc =================
[12:33:23] ============= drm_bridge_bus_fmt (5 subtests) ==============
[12:33:23] [PASSED] drm_test_bridge_rgb_yuv_rgb
[12:33:23] [PASSED] drm_test_bridge_must_convert_to_yuv444
[12:33:23] [PASSED] drm_test_bridge_hdmi_auto_rgb
[12:33:23] [PASSED] drm_test_bridge_auto_first
[12:33:23] [PASSED] drm_test_bridge_rgb_yuv_no_path
[12:33:23] =============== [PASSED] drm_bridge_bus_fmt ================
[12:33:23] ============= drm_cmdline_parser (40 subtests) =============
[12:33:23] [PASSED] drm_test_cmdline_force_d_only
[12:33:23] [PASSED] drm_test_cmdline_force_D_only_dvi
[12:33:23] [PASSED] drm_test_cmdline_force_D_only_hdmi
[12:33:23] [PASSED] drm_test_cmdline_force_D_only_not_digital
[12:33:23] [PASSED] drm_test_cmdline_force_e_only
[12:33:23] [PASSED] drm_test_cmdline_res
[12:33:23] [PASSED] drm_test_cmdline_res_vesa
[12:33:23] [PASSED] drm_test_cmdline_res_vesa_rblank
[12:33:23] [PASSED] drm_test_cmdline_res_rblank
[12:33:23] [PASSED] drm_test_cmdline_res_bpp
[12:33:23] [PASSED] drm_test_cmdline_res_refresh
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[12:33:23] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[12:33:23] [PASSED] drm_test_cmdline_res_margins_force_on
[12:33:23] [PASSED] drm_test_cmdline_res_vesa_margins
[12:33:23] [PASSED] drm_test_cmdline_name
[12:33:23] [PASSED] drm_test_cmdline_name_bpp
[12:33:23] [PASSED] drm_test_cmdline_name_option
[12:33:23] [PASSED] drm_test_cmdline_name_bpp_option
[12:33:23] [PASSED] drm_test_cmdline_rotate_0
[12:33:23] [PASSED] drm_test_cmdline_rotate_90
[12:33:23] [PASSED] drm_test_cmdline_rotate_180
[12:33:23] [PASSED] drm_test_cmdline_rotate_270
[12:33:23] [PASSED] drm_test_cmdline_hmirror
[12:33:23] [PASSED] drm_test_cmdline_vmirror
[12:33:23] [PASSED] drm_test_cmdline_margin_options
[12:33:23] [PASSED] drm_test_cmdline_multiple_options
[12:33:23] [PASSED] drm_test_cmdline_bpp_extra_and_option
[12:33:23] [PASSED] drm_test_cmdline_extra_and_option
[12:33:23] [PASSED] drm_test_cmdline_freestanding_options
[12:33:23] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[12:33:23] [PASSED] drm_test_cmdline_panel_orientation
[12:33:23] ================ drm_test_cmdline_invalid =================
[12:33:23] [PASSED] margin_only
[12:33:23] [PASSED] interlace_only
[12:33:23] [PASSED] res_missing_x
[12:33:23] [PASSED] res_missing_y
[12:33:23] [PASSED] res_bad_y
[12:33:23] [PASSED] res_missing_y_bpp
[12:33:23] [PASSED] res_bad_bpp
[12:33:23] [PASSED] res_bad_refresh
[12:33:23] [PASSED] res_bpp_refresh_force_on_off
[12:33:23] [PASSED] res_invalid_mode
[12:33:23] [PASSED] res_bpp_wrong_place_mode
[12:33:23] [PASSED] name_bpp_refresh
[12:33:23] [PASSED] name_refresh
[12:33:23] [PASSED] name_refresh_wrong_mode
[12:33:23] [PASSED] name_refresh_invalid_mode
[12:33:23] [PASSED] rotate_multiple
[12:33:23] [PASSED] rotate_invalid_val
[12:33:23] [PASSED] rotate_truncated
[12:33:23] [PASSED] invalid_option
[12:33:23] [PASSED] invalid_tv_option
[12:33:23] [PASSED] truncated_tv_option
[12:33:23] ============ [PASSED] drm_test_cmdline_invalid =============
[12:33:23] =============== drm_test_cmdline_tv_options ===============
[12:33:23] [PASSED] NTSC
[12:33:23] [PASSED] NTSC_443
[12:33:23] [PASSED] NTSC_J
[12:33:23] [PASSED] PAL
[12:33:23] [PASSED] PAL_M
[12:33:23] [PASSED] PAL_N
[12:33:23] [PASSED] SECAM
[12:33:23] [PASSED] MONO_525
[12:33:23] [PASSED] MONO_625
[12:33:23] =========== [PASSED] drm_test_cmdline_tv_options ===========
[12:33:23] =============== [PASSED] drm_cmdline_parser ================
[12:33:23] ========== drmm_connector_hdmi_init (20 subtests) ==========
[12:33:23] [PASSED] drm_test_connector_hdmi_init_valid
[12:33:23] [PASSED] drm_test_connector_hdmi_init_bpc_8
[12:33:23] [PASSED] drm_test_connector_hdmi_init_bpc_10
[12:33:23] [PASSED] drm_test_connector_hdmi_init_bpc_12
[12:33:23] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[12:33:23] [PASSED] drm_test_connector_hdmi_init_bpc_null
[12:33:23] [PASSED] drm_test_connector_hdmi_init_formats_empty
[12:33:23] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[12:33:23] === drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[12:33:23] [PASSED] supported_formats=0x9 yuv420_allowed=1
[12:33:23] [PASSED] supported_formats=0x9 yuv420_allowed=0
[12:33:23] [PASSED] supported_formats=0x5 yuv420_allowed=1
[12:33:23] [PASSED] supported_formats=0x5 yuv420_allowed=0
[12:33:23] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[12:33:23] [PASSED] drm_test_connector_hdmi_init_null_ddc
[12:33:23] [PASSED] drm_test_connector_hdmi_init_null_product
[12:33:23] [PASSED] drm_test_connector_hdmi_init_null_vendor
[12:33:23] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[12:33:23] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[12:33:23] [PASSED] drm_test_connector_hdmi_init_product_valid
[12:33:23] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[12:33:23] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[12:33:23] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[12:33:23] ========= drm_test_connector_hdmi_init_type_valid =========
[12:33:23] [PASSED] HDMI-A
[12:33:23] [PASSED] HDMI-B
[12:33:23] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[12:33:23] ======== drm_test_connector_hdmi_init_type_invalid ========
[12:33:23] [PASSED] Unknown
[12:33:23] [PASSED] VGA
[12:33:23] [PASSED] DVI-I
[12:33:23] [PASSED] DVI-D
[12:33:23] [PASSED] DVI-A
[12:33:23] [PASSED] Composite
[12:33:23] [PASSED] SVIDEO
[12:33:23] [PASSED] LVDS
[12:33:23] [PASSED] Component
[12:33:23] [PASSED] DIN
[12:33:23] [PASSED] DP
[12:33:23] [PASSED] TV
[12:33:23] [PASSED] eDP
[12:33:23] [PASSED] Virtual
[12:33:23] [PASSED] DSI
[12:33:23] [PASSED] DPI
[12:33:23] [PASSED] Writeback
[12:33:23] [PASSED] SPI
[12:33:23] [PASSED] USB
[12:33:23] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[12:33:23] ============ [PASSED] drmm_connector_hdmi_init =============
[12:33:23] ============= drmm_connector_init (3 subtests) =============
[12:33:23] [PASSED] drm_test_drmm_connector_init
[12:33:23] [PASSED] drm_test_drmm_connector_init_null_ddc
[12:33:23] ========= drm_test_drmm_connector_init_type_valid =========
[12:33:23] [PASSED] Unknown
[12:33:23] [PASSED] VGA
[12:33:23] [PASSED] DVI-I
[12:33:23] [PASSED] DVI-D
[12:33:23] [PASSED] DVI-A
[12:33:23] [PASSED] Composite
[12:33:23] [PASSED] SVIDEO
[12:33:23] [PASSED] LVDS
[12:33:23] [PASSED] Component
[12:33:23] [PASSED] DIN
[12:33:23] [PASSED] DP
[12:33:23] [PASSED] HDMI-A
[12:33:23] [PASSED] HDMI-B
[12:33:23] [PASSED] TV
[12:33:23] [PASSED] eDP
[12:33:23] [PASSED] Virtual
[12:33:23] [PASSED] DSI
[12:33:23] [PASSED] DPI
[12:33:23] [PASSED] Writeback
[12:33:23] [PASSED] SPI
[12:33:23] [PASSED] USB
[12:33:23] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[12:33:23] =============== [PASSED] drmm_connector_init ===============
[12:33:23] ========= drm_connector_dynamic_init (6 subtests) ==========
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_init
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_init_properties
[12:33:23] ===== drm_test_drm_connector_dynamic_init_type_valid ======
[12:33:23] [PASSED] Unknown
[12:33:23] [PASSED] VGA
[12:33:23] [PASSED] DVI-I
[12:33:23] [PASSED] DVI-D
[12:33:23] [PASSED] DVI-A
[12:33:23] [PASSED] Composite
[12:33:23] [PASSED] SVIDEO
[12:33:23] [PASSED] LVDS
[12:33:23] [PASSED] Component
[12:33:23] [PASSED] DIN
[12:33:23] [PASSED] DP
[12:33:23] [PASSED] HDMI-A
[12:33:23] [PASSED] HDMI-B
[12:33:23] [PASSED] TV
[12:33:23] [PASSED] eDP
[12:33:23] [PASSED] Virtual
[12:33:23] [PASSED] DSI
[12:33:23] [PASSED] DPI
[12:33:23] [PASSED] Writeback
[12:33:23] [PASSED] SPI
[12:33:23] [PASSED] USB
[12:33:23] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[12:33:23] ======== drm_test_drm_connector_dynamic_init_name =========
[12:33:23] [PASSED] Unknown
[12:33:23] [PASSED] VGA
[12:33:23] [PASSED] DVI-I
[12:33:23] [PASSED] DVI-D
[12:33:23] [PASSED] DVI-A
[12:33:23] [PASSED] Composite
[12:33:23] [PASSED] SVIDEO
[12:33:23] [PASSED] LVDS
[12:33:23] [PASSED] Component
[12:33:23] [PASSED] DIN
[12:33:23] [PASSED] DP
[12:33:23] [PASSED] HDMI-A
[12:33:23] [PASSED] HDMI-B
[12:33:23] [PASSED] TV
[12:33:23] [PASSED] eDP
[12:33:23] [PASSED] Virtual
[12:33:23] [PASSED] DSI
[12:33:23] [PASSED] DPI
[12:33:23] [PASSED] Writeback
[12:33:23] [PASSED] SPI
[12:33:23] [PASSED] USB
[12:33:23] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[12:33:23] =========== [PASSED] drm_connector_dynamic_init ============
[12:33:23] ==== drm_connector_dynamic_register_early (4 subtests) =====
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[12:33:23] ====== [PASSED] drm_connector_dynamic_register_early =======
[12:33:23] ======= drm_connector_dynamic_register (7 subtests) ========
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[12:33:23] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[12:33:23] ========= [PASSED] drm_connector_dynamic_register ==========
[12:33:23] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[12:33:23] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[12:33:23] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[12:33:23] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[12:33:23] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[12:33:23] ========== drm_test_get_tv_mode_from_name_valid ===========
[12:33:23] [PASSED] NTSC
[12:33:23] [PASSED] NTSC-443
[12:33:23] [PASSED] NTSC-J
[12:33:23] [PASSED] PAL
[12:33:23] [PASSED] PAL-M
[12:33:23] [PASSED] PAL-N
[12:33:23] [PASSED] SECAM
[12:33:23] [PASSED] Mono
[12:33:23] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[12:33:23] [PASSED] drm_test_get_tv_mode_from_name_truncated
[12:33:23] ============ [PASSED] drm_get_tv_mode_from_name ============
[12:33:23] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[12:33:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[12:33:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[12:33:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[12:33:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[12:33:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[12:33:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[12:33:23] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid =
[12:33:23] [PASSED] VIC 96
[12:33:23] [PASSED] VIC 97
[12:33:23] [PASSED] VIC 101
[12:33:23] [PASSED] VIC 102
[12:33:23] [PASSED] VIC 106
[12:33:23] [PASSED] VIC 107
[12:33:23] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[12:33:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[12:33:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[12:33:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[12:33:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[12:33:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[12:33:23] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[12:33:23] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[12:33:23] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ====
[12:33:23] [PASSED] Automatic
[12:33:23] [PASSED] Full
[12:33:23] [PASSED] Limited 16:235
[12:33:23] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[12:33:23] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[12:33:23] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[12:33:23] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[12:33:23] === drm_test_drm_hdmi_connector_get_output_format_name ====
[12:33:23] [PASSED] RGB
[12:33:23] [PASSED] YUV 4:2:0
[12:33:23] [PASSED] YUV 4:2:2
[12:33:23] [PASSED] YUV 4:4:4
[12:33:23] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[12:33:23] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[12:33:23] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[12:33:23] ============= drm_damage_helper (21 subtests) ==============
[12:33:23] [PASSED] drm_test_damage_iter_no_damage
[12:33:23] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[12:33:23] [PASSED] drm_test_damage_iter_no_damage_src_moved
[12:33:23] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[12:33:23] [PASSED] drm_test_damage_iter_no_damage_not_visible
[12:33:23] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[12:33:23] [PASSED] drm_test_damage_iter_no_damage_no_fb
[12:33:23] [PASSED] drm_test_damage_iter_simple_damage
[12:33:23] [PASSED] drm_test_damage_iter_single_damage
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_outside_src
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_src_moved
[12:33:23] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[12:33:23] [PASSED] drm_test_damage_iter_damage
[12:33:23] [PASSED] drm_test_damage_iter_damage_one_intersect
[12:33:23] [PASSED] drm_test_damage_iter_damage_one_outside
[12:33:23] [PASSED] drm_test_damage_iter_damage_src_moved
[12:33:23] [PASSED] drm_test_damage_iter_damage_not_visible
[12:33:23] ================ [PASSED] drm_damage_helper ================
[12:33:23] ============== drm_dp_mst_helper (3 subtests) ==============
[12:33:23] ============== drm_test_dp_mst_calc_pbn_mode ==============
[12:33:23] [PASSED] Clock 154000 BPP 30 DSC disabled
[12:33:23] [PASSED] Clock 234000 BPP 30 DSC disabled
[12:33:23] [PASSED] Clock 297000 BPP 24 DSC disabled
[12:33:23] [PASSED] Clock 332880 BPP 24 DSC enabled
[12:33:23] [PASSED] Clock 324540 BPP 24 DSC enabled
[12:33:23] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[12:33:23] ============== drm_test_dp_mst_calc_pbn_div ===============
[12:33:23] [PASSED] Link rate 2000000 lane count 4
[12:33:23] [PASSED] Link rate 2000000 lane count 2
[12:33:23] [PASSED] Link rate 2000000 lane count 1
[12:33:23] [PASSED] Link rate 1350000 lane count 4
[12:33:23] [PASSED] Link rate 1350000 lane count 2
[12:33:23] [PASSED] Link rate 1350000 lane count 1
[12:33:23] [PASSED] Link rate 1000000 lane count 4
[12:33:23] [PASSED] Link rate 1000000 lane count 2
[12:33:23] [PASSED] Link rate 1000000 lane count 1
[12:33:23] [PASSED] Link rate 810000 lane count 4
[12:33:23] [PASSED] Link rate 810000 lane count 2
[12:33:23] [PASSED] Link rate 810000 lane count 1
[12:33:23] [PASSED] Link rate 540000 lane count 4
[12:33:23] [PASSED] Link rate 540000 lane count 2
[12:33:23] [PASSED] Link rate 540000 lane count 1
[12:33:23] [PASSED] Link rate 270000 lane count 4
[12:33:23] [PASSED] Link rate 270000 lane count 2
[12:33:23] [PASSED] Link rate 270000 lane count 1
[12:33:23] [PASSED] Link rate 162000 lane count 4
[12:33:23] [PASSED] Link rate 162000 lane count 2
[12:33:23] [PASSED] Link rate 162000 lane count 1
[12:33:23] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[12:33:23] ========= drm_test_dp_mst_sideband_msg_req_decode =========
[12:33:23] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[12:33:23] [PASSED] DP_POWER_UP_PHY with port number
[12:33:23] [PASSED] DP_POWER_DOWN_PHY with port number
[12:33:23] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[12:33:23] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[12:33:23] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[12:33:23] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[12:33:23] [PASSED] DP_QUERY_PAYLOAD with port number
[12:33:23] [PASSED] DP_QUERY_PAYLOAD with VCPI
[12:33:23] [PASSED] DP_REMOTE_DPCD_READ with port number
[12:33:23] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[12:33:23] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[12:33:23] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[12:33:23] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[12:33:23] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[12:33:23] [PASSED] DP_REMOTE_I2C_READ with port number
[12:33:23] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[12:33:23] [PASSED] DP_REMOTE_I2C_READ with transactions array
[12:33:23] [PASSED] DP_REMOTE_I2C_WRITE with port number
[12:33:23] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[12:33:23] [PASSED] DP_REMOTE_I2C_WRITE with data array
[12:33:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[12:33:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[12:33:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[12:33:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[12:33:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[12:33:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[12:33:23] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[12:33:23] ================ [PASSED] drm_dp_mst_helper ================
[12:33:23] ================== drm_exec (7 subtests) ===================
[12:33:23] [PASSED] sanitycheck
[12:33:23] [PASSED] test_lock
[12:33:23] [PASSED] test_lock_unlock
[12:33:23] [PASSED] test_duplicates
[12:33:23] [PASSED] test_prepare
[12:33:23] [PASSED] test_prepare_array
[12:33:23] [PASSED] test_multiple_loops
[12:33:23] ==================== [PASSED] drm_exec =====================
[12:33:23] =========== drm_format_helper_test (17 subtests) ===========
[12:33:23] ============== drm_test_fb_xrgb8888_to_gray8 ==============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[12:33:23] ============= drm_test_fb_xrgb8888_to_rgb332 ==============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[12:33:23] ============= drm_test_fb_xrgb8888_to_rgb565 ==============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[12:33:23] ============ drm_test_fb_xrgb8888_to_xrgb1555 =============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[12:33:23] ============ drm_test_fb_xrgb8888_to_argb1555 =============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[12:33:23] ============ drm_test_fb_xrgb8888_to_rgba5551 =============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[12:33:23] ============= drm_test_fb_xrgb8888_to_rgb888 ==============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[12:33:23] ============= drm_test_fb_xrgb8888_to_bgr888 ==============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[12:33:23] ============ drm_test_fb_xrgb8888_to_argb8888 =============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[12:33:23] =========== drm_test_fb_xrgb8888_to_xrgb2101010 ===========
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[12:33:23] =========== drm_test_fb_xrgb8888_to_argb2101010 ===========
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[12:33:23] ============== drm_test_fb_xrgb8888_to_mono ===============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[12:33:23] ==================== drm_test_fb_swab =====================
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ================ [PASSED] drm_test_fb_swab =================
[12:33:23] ============ drm_test_fb_xrgb8888_to_xbgr8888 =============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[12:33:23] ============ drm_test_fb_xrgb8888_to_abgr8888 =============
[12:33:23] [PASSED] single_pixel_source_buffer
[12:33:23] [PASSED] single_pixel_clip_rectangle
[12:33:23] [PASSED] well_known_colors
[12:33:23] [PASSED] destination_pitch
[12:33:23] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[12:33:23] ================= drm_test_fb_clip_offset =================
[12:33:23] [PASSED] pass through
[12:33:23] [PASSED] horizontal offset
[12:33:23] [PASSED] vertical offset
[12:33:23] [PASSED] horizontal and vertical offset
[12:33:23] [PASSED] horizontal offset (custom pitch)
[12:33:23] [PASSED] vertical offset (custom pitch)
[12:33:23] [PASSED] horizontal and vertical offset (custom pitch)
[12:33:23] ============= [PASSED] drm_test_fb_clip_offset =============
[12:33:23] =================== drm_test_fb_memcpy ====================
[12:33:23] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[12:33:23] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[12:33:23] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[12:33:23] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[12:33:23] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[12:33:23] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[12:33:23] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[12:33:23] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[12:33:23] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[12:33:23] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[12:33:23] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[12:33:23] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[12:33:23] =============== [PASSED] drm_test_fb_memcpy ================
[12:33:23] ============= [PASSED] drm_format_helper_test ==============
[12:33:23] ================= drm_format (18 subtests) =================
[12:33:23] [PASSED] drm_test_format_block_width_invalid
[12:33:23] [PASSED] drm_test_format_block_width_one_plane
[12:33:23] [PASSED] drm_test_format_block_width_two_plane
[12:33:23] [PASSED] drm_test_format_block_width_three_plane
[12:33:23] [PASSED] drm_test_format_block_width_tiled
[12:33:23] [PASSED] drm_test_format_block_height_invalid
[12:33:23] [PASSED] drm_test_format_block_height_one_plane
[12:33:23] [PASSED] drm_test_format_block_height_two_plane
[12:33:23] [PASSED] drm_test_format_block_height_three_plane
[12:33:23] [PASSED] drm_test_format_block_height_tiled
[12:33:23] [PASSED] drm_test_format_min_pitch_invalid
[12:33:23] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[12:33:23] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[12:33:23] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[12:33:23] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[12:33:23] [PASSED] drm_test_format_min_pitch_two_plane
[12:33:23] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[12:33:23] [PASSED] drm_test_format_min_pitch_tiled
[12:33:23] =================== [PASSED] drm_format ====================
[12:33:23] ============== drm_framebuffer (10 subtests) ===============
[12:33:23] ========== drm_test_framebuffer_check_src_coords ==========
[12:33:23] [PASSED] Success: source fits into fb
[12:33:23] [PASSED] Fail: overflowing fb with x-axis coordinate
[12:33:23] [PASSED] Fail: overflowing fb with y-axis coordinate
[12:33:23] [PASSED] Fail: overflowing fb with source width
[12:33:23] [PASSED] Fail: overflowing fb with source height
[12:33:23] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[12:33:23] [PASSED] drm_test_framebuffer_cleanup
[12:33:23] =============== drm_test_framebuffer_create ===============
[12:33:23] [PASSED] ABGR8888 normal sizes
[12:33:23] [PASSED] ABGR8888 max sizes
[12:33:23] [PASSED] ABGR8888 pitch greater than min required
[12:33:23] [PASSED] ABGR8888 pitch less than min required
[12:33:23] [PASSED] ABGR8888 Invalid width
[12:33:23] [PASSED] ABGR8888 Invalid buffer handle
[12:33:23] [PASSED] No pixel format
[12:33:23] [PASSED] ABGR8888 Width 0
[12:33:23] [PASSED] ABGR8888 Height 0
[12:33:23] [PASSED] ABGR8888 Out of bound height * pitch combination
[12:33:23] [PASSED] ABGR8888 Large buffer offset
[12:33:23] [PASSED] ABGR8888 Buffer offset for inexistent plane
[12:33:23] [PASSED] ABGR8888 Invalid flag
[12:33:23] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[12:33:23] [PASSED] ABGR8888 Valid buffer modifier
[12:33:23] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[12:33:23] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] NV12 Normal sizes
[12:33:23] [PASSED] NV12 Max sizes
[12:33:23] [PASSED] NV12 Invalid pitch
[12:33:23] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[12:33:23] [PASSED] NV12 different modifier per-plane
[12:33:23] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[12:33:23] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] NV12 Modifier for inexistent plane
[12:33:23] [PASSED] NV12 Handle for inexistent plane
[12:33:23] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[12:33:23] [PASSED] YVU420 Normal sizes
[12:33:23] [PASSED] YVU420 Max sizes
[12:33:23] [PASSED] YVU420 Invalid pitch
[12:33:23] [PASSED] YVU420 Different pitches
[12:33:23] [PASSED] YVU420 Different buffer offsets/pitches
[12:33:23] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[12:33:23] [PASSED] YVU420 Valid modifier
[12:33:23] [PASSED] YVU420 Different modifiers per plane
[12:33:23] [PASSED] YVU420 Modifier for inexistent plane
[12:33:23] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[12:33:23] [PASSED] X0L2 Normal sizes
[12:33:23] [PASSED] X0L2 Max sizes
[12:33:23] [PASSED] X0L2 Invalid pitch
[12:33:23] [PASSED] X0L2 Pitch greater than minimum required
[12:33:23] [PASSED] X0L2 Handle for inexistent plane
[12:33:23] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[12:33:23] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[12:33:23] [PASSED] X0L2 Valid modifier
[12:33:23] [PASSED] X0L2 Modifier for inexistent plane
[12:33:23] =========== [PASSED] drm_test_framebuffer_create ===========
[12:33:23] [PASSED] drm_test_framebuffer_free
[12:33:23] [PASSED] drm_test_framebuffer_init
[12:33:23] [PASSED] drm_test_framebuffer_init_bad_format
[12:33:23] [PASSED] drm_test_framebuffer_init_dev_mismatch
[12:33:23] [PASSED] drm_test_framebuffer_lookup
[12:33:23] [PASSED] drm_test_framebuffer_lookup_inexistent
[12:33:23] [PASSED] drm_test_framebuffer_modifiers_not_supported
[12:33:23] ================= [PASSED] drm_framebuffer =================
[12:33:23] ================ drm_gem_shmem (8 subtests) ================
[12:33:23] [PASSED] drm_gem_shmem_test_obj_create
[12:33:23] [PASSED] drm_gem_shmem_test_obj_create_private
[12:33:23] [PASSED] drm_gem_shmem_test_pin_pages
[12:33:23] [PASSED] drm_gem_shmem_test_vmap
[12:33:23] [PASSED] drm_gem_shmem_test_get_sg_table
[12:33:23] [PASSED] drm_gem_shmem_test_get_pages_sgt
[12:33:23] [PASSED] drm_gem_shmem_test_madvise
[12:33:23] [PASSED] drm_gem_shmem_test_purge
[12:33:23] ================== [PASSED] drm_gem_shmem ==================
[12:33:23] === drm_atomic_helper_connector_hdmi_check (29 subtests) ===
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[12:33:23] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 =======
[12:33:23] [PASSED] Automatic
[12:33:23] [PASSED] Full
[12:33:23] [PASSED] Limited 16:235
[12:33:23] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[12:33:23] [PASSED] drm_test_check_disable_connector
[12:33:23] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[12:33:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[12:33:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[12:33:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[12:33:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[12:33:23] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[12:33:23] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[12:33:23] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[12:33:23] [PASSED] drm_test_check_output_bpc_dvi
[12:33:23] [PASSED] drm_test_check_output_bpc_format_vic_1
[12:33:23] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[12:33:23] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[12:33:23] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[12:33:23] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[12:33:23] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[12:33:23] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[12:33:23] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[12:33:23] ============ drm_test_check_hdmi_color_format =============
[12:33:23] [PASSED] AUTO -> RGB
[12:33:23] [PASSED] YCBCR422 -> YUV422
[12:33:23] [PASSED] YCBCR420 -> YUV420
[12:33:23] [PASSED] YCBCR444 -> YUV444
[12:33:23] [PASSED] RGB -> RGB
[12:33:23] ======== [PASSED] drm_test_check_hdmi_color_format =========
[12:33:23] ======== drm_test_check_hdmi_color_format_420_only ========
[12:33:23] [PASSED] RGB should fail
[12:33:23] [PASSED] YUV444 should fail
[12:33:23] [PASSED] YUV422 should fail
[12:33:23] [PASSED] YUV420 should work
[12:33:23] ==== [PASSED] drm_test_check_hdmi_color_format_420_only ====
[12:33:23] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[12:33:23] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[12:33:23] [PASSED] drm_test_check_broadcast_rgb_value
[12:33:23] [PASSED] drm_test_check_bpc_8_value
[12:33:23] [PASSED] drm_test_check_bpc_10_value
[12:33:23] [PASSED] drm_test_check_bpc_12_value
[12:33:23] [PASSED] drm_test_check_format_value
[12:33:23] [PASSED] drm_test_check_tmds_char_value
[12:33:23] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[12:33:23] = drm_atomic_helper_connector_hdmi_mode_valid (7 subtests) =
[12:33:23] [PASSED] drm_test_check_mode_valid
[12:33:23] [PASSED] drm_test_check_mode_valid_reject
[12:33:23] [PASSED] drm_test_check_mode_valid_reject_rate
[12:33:23] [PASSED] drm_test_check_mode_valid_reject_max_clock
[12:33:23] [PASSED] drm_test_check_mode_valid_yuv420_only_max_clock
[12:33:23] [PASSED] drm_test_check_mode_valid_reject_yuv420_only_connector
[12:33:23] [PASSED] drm_test_check_mode_valid_accept_yuv420_also_connector_rgb
[12:33:23] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[12:33:23] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[12:33:23] [PASSED] drm_test_check_infoframes
[12:33:23] [PASSED] drm_test_check_reject_avi_infoframe
[12:33:23] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[12:33:23] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[12:33:23] [PASSED] drm_test_check_reject_audio_infoframe
[12:33:23] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[12:33:23] ================= drm_managed (2 subtests) =================
[12:33:23] [PASSED] drm_test_managed_release_action
[12:33:23] [PASSED] drm_test_managed_run_action
[12:33:23] =================== [PASSED] drm_managed ===================
[12:33:23] =================== drm_mm (6 subtests) ====================
[12:33:23] [PASSED] drm_test_mm_init
[12:33:23] [PASSED] drm_test_mm_debug
[12:33:23] [PASSED] drm_test_mm_align32
[12:33:23] [PASSED] drm_test_mm_align64
[12:33:23] [PASSED] drm_test_mm_lowest
[12:33:23] [PASSED] drm_test_mm_highest
[12:33:23] ===================== [PASSED] drm_mm ======================
[12:33:23] ============= drm_modes_analog_tv (5 subtests) =============
[12:33:23] [PASSED] drm_test_modes_analog_tv_mono_576i
[12:33:23] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[12:33:23] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[12:33:23] [PASSED] drm_test_modes_analog_tv_pal_576i
[12:33:23] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[12:33:23] =============== [PASSED] drm_modes_analog_tv ===============
[12:33:23] ============== drm_plane_helper (2 subtests) ===============
[12:33:23] =============== drm_test_check_plane_state ================
[12:33:23] [PASSED] clipping_simple
[12:33:23] [PASSED] clipping_rotate_reflect
[12:33:23] [PASSED] positioning_simple
[12:33:23] [PASSED] upscaling
[12:33:23] [PASSED] downscaling
[12:33:23] [PASSED] rounding1
[12:33:23] [PASSED] rounding2
[12:33:23] [PASSED] rounding3
[12:33:23] [PASSED] rounding4
[12:33:23] =========== [PASSED] drm_test_check_plane_state ============
[12:33:23] =========== drm_test_check_invalid_plane_state ============
[12:33:23] [PASSED] positioning_invalid
[12:33:23] [PASSED] upscaling_invalid
[12:33:23] [PASSED] downscaling_invalid
[12:33:23] ======= [PASSED] drm_test_check_invalid_plane_state ========
[12:33:23] ================ [PASSED] drm_plane_helper =================
[12:33:23] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[12:33:23] ====== drm_test_connector_helper_tv_get_modes_check =======
[12:33:23] [PASSED] None
[12:33:23] [PASSED] PAL
[12:33:23] [PASSED] NTSC
[12:33:23] [PASSED] Both, NTSC Default
[12:33:23] [PASSED] Both, PAL Default
[12:33:23] [PASSED] Both, NTSC Default, with PAL on command-line
[12:33:23] [PASSED] Both, PAL Default, with NTSC on command-line
[12:33:23] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[12:33:23] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[12:33:23] ================== drm_rect (9 subtests) ===================
[12:33:23] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[12:33:23] [PASSED] drm_test_rect_clip_scaled_not_clipped
[12:33:23] [PASSED] drm_test_rect_clip_scaled_clipped
[12:33:23] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[12:33:23] ================= drm_test_rect_intersect =================
[12:33:23] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[12:33:23] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[12:33:23] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[12:33:23] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[12:33:23] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[12:33:23] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[12:33:23] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[12:33:23] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[12:33:23] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[12:33:23] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[12:33:23] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[12:33:23] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[12:33:23] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[12:33:23] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[12:33:23] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[12:33:23] ============= [PASSED] drm_test_rect_intersect =============
[12:33:23] ================ drm_test_rect_calc_hscale ================
[12:33:23] [PASSED] normal use
[12:33:23] [PASSED] out of max range
[12:33:23] [PASSED] out of min range
[12:33:23] [PASSED] zero dst
[12:33:23] [PASSED] negative src
[12:33:23] [PASSED] negative dst
[12:33:23] ============ [PASSED] drm_test_rect_calc_hscale ============
[12:33:23] ================ drm_test_rect_calc_vscale ================
[12:33:23] [PASSED] normal use
[12:33:23] [PASSED] out of max range
[12:33:23] [PASSED] out of min range
[12:33:23] [PASSED] zero dst
[12:33:23] [PASSED] negative src
[12:33:23] [PASSED] negative dst
[12:33:23] ============ [PASSED] drm_test_rect_calc_vscale ============
[12:33:23] ================== drm_test_rect_rotate ===================
[12:33:23] [PASSED] reflect-x
[12:33:23] [PASSED] reflect-y
[12:33:23] [PASSED] rotate-0
[12:33:23] [PASSED] rotate-90
[12:33:23] [PASSED] rotate-180
[12:33:23] [PASSED] rotate-270
[12:33:23] ============== [PASSED] drm_test_rect_rotate ===============
[12:33:23] ================ drm_test_rect_rotate_inv =================
[12:33:23] [PASSED] reflect-x
[12:33:23] [PASSED] reflect-y
[12:33:23] [PASSED] rotate-0
[12:33:23] [PASSED] rotate-90
[12:33:23] [PASSED] rotate-180
[12:33:23] [PASSED] rotate-270
[12:33:23] ============ [PASSED] drm_test_rect_rotate_inv =============
[12:33:23] ==================== [PASSED] drm_rect =====================
[12:33:23] ============ drm_sysfb_modeset_test (1 subtest) ============
[12:33:23] ============ drm_test_sysfb_build_fourcc_list =============
[12:33:23] [PASSED] no native formats
[12:33:23] [PASSED] XRGB8888 as native format
[12:33:23] [PASSED] remove duplicates
[12:33:23] [PASSED] convert alpha formats
[12:33:23] [PASSED] random formats
[12:33:23] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[12:33:23] ============= [PASSED] drm_sysfb_modeset_test ==============
[12:33:23] ================== drm_fixp (2 subtests) ===================
[12:33:23] [PASSED] drm_test_int2fixp
[12:33:23] [PASSED] drm_test_sm2fixp
[12:33:23] ==================== [PASSED] drm_fixp =====================
[12:33:23] ============================================================
[12:33:23] Testing complete. Ran 637 tests: passed: 637
[12:33:23] Elapsed time: 27.115s total, 1.817s configuring, 25.127s building, 0.152s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[12:33:23] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[12:33:25] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[12:33:35] Starting KUnit Kernel (1/1)...
[12:33:35] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[12:33:35] ================= ttm_device (5 subtests) ==================
[12:33:35] [PASSED] ttm_device_init_basic
[12:33:35] [PASSED] ttm_device_init_multiple
[12:33:35] [PASSED] ttm_device_fini_basic
[12:33:35] [PASSED] ttm_device_init_no_vma_man
[12:33:35] ================== ttm_device_init_pools ==================
[12:33:35] [PASSED] No DMA allocations, no DMA32 required
[12:33:35] [PASSED] DMA allocations, DMA32 required
[12:33:35] [PASSED] No DMA allocations, DMA32 required
[12:33:35] [PASSED] DMA allocations, no DMA32 required
[12:33:35] ============== [PASSED] ttm_device_init_pools ==============
[12:33:35] =================== [PASSED] ttm_device ====================
[12:33:35] ================== ttm_pool (8 subtests) ===================
[12:33:35] ================== ttm_pool_alloc_basic ===================
[12:33:35] [PASSED] One page
[12:33:35] [PASSED] More than one page
[12:33:35] [PASSED] Above the allocation limit
[12:33:35] [PASSED] One page, with coherent DMA mappings enabled
[12:33:35] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:33:35] ============== [PASSED] ttm_pool_alloc_basic ===============
[12:33:35] ============== ttm_pool_alloc_basic_dma_addr ==============
[12:33:35] [PASSED] One page
[12:33:35] [PASSED] More than one page
[12:33:35] [PASSED] Above the allocation limit
[12:33:35] [PASSED] One page, with coherent DMA mappings enabled
[12:33:35] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[12:33:35] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[12:33:35] [PASSED] ttm_pool_alloc_order_caching_match
[12:33:35] [PASSED] ttm_pool_alloc_caching_mismatch
[12:33:35] [PASSED] ttm_pool_alloc_order_mismatch
[12:33:35] [PASSED] ttm_pool_free_dma_alloc
[12:33:35] [PASSED] ttm_pool_free_no_dma_alloc
[12:33:35] [PASSED] ttm_pool_fini_basic
[12:33:35] ==================== [PASSED] ttm_pool =====================
[12:33:35] ================ ttm_resource (8 subtests) =================
[12:33:35] ================= ttm_resource_init_basic =================
[12:33:35] [PASSED] Init resource in TTM_PL_SYSTEM
[12:33:35] [PASSED] Init resource in TTM_PL_VRAM
[12:33:35] [PASSED] Init resource in a private placement
[12:33:35] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[12:33:35] ============= [PASSED] ttm_resource_init_basic =============
[12:33:35] [PASSED] ttm_resource_init_pinned
[12:33:35] [PASSED] ttm_resource_fini_basic
[12:33:35] [PASSED] ttm_resource_manager_init_basic
[12:33:35] [PASSED] ttm_resource_manager_usage_basic
[12:33:35] [PASSED] ttm_resource_manager_set_used_basic
[12:33:35] [PASSED] ttm_sys_man_alloc_basic
[12:33:35] [PASSED] ttm_sys_man_free_basic
[12:33:35] ================== [PASSED] ttm_resource ===================
[12:33:35] =================== ttm_tt (15 subtests) ===================
[12:33:35] ==================== ttm_tt_init_basic ====================
[12:33:35] [PASSED] Page-aligned size
[12:33:35] [PASSED] Extra pages requested
[12:33:35] ================ [PASSED] ttm_tt_init_basic ================
[12:33:35] [PASSED] ttm_tt_init_misaligned
[12:33:35] [PASSED] ttm_tt_fini_basic
[12:33:35] [PASSED] ttm_tt_fini_sg
[12:33:35] [PASSED] ttm_tt_fini_shmem
[12:33:35] [PASSED] ttm_tt_create_basic
[12:33:35] [PASSED] ttm_tt_create_invalid_bo_type
[12:33:35] [PASSED] ttm_tt_create_ttm_exists
[12:33:35] [PASSED] ttm_tt_create_failed
[12:33:35] [PASSED] ttm_tt_destroy_basic
[12:33:35] [PASSED] ttm_tt_populate_null_ttm
[12:33:35] [PASSED] ttm_tt_populate_populated_ttm
[12:33:35] [PASSED] ttm_tt_unpopulate_basic
[12:33:35] [PASSED] ttm_tt_unpopulate_empty_ttm
[12:33:35] [PASSED] ttm_tt_swapin_basic
[12:33:35] ===================== [PASSED] ttm_tt ======================
[12:33:35] =================== ttm_bo (14 subtests) ===================
[12:33:35] =========== ttm_bo_reserve_optimistic_no_ticket ===========
[12:33:35] [PASSED] Cannot be interrupted and sleeps
[12:33:35] [PASSED] Cannot be interrupted, locks straight away
[12:33:35] [PASSED] Can be interrupted, sleeps
[12:33:35] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[12:33:35] [PASSED] ttm_bo_reserve_locked_no_sleep
[12:33:35] [PASSED] ttm_bo_reserve_no_wait_ticket
[12:33:35] [PASSED] ttm_bo_reserve_double_resv
[12:33:35] [PASSED] ttm_bo_reserve_interrupted
[12:33:35] [PASSED] ttm_bo_reserve_deadlock
[12:33:35] [PASSED] ttm_bo_unreserve_basic
[12:33:35] [PASSED] ttm_bo_unreserve_pinned
[12:33:35] [PASSED] ttm_bo_unreserve_bulk
[12:33:35] [PASSED] ttm_bo_fini_basic
[12:33:35] [PASSED] ttm_bo_fini_shared_resv
[12:33:35] [PASSED] ttm_bo_pin_basic
[12:33:35] [PASSED] ttm_bo_pin_unpin_resource
[12:33:35] [PASSED] ttm_bo_multiple_pin_one_unpin
[12:33:35] ===================== [PASSED] ttm_bo ======================
[12:33:35] ============== ttm_bo_validate (22 subtests) ===============
[12:33:35] ============== ttm_bo_init_reserved_sys_man ===============
[12:33:35] [PASSED] Buffer object for userspace
[12:33:35] [PASSED] Kernel buffer object
[12:33:35] [PASSED] Shared buffer object
[12:33:35] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[12:33:35] ============== ttm_bo_init_reserved_mock_man ==============
[12:33:35] [PASSED] Buffer object for userspace
[12:33:35] [PASSED] Kernel buffer object
[12:33:35] [PASSED] Shared buffer object
[12:33:35] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[12:33:35] [PASSED] ttm_bo_init_reserved_resv
[12:33:35] ================== ttm_bo_validate_basic ==================
[12:33:35] [PASSED] Buffer object for userspace
[12:33:35] [PASSED] Kernel buffer object
[12:33:35] [PASSED] Shared buffer object
[12:33:35] ============== [PASSED] ttm_bo_validate_basic ==============
[12:33:35] [PASSED] ttm_bo_validate_invalid_placement
[12:33:35] ============= ttm_bo_validate_same_placement ==============
[12:33:35] [PASSED] System manager
[12:33:35] [PASSED] VRAM manager
[12:33:35] ========= [PASSED] ttm_bo_validate_same_placement ==========
[12:33:35] [PASSED] ttm_bo_validate_failed_alloc
[12:33:35] [PASSED] ttm_bo_validate_pinned
[12:33:35] [PASSED] ttm_bo_validate_busy_placement
[12:33:35] ================ ttm_bo_validate_multihop =================
[12:33:35] [PASSED] Buffer object for userspace
[12:33:35] [PASSED] Kernel buffer object
[12:33:35] [PASSED] Shared buffer object
[12:33:35] ============ [PASSED] ttm_bo_validate_multihop =============
[12:33:35] ========== ttm_bo_validate_no_placement_signaled ==========
[12:33:35] [PASSED] Buffer object in system domain, no page vector
[12:33:35] [PASSED] Buffer object in system domain with an existing page vector
[12:33:35] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[12:33:35] ======== ttm_bo_validate_no_placement_not_signaled ========
[12:33:35] [PASSED] Buffer object for userspace
[12:33:35] [PASSED] Kernel buffer object
[12:33:35] [PASSED] Shared buffer object
[12:33:35] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[12:33:35] [PASSED] ttm_bo_validate_move_fence_signaled
[12:33:35] ========= ttm_bo_validate_move_fence_not_signaled =========
[12:33:35] [PASSED] Waits for GPU
[12:33:35] [PASSED] Tries to lock straight away
[12:33:35] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[12:33:35] [PASSED] ttm_bo_validate_swapout
[12:33:35] [PASSED] ttm_bo_validate_happy_evict
[12:33:35] [PASSED] ttm_bo_validate_all_pinned_evict
[12:33:35] [PASSED] ttm_bo_validate_allowed_only_evict
[12:33:35] [PASSED] ttm_bo_validate_deleted_evict
[12:33:35] [PASSED] ttm_bo_validate_busy_domain_evict
[12:33:35] [PASSED] ttm_bo_validate_evict_gutting
[12:33:35] [PASSED] ttm_bo_validate_recrusive_evict
[12:33:35] ================= [PASSED] ttm_bo_validate =================
[12:33:35] ============================================================
[12:33:35] Testing complete. Ran 102 tests: passed: 102
[12:33:35] Elapsed time: 11.969s total, 1.712s configuring, 9.993s building, 0.224s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Xe.CI.BAT: success for drm/gem: Move pages_to_sg helper into drm_gem.c
2026-07-24 12:08 ` Adrián Larumbe
(?)
(?)
@ 2026-07-24 13:08 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2026-07-24 13:08 UTC (permalink / raw)
To: Adrián Larumbe; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
== Series Details ==
Series: drm/gem: Move pages_to_sg helper into drm_gem.c
URL : https://patchwork.freedesktop.org/series/171076/
State : success
== Summary ==
CI Bug Log - changes from xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55_BAT -> xe-pw-171076v1_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* Linux: xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55 -> xe-pw-171076v1
IGT_9025: 852c13ddd448fd668c43584ca3ad1aec49c4633c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55: b747a63003130bef1a3d5d6ba97c94d0cee36f55
xe-pw-171076v1: 171076v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/index.html
[-- Attachment #2: Type: text/html, Size: 1509 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c
2026-07-24 12:08 ` Adrián Larumbe
@ 2026-07-24 14:53 ` Thomas Zimmermann
-1 siblings, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2026-07-24 14:53 UTC (permalink / raw)
To: Adrián Larumbe, Alex Deucher, Christian König,
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Lucas Stach, Russell King, Christian Gmeiner, Jianmin Lv,
Qianhai Wu, Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng,
Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Lyude Paul, Danilo Krummrich,
Boris Brezillon, Steven Price, Liviu Dudau, Sandy Huang,
Heiko Stübner, Andy Yan, Thierry Reding, Mikko Perttunen,
Jonathan Hunter, Zack Rusin, Broadcom internal kernel review list,
Matthew Brost, Thomas Hellström, Rodrigo Vivi,
Oleksandr Andrushchenko, Sumit Semwal
Cc: amd-gfx, dri-devel, linux-kernel, etnaviv, linux-arm-msm,
freedreno, nouveau, linux-rockchip, linux-arm-kernel, linux-tegra,
intel-xe, xen-devel, linux-media, linaro-mm-sig
Hi
Am 24.07.26 um 14:08 schrieb Adrián Larumbe:
> None of the semantics of the function tell of it being a PRIME-exclusive
> entry point. In fact, most drivers seem to be using it to translate a list
> of pages into an sg table that can be used for GPU mapping later on, rather
> than just for sharing an object's pages with another driver.
>
> Move it across files and rename accordingly.
Makes sense to me. But the helper has no hard dependency on anything in
DRM. I wonder if it shouldn't be a helper in the dma or
memory-management subsystem.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
In any case:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Best regards
Thomas
> ---
> drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces.
> It is a generic helper that converts a page array into a scatter/gather
> table via dma_map_sg_attrs. Nothing in its implementation touches struct
> dma_buf or import/export logic.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++---
> drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> drivers/gpu/drm/drm_prime.c | 38 -----------------------------
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +--
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++-
> drivers/gpu/drm/loongson/lsdc_gem.c | 3 +--
> drivers/gpu/drm/msm/msm_gem.c | 2 +-
> drivers/gpu/drm/msm/msm_gem_prime.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +--
> drivers/gpu/drm/panthor/panthor_gem.c | 6 ++---
> drivers/gpu/drm/radeon/radeon_prime.c | 5 ++--
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++---
> drivers/gpu/drm/tegra/gem.c | 4 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +--
> drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++---
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
> include/drm/drm_gem.h | 5 +++-
> include/drm/drm_prime.h | 2 --
> 19 files changed, 68 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index b33c300e26e2..c9a98aec7eb6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->tbo.resource->mem_type) {
> case TTM_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 018df97d590d..22c8a3b5f667 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> }
> EXPORT_SYMBOL(drm_gem_put_pages);
>
> +/**
> + * drm_pages_to_sg - converts a page array into an sg list
> + * @dev: DRM device
> + * @pages: pointer to the array of page pointers to convert
> + * @nr_pages: length of the page vector
> + *
> + * This helper creates an sg table object from a set of pages.
> + * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> + */
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages)
> +{
> + struct sg_table *sg;
> + size_t max_segment = 0;
> + int err;
> +
> + sg = kmalloc_obj(struct sg_table);
> + if (!sg)
> + return ERR_PTR(-ENOMEM);
> +
> + if (dev)
> + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> + if (max_segment == 0)
> + max_segment = UINT_MAX;
> + err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> + (unsigned long)nr_pages << PAGE_SHIFT,
> + max_segment, GFP_KERNEL);
> + if (err) {
> + kfree(sg);
> + sg = ERR_PTR(err);
> + }
> + return sg;
> +}
> +EXPORT_SYMBOL(drm_pages_to_sg);
> +
> static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
> struct drm_gem_object **objs)
> {
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 22ec52e2ffb8..144d088a477f 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem)
>
> drm_WARN_ON(obj->dev, drm_gem_is_imported(obj));
>
> - return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> }
> EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table);
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 9b44c78cd77f..54539a8929c1 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> .vunmap = drm_gem_dmabuf_vunmap,
> };
>
> -/**
> - * drm_prime_pages_to_sg - converts a page array into an sg list
> - * @dev: DRM device
> - * @pages: pointer to the array of page pointers to convert
> - * @nr_pages: length of the page vector
> - *
> - * This helper creates an sg table object from a set of pages
> - * the driver is responsible for mapping the pages into the
> - * importers address space for use with dma_buf itself.
> - *
> - * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> - */
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages)
> -{
> - struct sg_table *sg;
> - size_t max_segment = 0;
> - int err;
> -
> - sg = kmalloc_obj(struct sg_table);
> - if (!sg)
> - return ERR_PTR(-ENOMEM);
> -
> - if (dev)
> - max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> - if (max_segment == 0)
> - max_segment = UINT_MAX;
> - err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> - (unsigned long)nr_pages << PAGE_SHIFT,
> - max_segment, GFP_KERNEL);
> - if (err) {
> - kfree(sg);
> - sg = ERR_PTR(err);
> - }
> - return sg;
> -}
> -EXPORT_SYMBOL(drm_prime_pages_to_sg);
> -
> /**
> * drm_prime_get_contiguous_size - returns the contiguous size of the buffer
> * @sgt: sg_table describing the buffer to check
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index b0436a1e103f..a8e8614f8210 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2015-2018 Etnaviv Project
> */
>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
> #include <linux/dma-mapping.h>
> #include <linux/shmem_fs.h>
> @@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
> unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> struct sg_table *sgt;
>
> - sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
> + sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages);
> if (IS_ERR(sgt)) {
> dev_err(dev->dev, "failed to allocate sgt: %ld\n",
> PTR_ERR(sgt));
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 6757ae6ec304..f44484325ddb 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2014-2018 Etnaviv Project
> */
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <linux/dma-buf.h>
> #include <linux/module.h>
> @@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-EINVAL);
>
> - return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> }
>
> int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c
> index 2fb03487c983..37160228244c 100644
> --- a/drivers/gpu/drm/loongson/lsdc_gem.c
> +++ b/drivers/gpu/drm/loongson/lsdc_gem.c
> @@ -9,7 +9,6 @@
> #include <drm/drm_dumb_buffers.h>
> #include <drm/drm_file.h>
> #include <drm/drm_gem.h>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
>
> #include "lsdc_drv.h"
> @@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj)
> return ERR_PTR(-ENOMEM);
> }
>
> - return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> + return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> }
>
> static void lsdc_gem_object_free(struct drm_gem_object *obj)
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index efd3d3c9a449..7e3418290c22 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
>
> msm_obj->pages = p;
>
> - msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages);
> + msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages);
> if (IS_ERR(msm_obj->sgt)) {
> void *ptr = ERR_CAST(msm_obj->sgt);
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
> index 036d34c674d9..d25393a9e549 100644
> --- a/drivers/gpu/drm/msm/msm_gem_prime.c
> +++ b/drivers/gpu/drm/msm/msm_gem_prime.c
> @@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, msm_obj->pages, npages);
> }
>
> int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
> index caab60fc62f6..b95f2f07df74 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_prime.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
> @@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct nouveau_bo *nvbo = nouveau_gem_object(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> - nvbo->bo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> + nvbo->bo.ttm->num_pages);
> }
>
> struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index 9855df738194..ec530d254fa4 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo)
> if (ret)
> return ERR_PTR(ret);
>
> - sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
> - bo->base.size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages,
> + bo->base.size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> @@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj)
> drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages);
> drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count));
>
> - return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> }
>
> static int panthor_gem_vmap_locked(struct drm_gem_object *obj,
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index a77881f035e7..4cfc4282a59c 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -26,6 +26,7 @@
>
> #include <linux/dma-buf.h>
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <drm/radeon_drm.h>
>
> @@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct radeon_bo *bo = gem_to_radeon_bo(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> }
>
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index b188539dca0b..7897da0becf4 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj)
>
> rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT;
>
> - rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev,
> - rk_obj->pages, rk_obj->num_pages);
> + rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev,
> + rk_obj->pages, rk_obj->num_pages);
> if (IS_ERR(rk_obj->sgt)) {
> ret = PTR_ERR(rk_obj->sgt);
> goto err_put_pages;
> @@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj)
> int ret;
>
> if (rk_obj->pages)
> - return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
> + return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
>
> sgt = kzalloc_obj(*sgt);
> if (!sgt)
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index 436394e04812..701af672b4e5 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -17,7 +17,7 @@
>
> #include <drm/drm_drv.h>
> #include <drm/drm_dumb_buffers.h>
> -#include <drm/drm_prime.h>
> +#include <drm/drm_gem.h>
>
> #include "drm.h"
> #include "gem.h"
> @@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo)
>
> bo->num_pages = bo->gem.size >> PAGE_SHIFT;
>
> - bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> + bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> if (IS_ERR(bo->sgt)) {
> err = PTR_ERR(bo->sgt);
> goto put_pages;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> index 39f8c46550c2..c9e7f2e3668c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> @@ -28,7 +28,7 @@
> #include "vmwgfx_bo.h"
> #include "vmwgfx_drv.h"
>
> -#include "drm/drm_prime.h"
> +#include "drm/drm_gem.h"
> #include "drm/drm_gem_ttm_helper.h"
>
> #include <linux/debugfs.h>
> @@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj)
> if (vmw_tt->vsgt.sgt)
> return vmw_tt->vsgt.sgt;
>
> - return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> + return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> }
>
> static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
> index 8a920e58245c..f0fe80706b79 100644
> --- a/drivers/gpu/drm/xe/xe_dma_buf.c
> +++ b/drivers/gpu/drm/xe/xe_dma_buf.c
> @@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->ttm.resource->mem_type) {
> case XE_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->ttm.ttm->pages,
> - obj->size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->ttm.ttm->pages,
> + obj->size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index eec4c1da3f9e..a4a7c7f2c91c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
> if (!xen_obj->pages)
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(gem_obj->dev,
> + return drm_pages_to_sg(gem_obj->dev,
> xen_obj->pages, xen_obj->num_pages);
> }
>
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index 885244e375d3..7b9cc6335689 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -155,7 +155,7 @@ struct drm_gem_object_funcs {
> * here cannot be used for sg tables pointing at driver private memory
> * ranges.
> *
> - * See also drm_prime_pages_to_sg().
> + * See also drm_pages_to_sg().
> */
> struct sg_table *(*get_sg_table)(struct drm_gem_object *obj);
>
> @@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj);
> void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> bool dirty, bool accessed);
>
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages);
> +
> void drm_gem_lock(struct drm_gem_object *obj);
> void drm_gem_unlock(struct drm_gem_object *obj);
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index f50f862f0d8b..603e16a40ae7 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map);
> int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
> int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages);
> struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj,
> int flags);
>
>
> ---
> base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d
> change-id: 20260724-get_pages-e2e91c53eaa3
>
> Best regards,
> --
> Adrián Larumbe <adrian.larumbe@collabora.com>
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c
@ 2026-07-24 14:53 ` Thomas Zimmermann
0 siblings, 0 replies; 10+ messages in thread
From: Thomas Zimmermann @ 2026-07-24 14:53 UTC (permalink / raw)
To: Adrián Larumbe, Alex Deucher, Christian König,
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Lucas Stach, Russell King, Christian Gmeiner, Jianmin Lv,
Qianhai Wu, Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng,
Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Lyude Paul, Danilo Krummrich,
Boris Brezillon, Steven Price, Liviu Dudau, Sandy Huang,
Heiko Stübner, Andy Yan, Thierry Reding, Mikko Perttunen,
Jonathan Hunter, Zack Rusin, Broadcom internal kernel review list,
Matthew Brost, Thomas Hellström, Rodrigo Vivi,
Oleksandr Andrushchenko, Sumit Semwal
Cc: amd-gfx, dri-devel, linux-kernel, etnaviv, linux-arm-msm,
freedreno, nouveau, linux-rockchip, linux-arm-kernel, linux-tegra,
intel-xe, xen-devel, linux-media, linaro-mm-sig
Hi
Am 24.07.26 um 14:08 schrieb Adrián Larumbe:
> None of the semantics of the function tell of it being a PRIME-exclusive
> entry point. In fact, most drivers seem to be using it to translate a list
> of pages into an sg table that can be used for GPU mapping later on, rather
> than just for sharing an object's pages with another driver.
>
> Move it across files and rename accordingly.
Makes sense to me. But the helper has no hard dependency on anything in
DRM. I wonder if it shouldn't be a helper in the dma or
memory-management subsystem.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
In any case:
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Best regards
Thomas
> ---
> drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces.
> It is a generic helper that converts a page array into a scatter/gather
> table via dma_map_sg_attrs. Nothing in its implementation touches struct
> dma_buf or import/export logic.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++---
> drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> drivers/gpu/drm/drm_prime.c | 38 -----------------------------
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +--
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++-
> drivers/gpu/drm/loongson/lsdc_gem.c | 3 +--
> drivers/gpu/drm/msm/msm_gem.c | 2 +-
> drivers/gpu/drm/msm/msm_gem_prime.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +--
> drivers/gpu/drm/panthor/panthor_gem.c | 6 ++---
> drivers/gpu/drm/radeon/radeon_prime.c | 5 ++--
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++---
> drivers/gpu/drm/tegra/gem.c | 4 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +--
> drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++---
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
> include/drm/drm_gem.h | 5 +++-
> include/drm/drm_prime.h | 2 --
> 19 files changed, 68 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index b33c300e26e2..c9a98aec7eb6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->tbo.resource->mem_type) {
> case TTM_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 018df97d590d..22c8a3b5f667 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> }
> EXPORT_SYMBOL(drm_gem_put_pages);
>
> +/**
> + * drm_pages_to_sg - converts a page array into an sg list
> + * @dev: DRM device
> + * @pages: pointer to the array of page pointers to convert
> + * @nr_pages: length of the page vector
> + *
> + * This helper creates an sg table object from a set of pages.
> + * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> + */
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages)
> +{
> + struct sg_table *sg;
> + size_t max_segment = 0;
> + int err;
> +
> + sg = kmalloc_obj(struct sg_table);
> + if (!sg)
> + return ERR_PTR(-ENOMEM);
> +
> + if (dev)
> + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> + if (max_segment == 0)
> + max_segment = UINT_MAX;
> + err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> + (unsigned long)nr_pages << PAGE_SHIFT,
> + max_segment, GFP_KERNEL);
> + if (err) {
> + kfree(sg);
> + sg = ERR_PTR(err);
> + }
> + return sg;
> +}
> +EXPORT_SYMBOL(drm_pages_to_sg);
> +
> static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
> struct drm_gem_object **objs)
> {
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 22ec52e2ffb8..144d088a477f 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem)
>
> drm_WARN_ON(obj->dev, drm_gem_is_imported(obj));
>
> - return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> }
> EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table);
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 9b44c78cd77f..54539a8929c1 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> .vunmap = drm_gem_dmabuf_vunmap,
> };
>
> -/**
> - * drm_prime_pages_to_sg - converts a page array into an sg list
> - * @dev: DRM device
> - * @pages: pointer to the array of page pointers to convert
> - * @nr_pages: length of the page vector
> - *
> - * This helper creates an sg table object from a set of pages
> - * the driver is responsible for mapping the pages into the
> - * importers address space for use with dma_buf itself.
> - *
> - * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> - */
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages)
> -{
> - struct sg_table *sg;
> - size_t max_segment = 0;
> - int err;
> -
> - sg = kmalloc_obj(struct sg_table);
> - if (!sg)
> - return ERR_PTR(-ENOMEM);
> -
> - if (dev)
> - max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> - if (max_segment == 0)
> - max_segment = UINT_MAX;
> - err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> - (unsigned long)nr_pages << PAGE_SHIFT,
> - max_segment, GFP_KERNEL);
> - if (err) {
> - kfree(sg);
> - sg = ERR_PTR(err);
> - }
> - return sg;
> -}
> -EXPORT_SYMBOL(drm_prime_pages_to_sg);
> -
> /**
> * drm_prime_get_contiguous_size - returns the contiguous size of the buffer
> * @sgt: sg_table describing the buffer to check
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index b0436a1e103f..a8e8614f8210 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2015-2018 Etnaviv Project
> */
>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
> #include <linux/dma-mapping.h>
> #include <linux/shmem_fs.h>
> @@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
> unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> struct sg_table *sgt;
>
> - sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
> + sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages);
> if (IS_ERR(sgt)) {
> dev_err(dev->dev, "failed to allocate sgt: %ld\n",
> PTR_ERR(sgt));
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 6757ae6ec304..f44484325ddb 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2014-2018 Etnaviv Project
> */
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <linux/dma-buf.h>
> #include <linux/module.h>
> @@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-EINVAL);
>
> - return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> }
>
> int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c
> index 2fb03487c983..37160228244c 100644
> --- a/drivers/gpu/drm/loongson/lsdc_gem.c
> +++ b/drivers/gpu/drm/loongson/lsdc_gem.c
> @@ -9,7 +9,6 @@
> #include <drm/drm_dumb_buffers.h>
> #include <drm/drm_file.h>
> #include <drm/drm_gem.h>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
>
> #include "lsdc_drv.h"
> @@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj)
> return ERR_PTR(-ENOMEM);
> }
>
> - return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> + return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> }
>
> static void lsdc_gem_object_free(struct drm_gem_object *obj)
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index efd3d3c9a449..7e3418290c22 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
>
> msm_obj->pages = p;
>
> - msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages);
> + msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages);
> if (IS_ERR(msm_obj->sgt)) {
> void *ptr = ERR_CAST(msm_obj->sgt);
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
> index 036d34c674d9..d25393a9e549 100644
> --- a/drivers/gpu/drm/msm/msm_gem_prime.c
> +++ b/drivers/gpu/drm/msm/msm_gem_prime.c
> @@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, msm_obj->pages, npages);
> }
>
> int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
> index caab60fc62f6..b95f2f07df74 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_prime.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
> @@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct nouveau_bo *nvbo = nouveau_gem_object(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> - nvbo->bo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> + nvbo->bo.ttm->num_pages);
> }
>
> struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index 9855df738194..ec530d254fa4 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo)
> if (ret)
> return ERR_PTR(ret);
>
> - sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
> - bo->base.size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages,
> + bo->base.size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> @@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj)
> drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages);
> drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count));
>
> - return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> }
>
> static int panthor_gem_vmap_locked(struct drm_gem_object *obj,
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index a77881f035e7..4cfc4282a59c 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -26,6 +26,7 @@
>
> #include <linux/dma-buf.h>
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <drm/radeon_drm.h>
>
> @@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct radeon_bo *bo = gem_to_radeon_bo(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> }
>
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index b188539dca0b..7897da0becf4 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj)
>
> rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT;
>
> - rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev,
> - rk_obj->pages, rk_obj->num_pages);
> + rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev,
> + rk_obj->pages, rk_obj->num_pages);
> if (IS_ERR(rk_obj->sgt)) {
> ret = PTR_ERR(rk_obj->sgt);
> goto err_put_pages;
> @@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj)
> int ret;
>
> if (rk_obj->pages)
> - return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
> + return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
>
> sgt = kzalloc_obj(*sgt);
> if (!sgt)
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index 436394e04812..701af672b4e5 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -17,7 +17,7 @@
>
> #include <drm/drm_drv.h>
> #include <drm/drm_dumb_buffers.h>
> -#include <drm/drm_prime.h>
> +#include <drm/drm_gem.h>
>
> #include "drm.h"
> #include "gem.h"
> @@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo)
>
> bo->num_pages = bo->gem.size >> PAGE_SHIFT;
>
> - bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> + bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> if (IS_ERR(bo->sgt)) {
> err = PTR_ERR(bo->sgt);
> goto put_pages;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> index 39f8c46550c2..c9e7f2e3668c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> @@ -28,7 +28,7 @@
> #include "vmwgfx_bo.h"
> #include "vmwgfx_drv.h"
>
> -#include "drm/drm_prime.h"
> +#include "drm/drm_gem.h"
> #include "drm/drm_gem_ttm_helper.h"
>
> #include <linux/debugfs.h>
> @@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj)
> if (vmw_tt->vsgt.sgt)
> return vmw_tt->vsgt.sgt;
>
> - return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> + return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> }
>
> static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
> index 8a920e58245c..f0fe80706b79 100644
> --- a/drivers/gpu/drm/xe/xe_dma_buf.c
> +++ b/drivers/gpu/drm/xe/xe_dma_buf.c
> @@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->ttm.resource->mem_type) {
> case XE_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->ttm.ttm->pages,
> - obj->size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->ttm.ttm->pages,
> + obj->size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index eec4c1da3f9e..a4a7c7f2c91c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
> if (!xen_obj->pages)
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(gem_obj->dev,
> + return drm_pages_to_sg(gem_obj->dev,
> xen_obj->pages, xen_obj->num_pages);
> }
>
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index 885244e375d3..7b9cc6335689 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -155,7 +155,7 @@ struct drm_gem_object_funcs {
> * here cannot be used for sg tables pointing at driver private memory
> * ranges.
> *
> - * See also drm_prime_pages_to_sg().
> + * See also drm_pages_to_sg().
> */
> struct sg_table *(*get_sg_table)(struct drm_gem_object *obj);
>
> @@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj);
> void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> bool dirty, bool accessed);
>
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages);
> +
> void drm_gem_lock(struct drm_gem_object *obj);
> void drm_gem_unlock(struct drm_gem_object *obj);
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index f50f862f0d8b..603e16a40ae7 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map);
> int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
> int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages);
> struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj,
> int flags);
>
>
> ---
> base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d
> change-id: 20260724-get_pages-e2e91c53eaa3
>
> Best regards,
> --
> Adrián Larumbe <adrian.larumbe@collabora.com>
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Xe.CI.FULL: success for drm/gem: Move pages_to_sg helper into drm_gem.c
2026-07-24 12:08 ` Adrián Larumbe
` (3 preceding siblings ...)
(?)
@ 2026-07-25 7:17 ` Patchwork
-1 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2026-07-25 7:17 UTC (permalink / raw)
To: Adrián Larumbe; +Cc: intel-xe
[-- Attachment #1: Type: text/plain, Size: 26360 bytes --]
== Series Details ==
Series: drm/gem: Move pages_to_sg helper into drm_gem.c
URL : https://patchwork.freedesktop.org/series/171076/
State : success
== Summary ==
CI Bug Log - changes from xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55_FULL -> xe-pw-171076v1_FULL
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (2 -> 2)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-171076v1_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-bmg: NOTRUN -> [SKIP][1] ([Intel XE#2233])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-bmg: NOTRUN -> [SKIP][2] ([Intel XE#1124]) +3 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-mc-ccs:
- shard-bmg: NOTRUN -> [SKIP][3] ([Intel XE#2887]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_ccs@crc-primary-basic-4-tiled-mtl-mc-ccs.html
* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs@pipe-d-hdmi-a-3:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2652]) +8 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-lnl-ccs@pipe-d-hdmi-a-3.html
* igt@kms_chamelium_color@ctm-0-25:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#2325] / [Intel XE#7358])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_chamelium_color@ctm-0-25.html
* igt@kms_chamelium_hpd@dp-hpd-after-suspend:
- shard-bmg: NOTRUN -> [SKIP][6] ([Intel XE#2252]) +1 other test skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_chamelium_hpd@dp-hpd-after-suspend.html
* igt@kms_content_protection@lic-type-1:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#7642])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_content_protection@lic-type-1.html
* igt@kms_cursor_crc@cursor-sliding-256x85:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#2320]) +1 other test skip
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_cursor_crc@cursor-sliding-256x85.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions:
- shard-bmg: NOTRUN -> [SKIP][9] ([Intel XE#2286] / [Intel XE#6035])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_cursor_legacy@short-busy-flip-before-cursor-atomic-transitions.html
* igt@kms_dsc@dsc-with-bpc-formats-bigjoiner:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#8265]) +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_dsc@dsc-with-bpc-formats-bigjoiner.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp2:
- shard-bmg: [PASS][11] -> [FAIL][12] ([Intel XE#3098]) +3 other tests fail
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-8/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp2.html
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-1/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-dp2.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-bmg: NOTRUN -> [SKIP][13] ([Intel XE#7178] / [Intel XE#7351])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@drrshdr-2p-scndscrn-cur-indfb-onoff:
- shard-bmg: NOTRUN -> [SKIP][14] ([Intel XE#2311]) +14 other tests skip
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_frontbuffer_tracking@drrshdr-2p-scndscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#4141]) +2 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsrhdr-abgr161616f-draw-render:
- shard-bmg: NOTRUN -> [SKIP][16] ([Intel XE#7061])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_frontbuffer_tracking@fbcpsrhdr-abgr161616f-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][17] ([Intel XE#2313]) +7 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-argb161616f-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#7061] / [Intel XE#7356]) +1 other test skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_frontbuffer_tracking@psr-argb161616f-draw-mmap-wc.html
* igt@kms_panel_fitting@atomic-fastset:
- shard-bmg: NOTRUN -> [SKIP][19] ([Intel XE#2486])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_panel_fitting@atomic-fastset.html
* igt@kms_plane@pixel-format-4-tiled-dg2-rc-ccs-cc-modifier:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#7283])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_plane@pixel-format-4-tiled-dg2-rc-ccs-cc-modifier.html
* igt@kms_plane@planar-pixel-format-settings@nv12-tile4-src-y:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#8076])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_plane@planar-pixel-format-settings@nv12-tile4-src-y.html
* igt@kms_pm_backlight@basic-brightness:
- shard-bmg: NOTRUN -> [SKIP][22] ([Intel XE#7376] / [Intel XE#7760] / [Intel XE#870])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_pm_backlight@basic-brightness.html
* igt@kms_psr2_sf@pr-overlay-plane-move-continuous-sf:
- shard-bmg: NOTRUN -> [SKIP][23] ([Intel XE#1489]) +1 other test skip
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_psr2_sf@pr-overlay-plane-move-continuous-sf.html
* igt@kms_psr@psr-primary-page-flip:
- shard-bmg: NOTRUN -> [SKIP][24] ([Intel XE#2234] / [Intel XE#2850]) +4 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_psr@psr-primary-page-flip.html
* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#3904] / [Intel XE#7342])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_rotation_crc@sprite-rotation-90-pos-100-0.html
* igt@kms_sharpness_filter@invalid-plane-with-filter:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#6503])
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_sharpness_filter@invalid-plane-with-filter.html
* igt@kms_vrr@lobf:
- shard-bmg: NOTRUN -> [SKIP][27] ([Intel XE#2168] / [Intel XE#7444])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_vrr@lobf.html
* igt@xe_evict@evict-mixed-many-threads-small:
- shard-bmg: [PASS][28] -> [INCOMPLETE][29] ([Intel XE#6321] / [Intel XE#8355])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-5/igt@xe_evict@evict-mixed-many-threads-small.html
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-9/igt@xe_evict@evict-mixed-many-threads-small.html
* igt@xe_exec_basic@multigpu-no-exec-null:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#2322] / [Intel XE#7372])
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_exec_basic@multigpu-no-exec-null.html
* igt@xe_exec_fault_mode@twice-multi-queue-userptr-invalidate:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#8374]) +1 other test skip
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_exec_fault_mode@twice-multi-queue-userptr-invalidate.html
* igt@xe_exec_multi_queue@few-execs-preempt-mode-basic:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#8364]) +6 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_exec_multi_queue@few-execs-preempt-mode-basic.html
* igt@xe_exec_reset@long-spin-reuse-many-preempt-threads:
- shard-bmg: [PASS][33] -> [FAIL][34] ([Intel XE#7850])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-8/igt@xe_exec_reset@long-spin-reuse-many-preempt-threads.html
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-1/igt@xe_exec_reset@long-spin-reuse-many-preempt-threads.html
* igt@xe_exec_reset@multi-queue-gt-reset:
- shard-bmg: NOTRUN -> [SKIP][35] ([Intel XE#8369])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_exec_reset@multi-queue-gt-reset.html
* igt@xe_exec_threads@threads-multi-queue-hang-fd-userptr-invalidate-race:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#8378]) +2 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_exec_threads@threads-multi-queue-hang-fd-userptr-invalidate-race.html
* igt@xe_fault_injection@exec-queue-create-fail-xe_pxp_exec_queue_add:
- shard-bmg: NOTRUN -> [SKIP][37] ([Intel XE#6281] / [Intel XE#7426])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@xe_fault_injection@exec-queue-create-fail-xe_pxp_exec_queue_add.html
* igt@xe_fault_injection@vm-bind-fail-xe_pt_update_ops_prepare:
- shard-bmg: [PASS][38] -> [ABORT][39] ([Intel XE#8007])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-3/igt@xe_fault_injection@vm-bind-fail-xe_pt_update_ops_prepare.html
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-8/igt@xe_fault_injection@vm-bind-fail-xe_pt_update_ops_prepare.html
* igt@xe_module_load@load:
- shard-bmg: ([PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60], [PASS][61], [PASS][62], [PASS][63], [PASS][64]) -> ([PASS][65], [PASS][66], [PASS][67], [PASS][68], [PASS][69], [PASS][70], [PASS][71], [PASS][72], [PASS][73], [PASS][74], [PASS][75], [PASS][76], [PASS][77], [PASS][78], [PASS][79], [PASS][80], [PASS][81], [PASS][82], [PASS][83], [SKIP][84], [PASS][85], [PASS][86], [PASS][87], [PASS][88], [PASS][89], [PASS][90]) ([Intel XE#2457] / [Intel XE#7405])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-5/igt@xe_module_load@load.html
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-3/igt@xe_module_load@load.html
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-3/igt@xe_module_load@load.html
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-3/igt@xe_module_load@load.html
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-6/igt@xe_module_load@load.html
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-6/igt@xe_module_load@load.html
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-2/igt@xe_module_load@load.html
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-2/igt@xe_module_load@load.html
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-9/igt@xe_module_load@load.html
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-9/igt@xe_module_load@load.html
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-9/igt@xe_module_load@load.html
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-7/igt@xe_module_load@load.html
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-7/igt@xe_module_load@load.html
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-7/igt@xe_module_load@load.html
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-1/igt@xe_module_load@load.html
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-1/igt@xe_module_load@load.html
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-10/igt@xe_module_load@load.html
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-10/igt@xe_module_load@load.html
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-10/igt@xe_module_load@load.html
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-5/igt@xe_module_load@load.html
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-8/igt@xe_module_load@load.html
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-8/igt@xe_module_load@load.html
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-8/igt@xe_module_load@load.html
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-4/igt@xe_module_load@load.html
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-4/igt@xe_module_load@load.html
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-1/igt@xe_module_load@load.html
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_module_load@load.html
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-9/igt@xe_module_load@load.html
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-2/igt@xe_module_load@load.html
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_module_load@load.html
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-6/igt@xe_module_load@load.html
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-6/igt@xe_module_load@load.html
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-3/igt@xe_module_load@load.html
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-1/igt@xe_module_load@load.html
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@xe_module_load@load.html
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@xe_module_load@load.html
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-7/igt@xe_module_load@load.html
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-10/igt@xe_module_load@load.html
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-10/igt@xe_module_load@load.html
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-8/igt@xe_module_load@load.html
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_module_load@load.html
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-7/igt@xe_module_load@load.html
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-10/igt@xe_module_load@load.html
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-2/igt@xe_module_load@load.html
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_module_load@load.html
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-1/igt@xe_module_load@load.html
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@xe_module_load@load.html
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-3/igt@xe_module_load@load.html
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-8/igt@xe_module_load@load.html
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-9/igt@xe_module_load@load.html
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-9/igt@xe_module_load@load.html
* igt@xe_page_reclaim@binds-large-split:
- shard-bmg: NOTRUN -> [SKIP][91] ([Intel XE#7793])
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_page_reclaim@binds-large-split.html
* igt@xe_pm@d3cold-basic:
- shard-bmg: NOTRUN -> [SKIP][92] ([Intel XE#2284] / [Intel XE#7370])
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_pm@d3cold-basic.html
#### Possible fixes ####
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-lnl: [FAIL][93] -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-lnl-7/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-lnl-4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
- shard-bmg: [INCOMPLETE][95] ([Intel XE#7084] / [Intel XE#8150]) -> [PASS][96] +1 other test pass
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-10/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-4/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-lnl: [FAIL][97] ([Intel XE#301]) -> [PASS][98] +1 other test pass
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-lnl-6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-lnl-7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_setmode@basic:
- shard-bmg: [FAIL][99] -> [PASS][100] +1 other test pass
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-9/igt@kms_setmode@basic.html
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@kms_setmode@basic.html
* igt@xe_exec_reset@long-spin-sys-reuse-many-preempt-threads:
- shard-bmg: [FAIL][101] ([Intel XE#7850]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-3/igt@xe_exec_reset@long-spin-sys-reuse-many-preempt-threads.html
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-6/igt@xe_exec_reset@long-spin-sys-reuse-many-preempt-threads.html
* igt@xe_fault_injection@inject-fault-probe-function-xe_guc_relay_init:
- shard-bmg: [ABORT][103] ([Intel XE#8007]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-1/igt@xe_fault_injection@inject-fault-probe-function-xe_guc_relay_init.html
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-5/igt@xe_fault_injection@inject-fault-probe-function-xe_guc_relay_init.html
#### Warnings ####
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [SKIP][105] ([Intel XE#2426] / [Intel XE#5848]) -> [FAIL][106] ([Intel XE#1729] / [Intel XE#7424])
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55/shard-bmg-8/igt@kms_tiled_display@basic-test-pattern.html
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/shard-bmg-1/igt@kms_tiled_display@basic-test-pattern.html
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2168
[Intel XE#2233]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2233
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2286]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2286
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2325
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2457]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2457
[Intel XE#2486]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2486
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3098]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3098
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#6035]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6035
[Intel XE#6281]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6281
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
[Intel XE#7084]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7084
[Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
[Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
[Intel XE#7342]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7342
[Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
[Intel XE#7356]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7356
[Intel XE#7358]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7358
[Intel XE#7370]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7370
[Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
[Intel XE#7376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7376
[Intel XE#7405]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7405
[Intel XE#7424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7424
[Intel XE#7426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7426
[Intel XE#7444]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7444
[Intel XE#7642]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7642
[Intel XE#7760]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7760
[Intel XE#7793]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7793
[Intel XE#7850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7850
[Intel XE#8007]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8007
[Intel XE#8076]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8076
[Intel XE#8150]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8150
[Intel XE#8265]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8265
[Intel XE#8355]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8355
[Intel XE#8364]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8364
[Intel XE#8369]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8369
[Intel XE#8374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8374
[Intel XE#8378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/8378
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
Build changes
-------------
* Linux: xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55 -> xe-pw-171076v1
IGT_9025: 852c13ddd448fd668c43584ca3ad1aec49c4633c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-5477-b747a63003130bef1a3d5d6ba97c94d0cee36f55: b747a63003130bef1a3d5d6ba97c94d0cee36f55
xe-pw-171076v1: 171076v1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-171076v1/index.html
[-- Attachment #2: Type: text/html, Size: 28283 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c
2026-07-24 12:08 ` Adrián Larumbe
(?)
@ 2026-07-28 14:34 ` Liviu Dudau
-1 siblings, 0 replies; 10+ messages in thread
From: Liviu Dudau @ 2026-07-28 14:34 UTC (permalink / raw)
To: Adrián Larumbe
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Lucas Stach,
Russell King, Christian Gmeiner, Jianmin Lv, Qianhai Wu,
Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Lyude Paul, Danilo Krummrich, Boris Brezillon,
Steven Price, Sandy Huang, Heiko Stübner, Andy Yan,
Thierry Reding, Mikko Perttunen, Jonathan Hunter, Zack Rusin,
Broadcom internal kernel review list, Matthew Brost,
Thomas Hellström, Rodrigo Vivi, Oleksandr Andrushchenko,
Sumit Semwal, amd-gfx, dri-devel, linux-kernel, etnaviv,
linux-arm-msm, freedreno, nouveau, linux-rockchip,
linux-arm-kernel, linux-tegra, intel-xe, xen-devel, linux-media,
linaro-mm-sig
On Fri, Jul 24, 2026 at 01:08:58PM +0100, Adrián Larumbe wrote:
> None of the semantics of the function tell of it being a PRIME-exclusive
> entry point. In fact, most drivers seem to be using it to translate a list
> of pages into an sg table that can be used for GPU mapping later on, rather
> than just for sharing an object's pages with another driver.
>
> Move it across files and rename accordingly.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
> ---
> drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces.
> It is a generic helper that converts a page array into a scatter/gather
> table via dma_map_sg_attrs. Nothing in its implementation touches struct
> dma_buf or import/export logic.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++---
> drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> drivers/gpu/drm/drm_prime.c | 38 -----------------------------
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +--
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++-
> drivers/gpu/drm/loongson/lsdc_gem.c | 3 +--
> drivers/gpu/drm/msm/msm_gem.c | 2 +-
> drivers/gpu/drm/msm/msm_gem_prime.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +--
> drivers/gpu/drm/panthor/panthor_gem.c | 6 ++---
For Panthor and the general rename:
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> drivers/gpu/drm/radeon/radeon_prime.c | 5 ++--
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++---
> drivers/gpu/drm/tegra/gem.c | 4 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +--
> drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++---
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
> include/drm/drm_gem.h | 5 +++-
> include/drm/drm_prime.h | 2 --
> 19 files changed, 68 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index b33c300e26e2..c9a98aec7eb6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->tbo.resource->mem_type) {
> case TTM_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 018df97d590d..22c8a3b5f667 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> }
> EXPORT_SYMBOL(drm_gem_put_pages);
>
> +/**
> + * drm_pages_to_sg - converts a page array into an sg list
> + * @dev: DRM device
> + * @pages: pointer to the array of page pointers to convert
> + * @nr_pages: length of the page vector
> + *
> + * This helper creates an sg table object from a set of pages.
> + * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> + */
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages)
> +{
> + struct sg_table *sg;
> + size_t max_segment = 0;
> + int err;
> +
> + sg = kmalloc_obj(struct sg_table);
> + if (!sg)
> + return ERR_PTR(-ENOMEM);
> +
> + if (dev)
> + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> + if (max_segment == 0)
> + max_segment = UINT_MAX;
> + err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> + (unsigned long)nr_pages << PAGE_SHIFT,
> + max_segment, GFP_KERNEL);
> + if (err) {
> + kfree(sg);
> + sg = ERR_PTR(err);
> + }
> + return sg;
> +}
> +EXPORT_SYMBOL(drm_pages_to_sg);
> +
> static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
> struct drm_gem_object **objs)
> {
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 22ec52e2ffb8..144d088a477f 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem)
>
> drm_WARN_ON(obj->dev, drm_gem_is_imported(obj));
>
> - return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> }
> EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table);
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 9b44c78cd77f..54539a8929c1 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> .vunmap = drm_gem_dmabuf_vunmap,
> };
>
> -/**
> - * drm_prime_pages_to_sg - converts a page array into an sg list
> - * @dev: DRM device
> - * @pages: pointer to the array of page pointers to convert
> - * @nr_pages: length of the page vector
> - *
> - * This helper creates an sg table object from a set of pages
> - * the driver is responsible for mapping the pages into the
> - * importers address space for use with dma_buf itself.
> - *
> - * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> - */
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages)
> -{
> - struct sg_table *sg;
> - size_t max_segment = 0;
> - int err;
> -
> - sg = kmalloc_obj(struct sg_table);
> - if (!sg)
> - return ERR_PTR(-ENOMEM);
> -
> - if (dev)
> - max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> - if (max_segment == 0)
> - max_segment = UINT_MAX;
> - err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> - (unsigned long)nr_pages << PAGE_SHIFT,
> - max_segment, GFP_KERNEL);
> - if (err) {
> - kfree(sg);
> - sg = ERR_PTR(err);
> - }
> - return sg;
> -}
> -EXPORT_SYMBOL(drm_prime_pages_to_sg);
> -
> /**
> * drm_prime_get_contiguous_size - returns the contiguous size of the buffer
> * @sgt: sg_table describing the buffer to check
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index b0436a1e103f..a8e8614f8210 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2015-2018 Etnaviv Project
> */
>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
> #include <linux/dma-mapping.h>
> #include <linux/shmem_fs.h>
> @@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
> unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> struct sg_table *sgt;
>
> - sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
> + sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages);
> if (IS_ERR(sgt)) {
> dev_err(dev->dev, "failed to allocate sgt: %ld\n",
> PTR_ERR(sgt));
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 6757ae6ec304..f44484325ddb 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2014-2018 Etnaviv Project
> */
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <linux/dma-buf.h>
> #include <linux/module.h>
> @@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-EINVAL);
>
> - return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> }
>
> int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c
> index 2fb03487c983..37160228244c 100644
> --- a/drivers/gpu/drm/loongson/lsdc_gem.c
> +++ b/drivers/gpu/drm/loongson/lsdc_gem.c
> @@ -9,7 +9,6 @@
> #include <drm/drm_dumb_buffers.h>
> #include <drm/drm_file.h>
> #include <drm/drm_gem.h>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
>
> #include "lsdc_drv.h"
> @@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj)
> return ERR_PTR(-ENOMEM);
> }
>
> - return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> + return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> }
>
> static void lsdc_gem_object_free(struct drm_gem_object *obj)
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index efd3d3c9a449..7e3418290c22 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
>
> msm_obj->pages = p;
>
> - msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages);
> + msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages);
> if (IS_ERR(msm_obj->sgt)) {
> void *ptr = ERR_CAST(msm_obj->sgt);
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
> index 036d34c674d9..d25393a9e549 100644
> --- a/drivers/gpu/drm/msm/msm_gem_prime.c
> +++ b/drivers/gpu/drm/msm/msm_gem_prime.c
> @@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, msm_obj->pages, npages);
> }
>
> int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
> index caab60fc62f6..b95f2f07df74 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_prime.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
> @@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct nouveau_bo *nvbo = nouveau_gem_object(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> - nvbo->bo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> + nvbo->bo.ttm->num_pages);
> }
>
> struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index 9855df738194..ec530d254fa4 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo)
> if (ret)
> return ERR_PTR(ret);
>
> - sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
> - bo->base.size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages,
> + bo->base.size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> @@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj)
> drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages);
> drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count));
>
> - return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> }
>
> static int panthor_gem_vmap_locked(struct drm_gem_object *obj,
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index a77881f035e7..4cfc4282a59c 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -26,6 +26,7 @@
>
> #include <linux/dma-buf.h>
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <drm/radeon_drm.h>
>
> @@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct radeon_bo *bo = gem_to_radeon_bo(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> }
>
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index b188539dca0b..7897da0becf4 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj)
>
> rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT;
>
> - rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev,
> - rk_obj->pages, rk_obj->num_pages);
> + rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev,
> + rk_obj->pages, rk_obj->num_pages);
> if (IS_ERR(rk_obj->sgt)) {
> ret = PTR_ERR(rk_obj->sgt);
> goto err_put_pages;
> @@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj)
> int ret;
>
> if (rk_obj->pages)
> - return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
> + return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
>
> sgt = kzalloc_obj(*sgt);
> if (!sgt)
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index 436394e04812..701af672b4e5 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -17,7 +17,7 @@
>
> #include <drm/drm_drv.h>
> #include <drm/drm_dumb_buffers.h>
> -#include <drm/drm_prime.h>
> +#include <drm/drm_gem.h>
>
> #include "drm.h"
> #include "gem.h"
> @@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo)
>
> bo->num_pages = bo->gem.size >> PAGE_SHIFT;
>
> - bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> + bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> if (IS_ERR(bo->sgt)) {
> err = PTR_ERR(bo->sgt);
> goto put_pages;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> index 39f8c46550c2..c9e7f2e3668c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> @@ -28,7 +28,7 @@
> #include "vmwgfx_bo.h"
> #include "vmwgfx_drv.h"
>
> -#include "drm/drm_prime.h"
> +#include "drm/drm_gem.h"
> #include "drm/drm_gem_ttm_helper.h"
>
> #include <linux/debugfs.h>
> @@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj)
> if (vmw_tt->vsgt.sgt)
> return vmw_tt->vsgt.sgt;
>
> - return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> + return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> }
>
> static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
> index 8a920e58245c..f0fe80706b79 100644
> --- a/drivers/gpu/drm/xe/xe_dma_buf.c
> +++ b/drivers/gpu/drm/xe/xe_dma_buf.c
> @@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->ttm.resource->mem_type) {
> case XE_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->ttm.ttm->pages,
> - obj->size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->ttm.ttm->pages,
> + obj->size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index eec4c1da3f9e..a4a7c7f2c91c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
> if (!xen_obj->pages)
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(gem_obj->dev,
> + return drm_pages_to_sg(gem_obj->dev,
> xen_obj->pages, xen_obj->num_pages);
> }
>
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index 885244e375d3..7b9cc6335689 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -155,7 +155,7 @@ struct drm_gem_object_funcs {
> * here cannot be used for sg tables pointing at driver private memory
> * ranges.
> *
> - * See also drm_prime_pages_to_sg().
> + * See also drm_pages_to_sg().
> */
> struct sg_table *(*get_sg_table)(struct drm_gem_object *obj);
>
> @@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj);
> void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> bool dirty, bool accessed);
>
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages);
> +
> void drm_gem_lock(struct drm_gem_object *obj);
> void drm_gem_unlock(struct drm_gem_object *obj);
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index f50f862f0d8b..603e16a40ae7 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map);
> int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
> int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages);
> struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj,
> int flags);
>
>
> ---
> base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d
> change-id: 20260724-get_pages-e2e91c53eaa3
>
> Best regards,
> --
> Adrián Larumbe <adrian.larumbe@collabora.com>
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c
@ 2026-07-28 14:34 ` Liviu Dudau
0 siblings, 0 replies; 10+ messages in thread
From: Liviu Dudau @ 2026-07-28 14:34 UTC (permalink / raw)
To: Adrián Larumbe
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Lucas Stach,
Russell King, Christian Gmeiner, Jianmin Lv, Qianhai Wu,
Huacai Chen, Mingcong Bai, Xi Ruoyao, Icenowy Zheng, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Lyude Paul, Danilo Krummrich, Boris Brezillon,
Steven Price, Sandy Huang, Heiko Stübner, Andy Yan,
Thierry Reding, Mikko Perttunen, Jonathan Hunter, Zack Rusin,
Broadcom internal kernel review list, Matthew Brost,
Thomas Hellström, Rodrigo Vivi, Oleksandr Andrushchenko,
Sumit Semwal, amd-gfx, dri-devel, linux-kernel, etnaviv,
linux-arm-msm, freedreno, nouveau, linux-rockchip,
linux-arm-kernel, linux-tegra, intel-xe, xen-devel, linux-media,
linaro-mm-sig
On Fri, Jul 24, 2026 at 01:08:58PM +0100, Adrián Larumbe wrote:
> None of the semantics of the function tell of it being a PRIME-exclusive
> entry point. In fact, most drivers seem to be using it to translate a list
> of pages into an sg table that can be used for GPU mapping later on, rather
> than just for sharing an object's pages with another driver.
>
> Move it across files and rename accordingly.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
> ---
> drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces.
> It is a generic helper that converts a page array into a scatter/gather
> table via dma_map_sg_attrs. Nothing in its implementation touches struct
> dma_buf or import/export logic.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++---
> drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> drivers/gpu/drm/drm_prime.c | 38 -----------------------------
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +--
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++-
> drivers/gpu/drm/loongson/lsdc_gem.c | 3 +--
> drivers/gpu/drm/msm/msm_gem.c | 2 +-
> drivers/gpu/drm/msm/msm_gem_prime.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +--
> drivers/gpu/drm/panthor/panthor_gem.c | 6 ++---
For Panthor and the general rename:
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> drivers/gpu/drm/radeon/radeon_prime.c | 5 ++--
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++---
> drivers/gpu/drm/tegra/gem.c | 4 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +--
> drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++---
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
> include/drm/drm_gem.h | 5 +++-
> include/drm/drm_prime.h | 2 --
> 19 files changed, 68 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index b33c300e26e2..c9a98aec7eb6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->tbo.resource->mem_type) {
> case TTM_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 018df97d590d..22c8a3b5f667 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> }
> EXPORT_SYMBOL(drm_gem_put_pages);
>
> +/**
> + * drm_pages_to_sg - converts a page array into an sg list
> + * @dev: DRM device
> + * @pages: pointer to the array of page pointers to convert
> + * @nr_pages: length of the page vector
> + *
> + * This helper creates an sg table object from a set of pages.
> + * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> + */
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages)
> +{
> + struct sg_table *sg;
> + size_t max_segment = 0;
> + int err;
> +
> + sg = kmalloc_obj(struct sg_table);
> + if (!sg)
> + return ERR_PTR(-ENOMEM);
> +
> + if (dev)
> + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> + if (max_segment == 0)
> + max_segment = UINT_MAX;
> + err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> + (unsigned long)nr_pages << PAGE_SHIFT,
> + max_segment, GFP_KERNEL);
> + if (err) {
> + kfree(sg);
> + sg = ERR_PTR(err);
> + }
> + return sg;
> +}
> +EXPORT_SYMBOL(drm_pages_to_sg);
> +
> static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
> struct drm_gem_object **objs)
> {
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 22ec52e2ffb8..144d088a477f 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem)
>
> drm_WARN_ON(obj->dev, drm_gem_is_imported(obj));
>
> - return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> }
> EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table);
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 9b44c78cd77f..54539a8929c1 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> .vunmap = drm_gem_dmabuf_vunmap,
> };
>
> -/**
> - * drm_prime_pages_to_sg - converts a page array into an sg list
> - * @dev: DRM device
> - * @pages: pointer to the array of page pointers to convert
> - * @nr_pages: length of the page vector
> - *
> - * This helper creates an sg table object from a set of pages
> - * the driver is responsible for mapping the pages into the
> - * importers address space for use with dma_buf itself.
> - *
> - * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> - */
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages)
> -{
> - struct sg_table *sg;
> - size_t max_segment = 0;
> - int err;
> -
> - sg = kmalloc_obj(struct sg_table);
> - if (!sg)
> - return ERR_PTR(-ENOMEM);
> -
> - if (dev)
> - max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> - if (max_segment == 0)
> - max_segment = UINT_MAX;
> - err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> - (unsigned long)nr_pages << PAGE_SHIFT,
> - max_segment, GFP_KERNEL);
> - if (err) {
> - kfree(sg);
> - sg = ERR_PTR(err);
> - }
> - return sg;
> -}
> -EXPORT_SYMBOL(drm_prime_pages_to_sg);
> -
> /**
> * drm_prime_get_contiguous_size - returns the contiguous size of the buffer
> * @sgt: sg_table describing the buffer to check
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index b0436a1e103f..a8e8614f8210 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2015-2018 Etnaviv Project
> */
>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
> #include <linux/dma-mapping.h>
> #include <linux/shmem_fs.h>
> @@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
> unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> struct sg_table *sgt;
>
> - sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
> + sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages);
> if (IS_ERR(sgt)) {
> dev_err(dev->dev, "failed to allocate sgt: %ld\n",
> PTR_ERR(sgt));
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 6757ae6ec304..f44484325ddb 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2014-2018 Etnaviv Project
> */
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <linux/dma-buf.h>
> #include <linux/module.h>
> @@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-EINVAL);
>
> - return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> }
>
> int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c
> index 2fb03487c983..37160228244c 100644
> --- a/drivers/gpu/drm/loongson/lsdc_gem.c
> +++ b/drivers/gpu/drm/loongson/lsdc_gem.c
> @@ -9,7 +9,6 @@
> #include <drm/drm_dumb_buffers.h>
> #include <drm/drm_file.h>
> #include <drm/drm_gem.h>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
>
> #include "lsdc_drv.h"
> @@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj)
> return ERR_PTR(-ENOMEM);
> }
>
> - return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> + return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> }
>
> static void lsdc_gem_object_free(struct drm_gem_object *obj)
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index efd3d3c9a449..7e3418290c22 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
>
> msm_obj->pages = p;
>
> - msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages);
> + msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages);
> if (IS_ERR(msm_obj->sgt)) {
> void *ptr = ERR_CAST(msm_obj->sgt);
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
> index 036d34c674d9..d25393a9e549 100644
> --- a/drivers/gpu/drm/msm/msm_gem_prime.c
> +++ b/drivers/gpu/drm/msm/msm_gem_prime.c
> @@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, msm_obj->pages, npages);
> }
>
> int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
> index caab60fc62f6..b95f2f07df74 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_prime.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
> @@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct nouveau_bo *nvbo = nouveau_gem_object(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> - nvbo->bo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> + nvbo->bo.ttm->num_pages);
> }
>
> struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index 9855df738194..ec530d254fa4 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo)
> if (ret)
> return ERR_PTR(ret);
>
> - sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
> - bo->base.size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages,
> + bo->base.size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> @@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj)
> drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages);
> drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count));
>
> - return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> }
>
> static int panthor_gem_vmap_locked(struct drm_gem_object *obj,
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index a77881f035e7..4cfc4282a59c 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -26,6 +26,7 @@
>
> #include <linux/dma-buf.h>
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <drm/radeon_drm.h>
>
> @@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct radeon_bo *bo = gem_to_radeon_bo(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> }
>
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index b188539dca0b..7897da0becf4 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj)
>
> rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT;
>
> - rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev,
> - rk_obj->pages, rk_obj->num_pages);
> + rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev,
> + rk_obj->pages, rk_obj->num_pages);
> if (IS_ERR(rk_obj->sgt)) {
> ret = PTR_ERR(rk_obj->sgt);
> goto err_put_pages;
> @@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj)
> int ret;
>
> if (rk_obj->pages)
> - return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
> + return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
>
> sgt = kzalloc_obj(*sgt);
> if (!sgt)
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index 436394e04812..701af672b4e5 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -17,7 +17,7 @@
>
> #include <drm/drm_drv.h>
> #include <drm/drm_dumb_buffers.h>
> -#include <drm/drm_prime.h>
> +#include <drm/drm_gem.h>
>
> #include "drm.h"
> #include "gem.h"
> @@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo)
>
> bo->num_pages = bo->gem.size >> PAGE_SHIFT;
>
> - bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> + bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> if (IS_ERR(bo->sgt)) {
> err = PTR_ERR(bo->sgt);
> goto put_pages;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> index 39f8c46550c2..c9e7f2e3668c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> @@ -28,7 +28,7 @@
> #include "vmwgfx_bo.h"
> #include "vmwgfx_drv.h"
>
> -#include "drm/drm_prime.h"
> +#include "drm/drm_gem.h"
> #include "drm/drm_gem_ttm_helper.h"
>
> #include <linux/debugfs.h>
> @@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj)
> if (vmw_tt->vsgt.sgt)
> return vmw_tt->vsgt.sgt;
>
> - return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> + return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> }
>
> static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
> index 8a920e58245c..f0fe80706b79 100644
> --- a/drivers/gpu/drm/xe/xe_dma_buf.c
> +++ b/drivers/gpu/drm/xe/xe_dma_buf.c
> @@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->ttm.resource->mem_type) {
> case XE_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->ttm.ttm->pages,
> - obj->size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->ttm.ttm->pages,
> + obj->size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index eec4c1da3f9e..a4a7c7f2c91c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
> if (!xen_obj->pages)
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(gem_obj->dev,
> + return drm_pages_to_sg(gem_obj->dev,
> xen_obj->pages, xen_obj->num_pages);
> }
>
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index 885244e375d3..7b9cc6335689 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -155,7 +155,7 @@ struct drm_gem_object_funcs {
> * here cannot be used for sg tables pointing at driver private memory
> * ranges.
> *
> - * See also drm_prime_pages_to_sg().
> + * See also drm_pages_to_sg().
> */
> struct sg_table *(*get_sg_table)(struct drm_gem_object *obj);
>
> @@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj);
> void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> bool dirty, bool accessed);
>
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages);
> +
> void drm_gem_lock(struct drm_gem_object *obj);
> void drm_gem_unlock(struct drm_gem_object *obj);
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index f50f862f0d8b..603e16a40ae7 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map);
> int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
> int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages);
> struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj,
> int flags);
>
>
> ---
> base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d
> change-id: 20260724-get_pages-e2e91c53eaa3
>
> Best regards,
> --
> Adrián Larumbe <adrian.larumbe@collabora.com>
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] drm/gem: Move pages_to_sg helper into drm_gem.c
@ 2026-07-28 14:34 ` Liviu Dudau
0 siblings, 0 replies; 10+ messages in thread
From: Liviu Dudau @ 2026-07-28 14:34 UTC (permalink / raw)
To: Adrián Larumbe
Cc: Alex Deucher, Christian König, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Lucas Stach, Russell King,
Christian Gmeiner, Jianmin Lv, Qianhai Wu, Huacai Chen,
Mingcong Bai, Xi Ruoyao, Icenowy Zheng, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Danilo Krummrich, Boris Brezillon, Steven Price,
Sandy Huang, Heiko Stübner, Andy Yan, Thierry Reding,
Mikko Perttunen, Zack Rusin, Broadcom internal kernel review list,
Matthew Brost, Thomas Hellström, Rodrigo Vivi,
Oleksandr Andrushchenko, Sumit Semwal, amd-gfx, dri-devel,
linux-kernel, etnaviv, linux-arm-msm, freedreno, nouveau,
linux-rockchip, linux-arm-kernel, linux-tegra, intel-xe,
xen-devel, linux-media, linaro-mm-sig
On Fri, Jul 24, 2026 at 01:08:58PM +0100, Adrián Larumbe wrote:
> None of the semantics of the function tell of it being a PRIME-exclusive
> entry point. In fact, most drivers seem to be using it to translate a list
> of pages into an sg table that can be used for GPU mapping later on, rather
> than just for sharing an object's pages with another driver.
>
> Move it across files and rename accordingly.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
> ---
> drm_prime_pages_to_sg() has no real dependency on PRIME/dma-buf interfaces.
> It is a generic helper that converts a page array into a scatter/gather
> table via dma_map_sg_attrs. Nothing in its implementation touches struct
> dma_buf or import/export logic.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 6 ++---
> drivers/gpu/drm/drm_gem.c | 35 ++++++++++++++++++++++++++
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> drivers/gpu/drm/drm_prime.c | 38 -----------------------------
> drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 +--
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 ++-
> drivers/gpu/drm/loongson/lsdc_gem.c | 3 +--
> drivers/gpu/drm/msm/msm_gem.c | 2 +-
> drivers/gpu/drm/msm/msm_gem_prime.c | 2 +-
> drivers/gpu/drm/nouveau/nouveau_prime.c | 4 +--
> drivers/gpu/drm/panthor/panthor_gem.c | 6 ++---
For Panthor and the general rename:
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> drivers/gpu/drm/radeon/radeon_prime.c | 5 ++--
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 6 ++---
> drivers/gpu/drm/tegra/gem.c | 4 +--
> drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 4 +--
> drivers/gpu/drm/xe/xe_dma_buf.c | 6 ++---
> drivers/gpu/drm/xen/xen_drm_front_gem.c | 2 +-
> include/drm/drm_gem.h | 5 +++-
> include/drm/drm_prime.h | 2 --
> 19 files changed, 68 insertions(+), 70 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> index b33c300e26e2..c9a98aec7eb6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c
> @@ -203,9 +203,9 @@ static struct sg_table *amdgpu_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->tbo.resource->mem_type) {
> case TTM_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 018df97d590d..22c8a3b5f667 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -780,6 +780,41 @@ void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> }
> EXPORT_SYMBOL(drm_gem_put_pages);
>
> +/**
> + * drm_pages_to_sg - converts a page array into an sg list
> + * @dev: DRM device
> + * @pages: pointer to the array of page pointers to convert
> + * @nr_pages: length of the page vector
> + *
> + * This helper creates an sg table object from a set of pages.
> + * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> + */
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages)
> +{
> + struct sg_table *sg;
> + size_t max_segment = 0;
> + int err;
> +
> + sg = kmalloc_obj(struct sg_table);
> + if (!sg)
> + return ERR_PTR(-ENOMEM);
> +
> + if (dev)
> + max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> + if (max_segment == 0)
> + max_segment = UINT_MAX;
> + err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> + (unsigned long)nr_pages << PAGE_SHIFT,
> + max_segment, GFP_KERNEL);
> + if (err) {
> + kfree(sg);
> + sg = ERR_PTR(err);
> + }
> + return sg;
> +}
> +EXPORT_SYMBOL(drm_pages_to_sg);
> +
> static int objects_lookup(struct drm_file *filp, u32 *handle, int count,
> struct drm_gem_object **objs)
> {
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 22ec52e2ffb8..144d088a477f 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -825,7 +825,7 @@ struct sg_table *drm_gem_shmem_get_sg_table(struct drm_gem_shmem_object *shmem)
>
> drm_WARN_ON(obj->dev, drm_gem_is_imported(obj));
>
> - return drm_prime_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, shmem->pages, obj->size >> PAGE_SHIFT);
> }
> EXPORT_SYMBOL_GPL(drm_gem_shmem_get_sg_table);
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 9b44c78cd77f..54539a8929c1 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -835,44 +835,6 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> .vunmap = drm_gem_dmabuf_vunmap,
> };
>
> -/**
> - * drm_prime_pages_to_sg - converts a page array into an sg list
> - * @dev: DRM device
> - * @pages: pointer to the array of page pointers to convert
> - * @nr_pages: length of the page vector
> - *
> - * This helper creates an sg table object from a set of pages
> - * the driver is responsible for mapping the pages into the
> - * importers address space for use with dma_buf itself.
> - *
> - * This is useful for implementing &drm_gem_object_funcs.get_sg_table.
> - */
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages)
> -{
> - struct sg_table *sg;
> - size_t max_segment = 0;
> - int err;
> -
> - sg = kmalloc_obj(struct sg_table);
> - if (!sg)
> - return ERR_PTR(-ENOMEM);
> -
> - if (dev)
> - max_segment = dma_max_mapping_size(drm_dev_dma_dev(dev));
> - if (max_segment == 0)
> - max_segment = UINT_MAX;
> - err = sg_alloc_table_from_pages_segment(sg, pages, nr_pages, 0,
> - (unsigned long)nr_pages << PAGE_SHIFT,
> - max_segment, GFP_KERNEL);
> - if (err) {
> - kfree(sg);
> - sg = ERR_PTR(err);
> - }
> - return sg;
> -}
> -EXPORT_SYMBOL(drm_prime_pages_to_sg);
> -
> /**
> * drm_prime_get_contiguous_size - returns the contiguous size of the buffer
> * @sgt: sg_table describing the buffer to check
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> index b0436a1e103f..a8e8614f8210 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> @@ -3,7 +3,6 @@
> * Copyright (C) 2015-2018 Etnaviv Project
> */
>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
> #include <linux/dma-mapping.h>
> #include <linux/shmem_fs.h>
> @@ -104,7 +103,7 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
> unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
> struct sg_table *sgt;
>
> - sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
> + sgt = drm_pages_to_sg(dev, etnaviv_obj->pages, npages);
> if (IS_ERR(sgt)) {
> dev_err(dev->dev, "failed to allocate sgt: %ld\n",
> PTR_ERR(sgt));
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 6757ae6ec304..f44484325ddb 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -3,6 +3,7 @@
> * Copyright (C) 2014-2018 Etnaviv Project
> */
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <linux/dma-buf.h>
> #include <linux/module.h>
> @@ -22,7 +23,7 @@ struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!etnaviv_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-EINVAL);
>
> - return drm_prime_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, etnaviv_obj->pages, npages);
> }
>
> int etnaviv_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson/lsdc_gem.c
> index 2fb03487c983..37160228244c 100644
> --- a/drivers/gpu/drm/loongson/lsdc_gem.c
> +++ b/drivers/gpu/drm/loongson/lsdc_gem.c
> @@ -9,7 +9,6 @@
> #include <drm/drm_dumb_buffers.h>
> #include <drm/drm_file.h>
> #include <drm/drm_gem.h>
> -#include <drm/drm_prime.h>
> #include <drm/drm_print.h>
>
> #include "lsdc_drv.h"
> @@ -51,7 +50,7 @@ static struct sg_table *lsdc_gem_prime_get_sg_table(struct drm_gem_object *obj)
> return ERR_PTR(-ENOMEM);
> }
>
> - return drm_prime_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> + return drm_pages_to_sg(obj->dev, tt->pages, tt->num_pages);
> }
>
> static void lsdc_gem_object_free(struct drm_gem_object *obj)
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index efd3d3c9a449..7e3418290c22 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -207,7 +207,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
>
> msm_obj->pages = p;
>
> - msm_obj->sgt = drm_prime_pages_to_sg(obj->dev, p, npages);
> + msm_obj->sgt = drm_pages_to_sg(obj->dev, p, npages);
> if (IS_ERR(msm_obj->sgt)) {
> void *ptr = ERR_CAST(msm_obj->sgt);
>
> diff --git a/drivers/gpu/drm/msm/msm_gem_prime.c b/drivers/gpu/drm/msm/msm_gem_prime.c
> index 036d34c674d9..d25393a9e549 100644
> --- a/drivers/gpu/drm/msm/msm_gem_prime.c
> +++ b/drivers/gpu/drm/msm/msm_gem_prime.c
> @@ -23,7 +23,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)
> if (WARN_ON(!msm_obj->pages)) /* should have already pinned! */
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(obj->dev, msm_obj->pages, npages);
> + return drm_pages_to_sg(obj->dev, msm_obj->pages, npages);
> }
>
> int msm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/nouveau/nouveau_prime.c b/drivers/gpu/drm/nouveau/nouveau_prime.c
> index caab60fc62f6..b95f2f07df74 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_prime.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_prime.c
> @@ -32,8 +32,8 @@ struct sg_table *nouveau_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct nouveau_bo *nvbo = nouveau_gem_object(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> - nvbo->bo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, nvbo->bo.ttm->pages,
> + nvbo->bo.ttm->num_pages);
> }
>
> struct drm_gem_object *nouveau_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/panthor/panthor_gem.c
> index 9855df738194..ec530d254fa4 100644
> --- a/drivers/gpu/drm/panthor/panthor_gem.c
> +++ b/drivers/gpu/drm/panthor/panthor_gem.c
> @@ -321,8 +321,8 @@ panthor_gem_dev_map_get_sgt_locked(struct panthor_gem_object *bo)
> if (ret)
> return ERR_PTR(ret);
>
> - sgt = drm_prime_pages_to_sg(bo->base.dev, bo->backing.pages,
> - bo->base.size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(bo->base.dev, bo->backing.pages,
> + bo->base.size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> @@ -702,7 +702,7 @@ static struct sg_table *panthor_gem_get_sg_table(struct drm_gem_object *obj)
> drm_WARN_ON_ONCE(obj->dev, !bo->backing.pages);
> drm_WARN_ON_ONCE(obj->dev, !refcount_read(&bo->backing.pin_count));
>
> - return drm_prime_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> + return drm_pages_to_sg(obj->dev, bo->backing.pages, obj->size >> PAGE_SHIFT);
> }
>
> static int panthor_gem_vmap_locked(struct drm_gem_object *obj,
> diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/radeon/radeon_prime.c
> index a77881f035e7..4cfc4282a59c 100644
> --- a/drivers/gpu/drm/radeon/radeon_prime.c
> +++ b/drivers/gpu/drm/radeon/radeon_prime.c
> @@ -26,6 +26,7 @@
>
> #include <linux/dma-buf.h>
>
> +#include <drm/drm_gem.h>
> #include <drm/drm_prime.h>
> #include <drm/radeon_drm.h>
>
> @@ -38,8 +39,8 @@ struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *obj)
> {
> struct radeon_bo *bo = gem_to_radeon_bo(obj);
>
> - return drm_prime_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> - bo->tbo.ttm->num_pages);
> + return drm_pages_to_sg(obj->dev, bo->tbo.ttm->pages,
> + bo->tbo.ttm->num_pages);
> }
>
> struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_device *dev,
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index b188539dca0b..7897da0becf4 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -89,8 +89,8 @@ static int rockchip_gem_get_pages(struct rockchip_gem_object *rk_obj)
>
> rk_obj->num_pages = rk_obj->base.size >> PAGE_SHIFT;
>
> - rk_obj->sgt = drm_prime_pages_to_sg(rk_obj->base.dev,
> - rk_obj->pages, rk_obj->num_pages);
> + rk_obj->sgt = drm_pages_to_sg(rk_obj->base.dev,
> + rk_obj->pages, rk_obj->num_pages);
> if (IS_ERR(rk_obj->sgt)) {
> ret = PTR_ERR(rk_obj->sgt);
> goto err_put_pages;
> @@ -432,7 +432,7 @@ struct sg_table *rockchip_gem_prime_get_sg_table(struct drm_gem_object *obj)
> int ret;
>
> if (rk_obj->pages)
> - return drm_prime_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
> + return drm_pages_to_sg(obj->dev, rk_obj->pages, rk_obj->num_pages);
>
> sgt = kzalloc_obj(*sgt);
> if (!sgt)
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index 436394e04812..701af672b4e5 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -17,7 +17,7 @@
>
> #include <drm/drm_drv.h>
> #include <drm/drm_dumb_buffers.h>
> -#include <drm/drm_prime.h>
> +#include <drm/drm_gem.h>
>
> #include "drm.h"
> #include "gem.h"
> @@ -352,7 +352,7 @@ static int tegra_bo_get_pages(struct drm_device *drm, struct tegra_bo *bo)
>
> bo->num_pages = bo->gem.size >> PAGE_SHIFT;
>
> - bo->sgt = drm_prime_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> + bo->sgt = drm_pages_to_sg(bo->gem.dev, bo->pages, bo->num_pages);
> if (IS_ERR(bo->sgt)) {
> err = PTR_ERR(bo->sgt);
> goto put_pages;
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> index 39f8c46550c2..c9e7f2e3668c 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> @@ -28,7 +28,7 @@
> #include "vmwgfx_bo.h"
> #include "vmwgfx_drv.h"
>
> -#include "drm/drm_prime.h"
> +#include "drm/drm_gem.h"
> #include "drm/drm_gem_ttm_helper.h"
>
> #include <linux/debugfs.h>
> @@ -76,7 +76,7 @@ static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object *obj)
> if (vmw_tt->vsgt.sgt)
> return vmw_tt->vsgt.sgt;
>
> - return drm_prime_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> + return drm_pages_to_sg(obj->dev, vmw_tt->dma_ttm.pages, vmw_tt->dma_ttm.num_pages);
> }
>
> static int vmw_gem_vmap(struct drm_gem_object *obj, struct iosys_map *map)
> diff --git a/drivers/gpu/drm/xe/xe_dma_buf.c b/drivers/gpu/drm/xe/xe_dma_buf.c
> index 8a920e58245c..f0fe80706b79 100644
> --- a/drivers/gpu/drm/xe/xe_dma_buf.c
> +++ b/drivers/gpu/drm/xe/xe_dma_buf.c
> @@ -118,9 +118,9 @@ static struct sg_table *xe_dma_buf_map(struct dma_buf_attachment *attach,
>
> switch (bo->ttm.resource->mem_type) {
> case XE_PL_TT:
> - sgt = drm_prime_pages_to_sg(obj->dev,
> - bo->ttm.ttm->pages,
> - obj->size >> PAGE_SHIFT);
> + sgt = drm_pages_to_sg(obj->dev,
> + bo->ttm.ttm->pages,
> + obj->size >> PAGE_SHIFT);
> if (IS_ERR(sgt))
> return sgt;
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_gem.c b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> index eec4c1da3f9e..a4a7c7f2c91c 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_gem.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_gem.c
> @@ -236,7 +236,7 @@ struct sg_table *xen_drm_front_gem_get_sg_table(struct drm_gem_object *gem_obj)
> if (!xen_obj->pages)
> return ERR_PTR(-ENOMEM);
>
> - return drm_prime_pages_to_sg(gem_obj->dev,
> + return drm_pages_to_sg(gem_obj->dev,
> xen_obj->pages, xen_obj->num_pages);
> }
>
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index 885244e375d3..7b9cc6335689 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -155,7 +155,7 @@ struct drm_gem_object_funcs {
> * here cannot be used for sg tables pointing at driver private memory
> * ranges.
> *
> - * See also drm_prime_pages_to_sg().
> + * See also drm_pages_to_sg().
> */
> struct sg_table *(*get_sg_table)(struct drm_gem_object *obj);
>
> @@ -589,6 +589,9 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj);
> void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
> bool dirty, bool accessed);
>
> +struct sg_table *drm_pages_to_sg(struct drm_device *dev,
> + struct page **pages, unsigned int nr_pages);
> +
> void drm_gem_lock(struct drm_gem_object *obj);
> void drm_gem_unlock(struct drm_gem_object *obj);
>
> diff --git a/include/drm/drm_prime.h b/include/drm/drm_prime.h
> index f50f862f0d8b..603e16a40ae7 100644
> --- a/include/drm/drm_prime.h
> +++ b/include/drm/drm_prime.h
> @@ -92,8 +92,6 @@ void drm_gem_dmabuf_vunmap(struct dma_buf *dma_buf, struct iosys_map *map);
> int drm_gem_prime_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma);
> int drm_gem_dmabuf_mmap(struct dma_buf *dma_buf, struct vm_area_struct *vma);
>
> -struct sg_table *drm_prime_pages_to_sg(struct drm_device *dev,
> - struct page **pages, unsigned int nr_pages);
> struct dma_buf *drm_gem_prime_export(struct drm_gem_object *obj,
> int flags);
>
>
> ---
> base-commit: 48dd37d1fef33fbf42f1d6887c61e242fd21d00d
> change-id: 20260724-get_pages-e2e91c53eaa3
>
> Best regards,
> --
> Adrián Larumbe <adrian.larumbe@collabora.com>
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
^ permalink raw reply [flat|nested] 10+ messages in thread