[PATCH] regulator: tps65185: handle gpiod_get_value_cansleep() error returns

[PATCH] regulator: tps65185: handle gpiod_get_value_cansleep() error returns

[kr494167]

From: Surendra Singh Chouhan <kr494167@gmail.com>

tps65185_vposneg_enable() evaluated:
  if (gpiod_get_value_cansleep(data->pgood_gpio) != 1)
      return -ETIMEDOUT;

gpiod_get_value_cansleep() returns 1 if active, 0 if inactive, and a
negative error code (e.g. -EIO or -EINVAL) on failure. Evaluating != 1
treats a negative error code as non-equal, swallowing GPIO read errors and
masking them as -ETIMEDOUT.

Fix this by capturing the return value of gpiod_get_value_cansleep(). If
it returns a negative error code, propagate that error immediately; if
it returns 0 (inactive), return -ETIMEDOUT.

Fixes: b0fc1e770194 ("regulator: Add TPS65185 driver")
Signed-off-by: Surendra Singh Chouhan <kr494167@gmail.com>
---
 drivers/regulator/tps65185.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/tps65185.c b/drivers/regulator/tps65185.c
index 786622d8d598..1f13e4156cab 100644
--- a/drivers/regulator/tps65185.c
+++ b/drivers/regulator/tps65185.c
@@ -183,7 +183,10 @@ static int tps65185_vposneg_enable(struct regulator_dev *rdev)
 	wait_for_completion_timeout(&data->pgood_completion,
 				    msecs_to_jiffies(PGOOD_TIMEOUT_MSECS));
 	dev_dbg(data->dev, "turned on");
-	if (gpiod_get_value_cansleep(data->pgood_gpio) != 1)
+	ret = gpiod_get_value_cansleep(data->pgood_gpio);
+	if (ret < 0)
+		return ret;
+	if (!ret)
 		return -ETIMEDOUT;
 
 	return 0;
-- 
2.55.0

Re: [PATCH] regulator: tps65185: handle gpiod_get_value_cansleep() error returns

[Andreas Kemnade]

On Fri, Jul 24, 2026 at 06:28:57PM +0530, kr494167@gmail.com wrote:
> From: Surendra Singh Chouhan <kr494167@gmail.com>
> 
> tps65185_vposneg_enable() evaluated:
>   if (gpiod_get_value_cansleep(data->pgood_gpio) != 1)
>       return -ETIMEDOUT;
> 
> gpiod_get_value_cansleep() returns 1 if active, 0 if inactive, and a
> negative error code (e.g. -EIO or -EINVAL) on failure. Evaluating != 1
> treats a negative error code as non-equal, swallowing GPIO read errors and
> masking them as -ETIMEDOUT.
> 
> Fix this by capturing the return value of gpiod_get_value_cansleep(). If
> it returns a negative error code, propagate that error immediately; if
> it returns 0 (inactive), return -ETIMEDOUT.
> 
> Fixes: b0fc1e770194 ("regulator: Add TPS65185 driver")
> Signed-off-by: Surendra Singh Chouhan <kr494167@gmail.com>

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>