[PATCH v2] staging: rtl8723bs: fix line length warnings in os_intfs.c

[PATCH v2] staging: rtl8723bs: fix line length warnings in os_intfs.c

[Bramwel Barack]

Hi Greg,

This is a v2 patch addressing your feedback on comment block placement
and providing the missing commit description text.

Thanks,
Bramwel

---

From 8fb05fdee4c523bcafc5b425851b95e69e22182a Mon Sep 17 00:00:00 2001
From: Bramwel Barack <bramwelbarack89@gmail.com>
Date: Wed, 29 Jul 2026 09:33:57 +0300
Subject: [PATCH v2] staging: rtl8723bs: fix line length warnings in os_intfs.c

Fix coding style warnings where comment lines exceeded the 100-character limit. Move the split multi-line comment block above the target variable declaration to comply with standard kernel comment formatting.

Signed-off-by: Bramwel Barack <bramwelbarack89@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54b3e..796e7340d66c 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -71,7 +71,12 @@ int rtw_ht_enable = 1;
  * 0x01 means enable 2.4G 40MHz
  */
 static int rtw_bw_mode = 0x01;
-static int rtw_ampdu_enable = 1;/* for enable tx_ampdu ,0: disable, 0x1:enable (but wifi_spec should be 0), 0x2: force enable (don't care wifi_spec) */
+/* for enable tx_ampdu:
+ * 0: disable
+ * 0x1:enable (but wifi_spec should be 0)
+ * 0x2: force enable (don't care wifi_spec) 
+ */
+static int rtw_ampdu_enable = 1;
 static int rtw_rx_stbc = 1;/*  0: disable, 1:enable 2.4g */
 static int rtw_ampdu_amsdu;/*  0: disabled, 1:enabled, 2:auto . There is an IOT issu with DLINK DIR-629 when the flag turn on */
 /*  Short GI support Bit Map */
-- 
2.55.0

Re: [PATCH v2] staging: rtl8723bs: fix line length warnings in os_intfs.c

[Greg KH]

On Wed, Jul 29, 2026 at 11:54:30AM +0300, Bramwel Barack wrote:
> Hi Greg,
> 
> This is a v2 patch addressing your feedback on comment block placement
> and providing the missing commit description text.

As per the documentation, the v2 stuff goes below the --- line, right?

Take a look at the mailing list for hundreds of examples to follow.
This style here will not work well.

> 
> Thanks,
> Bramwel
> 
> ---
> 
> >From 8fb05fdee4c523bcafc5b425851b95e69e22182a Mon Sep 17 00:00:00 2001
> From: Bramwel Barack <bramwelbarack89@gmail.com>
> Date: Wed, 29 Jul 2026 09:33:57 +0300
> Subject: [PATCH v2] staging: rtl8723bs: fix line length warnings in os_intfs.c
> 
> Fix coding style warnings where comment lines exceeded the 100-character limit. Move the split multi-line comment block above the target variable declaration to comply with standard kernel comment formatting.

The irony of a line length warning patch having a line-length issue in
the changelog text itself is quite high :)

Always run checkpatch.pl on your changes before sending them out.
Again, look at the tool 'b4', it has an option to run checkpatch on the
patch before it is sent out.

thanks,

greg k-h

Re: [PATCH v2] staging: rtl8723bs: fix line length warnings in os_intfs.c

[Dan Carpenter]

On Wed, Jul 29, 2026 at 11:54:30AM +0300, Bramwel Barack wrote:
> +/* for enable tx_ampdu:
> + * 0: disable
> + * 0x1:enable (but wifi_spec should be 0)
> + * 0x2: force enable (don't care wifi_spec) 
> + */

Does this really look beautiful to you?

There are a bunch for rules for v2 patches...
staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter