Re: [PATCH v2 07/10] ARM: tegra: tf701t: Fix BCM43341 WiFi/BT chip configuration

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2386 bytes --]

On Tue, Jul 28, 2026 at 05:08:40PM +0300, Svyatoslav Ryhel wrote:
> вт, 28 лип. 2026 р. о 15:13 Mikko Perttunen <mperttunen@nvidia.com> пише:
> >
> > On Tuesday, July 21, 2026 7:10 PM Svyatoslav Ryhel wrote:
> > > Drop reset GPIO from bluetooth part. Add lpo clock to both WiFi and
> > > bluetooth nodes. Add 'brcm,bcm43340-fmac' as primary compatible and
> > > 'brcm,bcm4329-fmac' remains as fallback.
> > >
> > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > ---
> > >  arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts | 13 ++++++++-----
> > >  1 file changed, 8 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > > index 3de5c84d5f009..b71a02b3fd86f 100644
> > > --- a/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > > +++ b/arch/arm/boot/dts/nvidia/tegra114-asus-tf701t.dts
> > > @@ -1300,8 +1300,9 @@ bluetooth {
> > >                       compatible = "brcm,bcm4334-bt";
> > >                       max-speed = <4000000>;
> > >
> > > -                     clocks = <&tegra_pmc TEGRA_PMC_CLK_BLINK>;
> > > -                     clock-names = "txco";
> > > +                     clocks = <&tegra_pmc TEGRA_PMC_CLK_BLINK>,
> > > +                              <&palmas_clk32k>;
> > > +                     clock-names = "txco", "lpo";
> > >
> > >                       interrupt-parent = <&gpio>;
> > >                       interrupts = <TEGRA_GPIO(U, 6) IRQ_TYPE_EDGE_RISING>;
> > > @@ -1309,7 +1310,6 @@ bluetooth {
> > >
> > >                       device-wakeup-gpios = <&gpio TEGRA_GPIO(EE, 1) GPIO_ACTIVE_HIGH>;
> > >                       shutdown-gpios = <&gpio TEGRA_GPIO(Q, 7) GPIO_ACTIVE_HIGH>;
> > > -                     reset-gpios = <&gpio TEGRA_GPIO(Q, 6) GPIO_ACTIVE_LOW>;
> >
> > I'd appreciate a note in the commit message on why this is dropped.
> >
> 
> It does not comply schema for "brcm,bcm4334-bt", further testing with
> this reset gpio removed confirmed that it has nothing to do with
> bluetooth and bluetooth works just fine without it.

Maybe this should be a separate patch to make it obvious that this fixes
a DTB validation issue. At the very least the commit message should say
that this drop the reset GPIO because it's not part of the binding.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]