Re: [PATCH v4 6/9] KVM: selftests: Add various print flags to KVM selftest runner

From: Sean Christopherson <seanjc@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	kvm-riscv@lists.infradead.org,  pbonzini@redhat.com,
	borntraeger@linux.ibm.com, frankja@linux.ibm.com,
	 imbrenda@linux.ibm.com, anup@brainfault.org,
	atish.patra@linux.dev,  zhaotianrui@loongson.cn,
	maobibo@loongson.cn, chenhuacai@kernel.org,  maz@kernel.org,
	oliver.upton@linux.dev, ajones@ventanamicro.com
Subject: Re: [PATCH v4 6/9] KVM: selftests: Add various print flags to KVM selftest runner
Date: Wed, 29 Jul 2026 12:14:24 -0700	[thread overview]
Message-ID: <ampREGtEqKh8_-Ua@google.com> (raw)
In-Reply-To: <20260331194202.1722082-7-vipinsh@google.com>

On Tue, Mar 31, 2026, Vipin Sharma wrote:
> @@ -27,10 +34,14 @@ class TestRunner:
>          return test
>  
>      def _log_result(self, test_result):
> -        logger.info("*** stdout ***\n" + test_result.stdout)
> -        logger.info("*** stderr ***\n" + test_result.stderr)
> -        logger.log(test_result.status,
> -                   f"[{test_result.status.name}] {test_result.test_path}")
> +        print_level = self.print_stds.get(test_result.status, "full")
> +
> +        if (print_level == "full" or print_level == "stdout"):
> +            logger.info("*** stdout ***\n" + test_result.stdout)

IMO, when the print_level is exactly stdout or stderr, the runner shouldn't spit
out the "*** std{out,err} ***" line, as it's pure noise.  E.g.

        print("\033[2K", end="\r", flush=True)
        if (print_level == "full"):
            logger.info("*** stdout ***\n" + test_result.stdout)
            logger.info("*** stderr ***\n" + test_result.stderr)
        elif (print_level == "stdout"):
            logger.info(test_result.stdout)
        elif (print_level == "stderr"):
            logger.info(test_result.stderr)

> +        if (print_level == "full" or print_level == "stderr"):
> +            logger.info("*** stderr ***\n" + test_result.stderr)
> +        if (print_level != "off"):
> +            logger.log(test_result.status, f"[{test_result.status.name}] {test_result.test_path}")
>  
>      def start(self):
>          ret = 0
> -- 
> 2.53.0.1118.gaef5881109-goog
> 

-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv