From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Kanchan Joshi <joshi.k@samsung.com>,
Guixin Liu <kanie@linux.alibaba.com>,
Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>,
Nilay Shroff <nilay@linux.ibm.com>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/4] nvme: clamp FDP placement handle count to the buffer size
Date: Thu, 30 Jul 2026 06:41:01 -0600 [thread overview]
Message-ID: <amtGXbjK7Vticrnq@kbusch-mbp> (raw)
In-Reply-To: <20260730113722.GD25454@lst.de>
On Thu, Jul 30, 2026 at 01:37:22PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 30, 2026 at 03:10:59PM +0530, Kanchan Joshi wrote:
> > But I feel the need to improve (what we have) with a follow-up patch:
> > 1. Revise the cap, from S8_MAX - 1 to U8_MAX; since bio->bi_write_hint
> > is u8.
>
> Signed 8-bit -1 is indeed a really odd value, and from looking at the
> original commit I'm not really sure how we arrived there.
"S8_MAX - 1" is a weird way to represent it, but the reason that value
was used (and it's admittedly not a good reason) was that the result
fits in a page. Not that there's any restriction on admin commands using
PRP lists; it's just a coincidental limit for all the driver initiated
admin commands.
next prev parent reply other threads:[~2026-07-30 12:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 4:31 [PATCH 0/4] nvme: a few error-path and validation fixes Guixin Liu
2026-07-30 4:31 ` [PATCH 1/4] nvmet: fix NULL pointer dereference in nvmet_execute_identify_nslist() Guixin Liu
2026-07-30 8:22 ` Hannes Reinecke
2026-07-30 11:34 ` Christoph Hellwig
2026-07-30 12:06 ` Nilay Shroff
2026-07-30 4:31 ` [PATCH 2/4] nvmet: propagate percpu_ref_init() failure in nvmet_ns_enable() Guixin Liu
2026-07-30 8:23 ` Hannes Reinecke
2026-07-30 11:38 ` Christoph Hellwig
2026-07-30 12:06 ` Nilay Shroff
2026-07-30 4:31 ` [PATCH 3/4] nvme-pci: release descriptor pools on probe failure Guixin Liu
2026-07-30 8:23 ` Hannes Reinecke
2026-07-30 11:34 ` Christoph Hellwig
2026-07-30 11:49 ` Kanchan Joshi
2026-07-30 12:07 ` Nilay Shroff
2026-07-30 4:31 ` [PATCH 4/4] nvme: clamp FDP placement handle count to the buffer size Guixin Liu
2026-07-30 8:24 ` Hannes Reinecke
2026-07-30 9:40 ` Kanchan Joshi
2026-07-30 11:37 ` Christoph Hellwig
2026-07-30 12:41 ` Keith Busch [this message]
2026-07-30 11:36 ` Christoph Hellwig
2026-07-30 12:08 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amtGXbjK7Vticrnq@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kanie@linux.alibaba.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.