From: Nilay Shroff <nilay@linux.ibm.com>
To: Guixin Liu <kanie@linux.alibaba.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>
Cc: linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/4] nvmet: fix NULL pointer dereference in nvmet_execute_identify_nslist()
Date: Thu, 30 Jul 2026 17:36:14 +0530 [thread overview]
Message-ID: <fae37aaf-e867-4984-bf62-7422104ad229@linux.ibm.com> (raw)
In-Reply-To: <20260730043105.3071328-2-kanie@linux.alibaba.com>
On 7/30/26 10:01 AM, Guixin Liu wrote:
> When a host issues an Identify command with CNS 07h (Active Namespace ID
> List for a specific I/O Command Set), nvmet_execute_identify_nslist() is
> called with match_css set. The command-set filter dereferences req->ns,
> but this handler never calls nvmet_req_find_ns(), so req->ns is always
> NULL (nvmet_req_init() resets it to NULL). As soon as an enabled
> namespace with an NSID greater than the requested value exists,
> req->ns->csi dereferences a NULL pointer and oopses.
>
> Besides the crash, the comparison is logically wrong: to filter the list
> by command set it must test the command set of the namespace being
> iterated, not a single fixed value. Use the loop variable ns->csi.
>
> Fixes: 61c9967cd634 ("nvmet: implement active command set ns list")
> Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Looks good to me.
Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
next prev parent reply other threads:[~2026-07-30 12:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 4:31 [PATCH 0/4] nvme: a few error-path and validation fixes Guixin Liu
2026-07-30 4:31 ` [PATCH 1/4] nvmet: fix NULL pointer dereference in nvmet_execute_identify_nslist() Guixin Liu
2026-07-30 8:22 ` Hannes Reinecke
2026-07-30 11:34 ` Christoph Hellwig
2026-07-30 12:06 ` Nilay Shroff [this message]
2026-07-30 4:31 ` [PATCH 2/4] nvmet: propagate percpu_ref_init() failure in nvmet_ns_enable() Guixin Liu
2026-07-30 8:23 ` Hannes Reinecke
2026-07-30 11:38 ` Christoph Hellwig
2026-07-30 12:06 ` Nilay Shroff
2026-07-30 4:31 ` [PATCH 3/4] nvme-pci: release descriptor pools on probe failure Guixin Liu
2026-07-30 8:23 ` Hannes Reinecke
2026-07-30 11:34 ` Christoph Hellwig
2026-07-30 11:49 ` Kanchan Joshi
2026-07-30 12:07 ` Nilay Shroff
2026-07-30 4:31 ` [PATCH 4/4] nvme: clamp FDP placement handle count to the buffer size Guixin Liu
2026-07-30 8:24 ` Hannes Reinecke
2026-07-30 9:40 ` Kanchan Joshi
2026-07-30 11:37 ` Christoph Hellwig
2026-07-30 12:41 ` Keith Busch
2026-07-30 11:36 ` Christoph Hellwig
2026-07-30 12:08 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fae37aaf-e867-4984-bf62-7422104ad229@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.