* [PATCH] scsi: qla2xxx: Fix an error code in qla_get_tmf()
@ 2026-08-13 7:08 Dan Carpenter
2026-08-24 1:46 ` Martin K. Petersen (Oracle)
2026-08-26 15:20 ` Martin K. Petersen (Oracle)
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2026-08-13 7:08 UTC (permalink / raw)
To: Nilesh Javali
Cc: GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel, kernel-janitors
Negative -EIO was intended instead of positive EIO. The caller, doesn't
care so this doesn't affect runtime. It's just a cleanup.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
drivers/scsi/qla2xxx/qla_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 2b9a9c672ec6..0c4e8ce9decf 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -2302,7 +2302,7 @@ int qla_get_tmf(struct tmf_arg *arg)
if (TMF_NOT_READY(fcport)) {
ql_log(ql_log_warn, vha, 0x802c,
"Unable to acquire TM resource due to disruption.\n");
- rc = EIO;
+ rc = -EIO;
break;
}
if (ha->active_tmf < MAX_ACTIVE_TMF &&
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: qla2xxx: Fix an error code in qla_get_tmf()
2026-08-13 7:08 [PATCH] scsi: qla2xxx: Fix an error code in qla_get_tmf() Dan Carpenter
@ 2026-08-24 1:46 ` Martin K. Petersen (Oracle)
2026-08-26 15:20 ` Martin K. Petersen (Oracle)
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-08-24 1:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Nilesh Javali, GR-QLogic-Storage-Upstream, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel, kernel-janitors
Dan,
> Negative -EIO was intended instead of positive EIO. The caller,
> doesn't care so this doesn't affect runtime. It's just a cleanup.
Applied to 7.3/scsi-staging, thanks!
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix an error code in qla_get_tmf()
2026-08-13 7:08 [PATCH] scsi: qla2xxx: Fix an error code in qla_get_tmf() Dan Carpenter
2026-08-24 1:46 ` Martin K. Petersen (Oracle)
@ 2026-08-26 15:20 ` Martin K. Petersen (Oracle)
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen (Oracle) @ 2026-08-26 15:20 UTC (permalink / raw)
To: Nilesh Javali, Dan Carpenter
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream,
James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors
On Thu, 13 Aug 2026 10:08:27 +0300, Dan Carpenter wrote:
> Negative -EIO was intended instead of positive EIO. The caller, doesn't
> care so this doesn't affect runtime. It's just a cleanup.
Applied to 7.3/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix an error code in qla_get_tmf()
https://git.kernel.org/mkp/scsi/c/ff9365a4c999
--
Martin K. Petersen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-26 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13 7:08 [PATCH] scsi: qla2xxx: Fix an error code in qla_get_tmf() Dan Carpenter
2026-08-24 1:46 ` Martin K. Petersen (Oracle)
2026-08-26 15:20 ` Martin K. Petersen (Oracle)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.