* [bug report] drm/rockchip: dw_hdmi: Propagate bus format to display driver
@ 2026-08-13 7:08 Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-08-13 7:08 UTC (permalink / raw)
To: Jonas Karlman; +Cc: linux-rockchip
Hello Jonas Karlman,
Commit dc70272cc184 ("drm/rockchip: dw_hdmi: Propagate bus format to
display driver") from May 18, 2026 (linux-next), leads to the
following Smatch static checker warning:
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:292 dw_hdmi_rockchip_get_bus_format()
error: 'bridge_state' dereferencing possible ERR_PTR()
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
278 static u32 dw_hdmi_rockchip_get_bus_format(struct drm_encoder *encoder,
279 struct drm_connector_state *conn_state)
280 {
281 struct drm_bridge *bridge __free(drm_bridge_put) = NULL;
282 struct drm_bridge_state *bridge_state;
283
284 bridge = drm_bridge_chain_get_first_bridge(encoder);
285 if (!bridge)
286 return 0;
287
288 bridge_state = drm_atomic_get_bridge_state(conn_state->state, bridge);
289 if (!bridge_state)
This should be if (IS_ERR(bridge_state)).
290 return 0;
291
--> 292 if (bridge_state->input_bus_cfg.format != MEDIA_BUS_FMT_FIXED)
293 return bridge_state->input_bus_cfg.format;
294
295 return bridge_state->output_bus_cfg.format;
296 }
This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug report] drm/rockchip: dw_hdmi: Propagate bus format to display driver
@ 2026-07-10 10:04 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-07-10 10:04 UTC (permalink / raw)
To: Jonas Karlman; +Cc: dri-devel, linux-rockchip
Hello Jonas Karlman,
Commit dc70272cc184 ("drm/rockchip: dw_hdmi: Propagate bus format to
display driver") from May 18, 2026 (linux-next), leads to the
following Smatch static checker warning:
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:289 dw_hdmi_rockchip_get_bus_format()
warn: 'bridge_state' is an error pointer or valid
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
278 static u32 dw_hdmi_rockchip_get_bus_format(struct drm_encoder *encoder,
279 struct drm_connector_state *conn_state)
280 {
281 struct drm_bridge *bridge __free(drm_bridge_put) = NULL;
282 struct drm_bridge_state *bridge_state;
283
284 bridge = drm_bridge_chain_get_first_bridge(encoder);
285 if (!bridge)
286 return 0;
287
288 bridge_state = drm_atomic_get_bridge_state(conn_state->state, bridge);
--> 289 if (!bridge_state)
drm_atomic_get_bridge_state() never returns NULL, only error pointers.
290 return 0;
291
292 if (bridge_state->input_bus_cfg.format != MEDIA_BUS_FMT_FIXED)
293 return bridge_state->input_bus_cfg.format;
294
295 return bridge_state->output_bus_cfg.format;
296 }
This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug report] drm/rockchip: dw_hdmi: Propagate bus format to display driver
@ 2026-07-10 10:04 ` Dan Carpenter
0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-07-10 10:04 UTC (permalink / raw)
To: Jonas Karlman; +Cc: dri-devel, linux-rockchip
Hello Jonas Karlman,
Commit dc70272cc184 ("drm/rockchip: dw_hdmi: Propagate bus format to
display driver") from May 18, 2026 (linux-next), leads to the
following Smatch static checker warning:
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:289 dw_hdmi_rockchip_get_bus_format()
warn: 'bridge_state' is an error pointer or valid
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
278 static u32 dw_hdmi_rockchip_get_bus_format(struct drm_encoder *encoder,
279 struct drm_connector_state *conn_state)
280 {
281 struct drm_bridge *bridge __free(drm_bridge_put) = NULL;
282 struct drm_bridge_state *bridge_state;
283
284 bridge = drm_bridge_chain_get_first_bridge(encoder);
285 if (!bridge)
286 return 0;
287
288 bridge_state = drm_atomic_get_bridge_state(conn_state->state, bridge);
--> 289 if (!bridge_state)
drm_atomic_get_bridge_state() never returns NULL, only error pointers.
290 return 0;
291
292 if (bridge_state->input_bus_cfg.format != MEDIA_BUS_FMT_FIXED)
293 return bridge_state->input_bus_cfg.format;
294
295 return bridge_state->output_bus_cfg.format;
296 }
This email is a free service from the Smatch-CI project [smatch.sf.net].
regards,
dan carpenter
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [bug report] drm/rockchip: dw_hdmi: Propagate bus format to display driver
2026-07-10 10:04 ` Dan Carpenter
@ 2026-07-10 10:09 ` Jonas Karlman
-1 siblings, 0 replies; 5+ messages in thread
From: Jonas Karlman @ 2026-07-10 10:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: dri-devel, linux-rockchip
Hi Dan,
On 7/10/2026 12:04 PM, Dan Carpenter wrote:
> Hello Jonas Karlman,
>
> Commit dc70272cc184 ("drm/rockchip: dw_hdmi: Propagate bus format to
> display driver") from May 18, 2026 (linux-next), leads to the
> following Smatch static checker warning:
>
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:289 dw_hdmi_rockchip_get_bus_format()
> warn: 'bridge_state' is an error pointer or valid
>
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> 278 static u32 dw_hdmi_rockchip_get_bus_format(struct drm_encoder *encoder,
> 279 struct drm_connector_state *conn_state)
> 280 {
> 281 struct drm_bridge *bridge __free(drm_bridge_put) = NULL;
> 282 struct drm_bridge_state *bridge_state;
> 283
> 284 bridge = drm_bridge_chain_get_first_bridge(encoder);
> 285 if (!bridge)
> 286 return 0;
> 287
> 288 bridge_state = drm_atomic_get_bridge_state(conn_state->state, bridge);
> --> 289 if (!bridge_state)
>
> drm_atomic_get_bridge_state() never returns NULL, only error pointers.
This issue has already been addressed in the patch "drm/rockchip:
dw_hdmi: Fix error handling for drm_atomic_get_bridge_state()" at [1].
[1] https://patch.msgid.link/20260701030835.2662123-1-nichen@iscas.ac.cn/
Regards,
Jonas
>
> 290 return 0;
> 291
> 292 if (bridge_state->input_bus_cfg.format != MEDIA_BUS_FMT_FIXED)
> 293 return bridge_state->input_bus_cfg.format;
> 294
> 295 return bridge_state->output_bus_cfg.format;
> 296 }
>
> This email is a free service from the Smatch-CI project [smatch.sf.net].
>
> regards,
> dan carpenter
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [bug report] drm/rockchip: dw_hdmi: Propagate bus format to display driver
@ 2026-07-10 10:09 ` Jonas Karlman
0 siblings, 0 replies; 5+ messages in thread
From: Jonas Karlman @ 2026-07-10 10:09 UTC (permalink / raw)
To: Dan Carpenter; +Cc: dri-devel, linux-rockchip
Hi Dan,
On 7/10/2026 12:04 PM, Dan Carpenter wrote:
> Hello Jonas Karlman,
>
> Commit dc70272cc184 ("drm/rockchip: dw_hdmi: Propagate bus format to
> display driver") from May 18, 2026 (linux-next), leads to the
> following Smatch static checker warning:
>
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c:289 dw_hdmi_rockchip_get_bus_format()
> warn: 'bridge_state' is an error pointer or valid
>
> drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
> 278 static u32 dw_hdmi_rockchip_get_bus_format(struct drm_encoder *encoder,
> 279 struct drm_connector_state *conn_state)
> 280 {
> 281 struct drm_bridge *bridge __free(drm_bridge_put) = NULL;
> 282 struct drm_bridge_state *bridge_state;
> 283
> 284 bridge = drm_bridge_chain_get_first_bridge(encoder);
> 285 if (!bridge)
> 286 return 0;
> 287
> 288 bridge_state = drm_atomic_get_bridge_state(conn_state->state, bridge);
> --> 289 if (!bridge_state)
>
> drm_atomic_get_bridge_state() never returns NULL, only error pointers.
This issue has already been addressed in the patch "drm/rockchip:
dw_hdmi: Fix error handling for drm_atomic_get_bridge_state()" at [1].
[1] https://patch.msgid.link/20260701030835.2662123-1-nichen@iscas.ac.cn/
Regards,
Jonas
>
> 290 return 0;
> 291
> 292 if (bridge_state->input_bus_cfg.format != MEDIA_BUS_FMT_FIXED)
> 293 return bridge_state->input_bus_cfg.format;
> 294
> 295 return bridge_state->output_bus_cfg.format;
> 296 }
>
> This email is a free service from the Smatch-CI project [smatch.sf.net].
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-08-13 7:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13 7:08 [bug report] drm/rockchip: dw_hdmi: Propagate bus format to display driver Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-07-10 10:04 Dan Carpenter
2026-07-10 10:04 ` Dan Carpenter
2026-07-10 10:09 ` Jonas Karlman
2026-07-10 10:09 ` Jonas Karlman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.