* [MINI-OS PATCH] build: don't add -lm -lpci -lz to APP_LDLIBS
@ 2026-08-13 14:35 Juergen Gross
2026-08-13 21:18 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2026-08-13 14:35 UTC (permalink / raw)
To: minios-devel, xen-devel; +Cc: samuel.thibault, Juergen Gross
libm, libpci and libz are not always needed, so don't add them to
APP_LDLIBS just because libc is selected.
In case they will be needed by someone, they should be added via a
dedicated CONFIG option.
Note that none of the currently supported Xen stubdoms is using them.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Makefile b/Makefile
index a64913a..7510d5d 100644
--- a/Makefile
+++ b/Makefile
@@ -164,9 +164,6 @@ ifeq ($(CONFIG_LIBXENMANAGE),y)
APP_LDLIBS += -L$(MANAGE_PATH) -whole-archive -lxenmanage -no-whole-archive
LIBS += $(MANAGE_PATH)/libxenmanage.a
endif
-APP_LDLIBS += -lpci
-APP_LDLIBS += -lz
-APP_LDLIBS += -lm
LDLIBS += -lc
endif
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [MINI-OS PATCH] build: don't add -lm -lpci -lz to APP_LDLIBS
2026-08-13 14:35 [MINI-OS PATCH] build: don't add -lm -lpci -lz to APP_LDLIBS Juergen Gross
@ 2026-08-13 21:18 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2026-08-13 21:18 UTC (permalink / raw)
To: Juergen Gross; +Cc: minios-devel, xen-devel
Juergen Gross, le jeu. 13 août 2026 16:35:36 +0200, a ecrit:
> libm, libpci and libz are not always needed, so don't add them to
> APP_LDLIBS just because libc is selected.
>
> In case they will be needed by someone, they should be added via a
> dedicated CONFIG option.
>
> Note that none of the currently supported Xen stubdoms is using them.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Agreed,
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> Makefile | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a64913a..7510d5d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -164,9 +164,6 @@ ifeq ($(CONFIG_LIBXENMANAGE),y)
> APP_LDLIBS += -L$(MANAGE_PATH) -whole-archive -lxenmanage -no-whole-archive
> LIBS += $(MANAGE_PATH)/libxenmanage.a
> endif
> -APP_LDLIBS += -lpci
> -APP_LDLIBS += -lz
> -APP_LDLIBS += -lm
> LDLIBS += -lc
> endif
>
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-13 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-13 14:35 [MINI-OS PATCH] build: don't add -lm -lpci -lz to APP_LDLIBS Juergen Gross
2026-08-13 21:18 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.