[PATCH] staging: rtl8723bs: fix XXX placeholder in os_intfs.c comment

[PATCH] staging: rtl8723bs: fix XXX placeholder in os_intfs.c comment

[Tomasz Unger]

Replace the 'XXX' placeholder with 'securitypriv', the actual
field name referenced by the commented-out memset() call on the
following line.

Using the real field name pushes the line past 100 columns, so
the comment is reflowed to multi-line style in the same change
to keep it clean. This combines a content fix with a formatting
change; I considered splitting it into two patches (content
first, reflow second) but felt the reflow is a direct and
unavoidable consequence of the content fix rather than an
unrelated cleanup. Happy to split into two patches if preferred.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54b3e..873e00a04bcb 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -664,7 +664,10 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
 	/*  add for CONFIG_IEEE80211W, none 11w also can use */
 	spin_lock_init(&padapter->security_key_mutex);
 
-	/*  We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
+	/*
+	 * We don't need to memset padapter->securitypriv to zero,
+	 * because adapter is allocated by vzalloc().
+	 */
 	/* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */
 
 	if (_rtw_init_sta_priv(&padapter->stapriv) == _FAIL)

---
base-commit: db2ddb87143519e20a95aa36c60b36107b736a58
change-id: 20260813-rtl8723bs-fix-xxx-placeholder-v2-ae6b6c9a69c1

Best regards,
--  
Tomasz Unger <tomasz.unger@yahoo.pl>

Re: [PATCH] staging: rtl8723bs: fix XXX placeholder in os_intfs.c comment

[Dan Carpenter]

On Thu, Aug 13, 2026 at 07:26:52PM +0200, Tomasz Unger wrote:
> Replace the 'XXX' placeholder with 'securitypriv', the actual
> field name referenced by the commented-out memset() call on the
> following line.
> 
> Using the real field name pushes the line past 100 columns, so
> the comment is reflowed to multi-line style in the same change
> to keep it clean. This combines a content fix with a formatting
> change; I considered splitting it into two patches (content
> first, reflow second) but felt the reflow is a direct and
> unavoidable consequence of the content fix rather than an
> unrelated cleanup. Happy to split into two patches if preferred.

Put this kind of meta commentary under the --- cut off line

> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
  ^^^
here.

>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index f31196f54b3e..873e00a04bcb 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -664,7 +664,10 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
>  	/*  add for CONFIG_IEEE80211W, none 11w also can use */
>  	spin_lock_init(&padapter->security_key_mutex);
>  
> -	/*  We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
> +	/*
> +	 * We don't need to memset padapter->securitypriv to zero,
> +	 * because adapter is allocated by vzalloc().
> +	 */
>  	/* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */

Just delete the comment and the commented out code.

regards,
dan carpenter