All of lore.kernel.org
 help / color / mirror / Atom feed
From: Weijie Yuan <wy@wyuan.org>
To: Tilak Raaz <raaztilak07@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [GSoC PATCH] submodule: warn on valueless active config
Date: Sat, 15 Aug 2026 01:56:49 +0800	[thread overview]
Message-ID: <an9W4XwY8X4ZFHpA@wyuan.org> (raw)
In-Reply-To: <CABB4Jh3UUXvmAJpefaiP-xVRQfGRdTF2jW8GkdhbA1BXe6Okdw@mail.gmail.com>

On Fri, Aug 14, 2026 at 11:07:29PM +0530, Tilak Raaz wrote:
> Hi everyone,
> 
> My name is Tilak  (he/him), and I am a second-year Electronics and
> Instrumentation Engineering student at NIT Rourkela. I am preparing to
> apply for GSoC 2027 and am starting my contributions to Git.
> 
> Regarding my background with Git: I have built Git from source,
> successfully
> navigated the codebase, and tackled the NEEDSWORK comment regarding
> valueless 'submodule.active' configurations in submodule.c.
> 
> Below is my microproject patch resolving this issue by switching from
> repo_config_get_string_multi() to repo_config_get_value_multi() and
> adding an automated test case in t7400-submodule-basic.sh.
> 
> I look forward to your feedback!

Thanks!

However, my suggestion is that it would be better to place your patch in
the main body of the email text rather than in the attachment.
Please take a look at Documentation/SubmittingPatches [[attachment]]

And it also seems that the automated program 'b4' is unable to recognize
your patch, which may make the development process less convenient for
the developers and the maintainer.

$ b4 am https://lore.kernel.org/git/CABB4Jh3UUXvmAJpefaiP-xVRQfGRdTF2jW8GkdhbA1BXe6Okdw@mail.gmail.com/
Looking up CABB4Jh3UUXvmAJpefaiP-xVRQfGRdTF2jW8GkdhbA1BXe6Okdw@mail.gmail.com
Analyzing 1 messages in the thread
No patches found.

Please correct me if I'm wrong.

Thanks.

  reply	other threads:[~2026-08-14 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 17:37 [GSoC PATCH] submodule: warn on valueless active config Tilak Raaz
2026-08-14 17:56 ` Weijie Yuan [this message]
2026-08-14 18:04   ` Tilak Raaz
2026-08-14 19:07     ` D. Ben Knoble
2026-08-14 19:14     ` Junio C Hamano
2026-08-14 21:24 ` [GSoC PATCH v2] " tilak-raaz
2026-08-14 22:04   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an9W4XwY8X4ZFHpA@wyuan.org \
    --to=wy@wyuan.org \
    --cc=git@vger.kernel.org \
    --cc=raaztilak07@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.