All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tilak Raaz <raaztilak07@gmail.com>
Cc: Weijie Yuan <wy@wyuan.org>,  git@vger.kernel.org
Subject: Re: [GSoC PATCH] submodule: warn on valueless active config
Date: Fri, 14 Aug 2026 12:14:03 -0700	[thread overview]
Message-ID: <xmqqecg0ms5g.fsf@gitster.g> (raw)
In-Reply-To: <CABB4Jh1fUXKNn483FjD2S6U4cYVMEP6z+fjWMi8XRT+NQdNnYw@mail.gmail.com> (Tilak Raaz's message of "Fri, 14 Aug 2026 23:34:54 +0530")

Tilak Raaz <raaztilak07@gmail.com> writes:

> The config parser previously threw a hard error if 'submodule.active'
> was provided without a value, causing commands to abort.

The standard helper to use is config_error_nonbool() when you need
to report a section.variable defined this way

	[section]
		variable

without "= value", and section.variable cannot be a Boolean true.

The patch seems to be heavily whitespace damaged, and cannot be
used, though.

Thanks.

  parent reply	other threads:[~2026-08-14 19:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 17:37 [GSoC PATCH] submodule: warn on valueless active config Tilak Raaz
2026-08-14 17:56 ` Weijie Yuan
2026-08-14 18:04   ` Tilak Raaz
2026-08-14 19:07     ` D. Ben Knoble
2026-08-14 19:14     ` Junio C Hamano [this message]
2026-08-14 21:24 ` [GSoC PATCH v2] " tilak-raaz
2026-08-14 22:04   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqecg0ms5g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=raaztilak07@gmail.com \
    --cc=wy@wyuan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.