Re: [PATCH v4 2/4] man/man5/tunables.conf: Document system-wide tunables config

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]

Hi DJ,

> Date: 2026-08-03 15:21:31-0400
> From: DJ Delorie <dj@redhat.com>
>
> 
> Signed-off-by: DJ Delorie <dj@redhat.com>

A few minor comments below.

> 
> ---
>  man/man5/tunables.conf.5 | 132 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 132 insertions(+)
>  create mode 100644 man/man5/tunables.conf.5
> 
> diff --git a/man/man5/tunables.conf.5 b/man/man5/tunables.conf.5
> new file mode 100644
> index 000000000..44b32d40c
> --- /dev/null
> +++ b/man/man5/tunables.conf.5
> @@ -0,0 +1,132 @@
[...]
> +.P
> +The file may also contain
> +.IR filters ,
> +which limit the tunables following it,
> +up to the end of the file
> +(or end of the included file,
> +or start of a new included file)

I'd append within the parentheses:
	, whichever comes first

> +or a line with only
> +.B []
> +on it.

So, this is like an end-all-filters directive, right?

I wonder something: Does a filter end previous filters, or do they
compound until a [] ends them all?

> +The syntax is:
> +.P
> +.in +4n
> +.EX
> +.RI [ filter : pattern ]

Since '[', ':', and ']' are literal, let's put them in bold.  Thus, BI.


Have a lovely day!
Alex

> +.EE
> +.in
> +.TP
> +.B proc
> +The
> +.B proc
> +filter limits the following tunables to processes
> +whose name matches the pattern.
> +The pattern may be an absolute path
> +or just the base name.
> +.SH FILES
> +.TP
> +.I /etc/tunables.conf
> +.TP
> +.I /etc/ld.so.cache
> +cached copy of tunables
> +.SH EXAMPLES
> +Example configuration file:
> +.P
> +.in +4n
> +.EX
> +glibc.malloc.arenas_max=5
> +onlysecure glibc.malloc.arenas_max=1
> +\-glibc.pthread.rseq=1
> +[proc:/bin/bad.program]
> +\-glibc.pthread.rseq=0
> +[proc:some.program]
> +\-glibc.malloc.mmap_threshold=65536
> +.EE
> +.in
> +.SH SEE ALSO
> +.BR ld.so (8),
> +.BR ldconfig (8)
> -- 
> 2.47.3
> 
> 

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]