Re: [PATCH v6 3/7] drm/display: Add soft depend for aux-hpd-typec-dp-bridge module

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Chaoyi Chen <kernel@airkyi.com>
Cc: "Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Robert Foss" <rfoss@kernel.org>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
	"Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>,
	"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-phy@lists.infradead.org
Subject: Re: [PATCH v6 3/7] drm/display: Add soft depend for aux-hpd-typec-dp-bridge module
Date: Thu, 6 Aug 2026 20:01:13 +0200	[thread overview]
Message-ID: <anTLpHm_bIPSsdvz@venus> (raw)
In-Reply-To: <20260804070730.68-4-kernel@airkyi.com>

[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]

Hi,

On Tue, Aug 04, 2026 at 03:07:26PM +0800, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> 
> The aux-hpd-typec-dp-bridge module serves as a generic TypeC
> DisplayPort HPD bridge and is not required by any other
> module. Therefore, it will not be auto-loaded.
> 
> Given that the drm_display_helper module houses DisplayPort-related
> helper code, add a MODULE_SOFTDEP() within it to suggest loading the
> aux-hpd-typec-dp-bridge module beforehand.
> 
> Suggested-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Tested-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Booting defconfig without manual HPD bridge registration works now :)

Greetings,

-- Sebastian

> 
> (no changes since v6)
> 
> ---
>  drivers/gpu/drm/display/drm_display_helper_mod.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/display/drm_display_helper_mod.c b/drivers/gpu/drm/display/drm_display_helper_mod.c
> index d8a6e6228773..f0152d6b0b2d 100644
> --- a/drivers/gpu/drm/display/drm_display_helper_mod.c
> +++ b/drivers/gpu/drm/display/drm_display_helper_mod.c
> @@ -18,5 +18,6 @@ static void __exit drm_display_helper_module_exit(void)
>  	drm_dp_aux_dev_exit();
>  }
>  
> +MODULE_SOFTDEP("pre: aux-hpd-typec-dp-bridge");
>  module_init(drm_display_helper_module_init);
>  module_exit(drm_display_helper_module_exit);
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]