* [PATCH] ipmi: Fix leak in __ipmi_bmc_register
@ 2026-08-06 22:30 Michail Tatas
2026-08-06 23:56 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Michail Tatas @ 2026-08-06 22:30 UTC (permalink / raw)
To: corey; +Cc: openipmi-developer, linux-kernel
In case that ida_alloc(&ipmi_bmc_ida,...) succeeds and then
platform_device_register() fails, ipmi_bmc_ida is leaked.
Fix by freeing the error path
Signed-off-by: Michail Tatas <michail.tatas@gmail.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 6ff9a15cced8..7634dff99f41 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -3301,6 +3301,7 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf,
list_del(&intf->bmc_link);
mutex_unlock(&bmc->dyn_mutex);
intf->bmc = &intf->tmp_bmc;
+ ida_free(&ipmi_bmc_ida, bmc->pdev.id);
put_device(&bmc->pdev.dev);
goto out;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: Fix leak in __ipmi_bmc_register
2026-08-06 22:30 [PATCH] ipmi: Fix leak in __ipmi_bmc_register Michail Tatas
@ 2026-08-06 23:56 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2026-08-06 23:56 UTC (permalink / raw)
To: Michail Tatas; +Cc: openipmi-developer, linux-kernel
On Fri, Aug 07, 2026 at 01:30:20AM +0300, Michail Tatas wrote:
> In case that ida_alloc(&ipmi_bmc_ida,...) succeeds and then
> platform_device_register() fails, ipmi_bmc_ida is leaked.
> Fix by freeing the error path
You are correct, added to my next tree. Thank you.
-corey
>
> Signed-off-by: Michail Tatas <michail.tatas@gmail.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 6ff9a15cced8..7634dff99f41 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -3301,6 +3301,7 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf,
> list_del(&intf->bmc_link);
> mutex_unlock(&bmc->dyn_mutex);
> intf->bmc = &intf->tmp_bmc;
> + ida_free(&ipmi_bmc_ida, bmc->pdev.id);
> put_device(&bmc->pdev.dev);
> goto out;
> }
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-06 23:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-06 22:30 [PATCH] ipmi: Fix leak in __ipmi_bmc_register Michail Tatas
2026-08-06 23:56 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.