All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörn Engel" <joern@barelysecure.org>
To: syzbot <syzbot+b320a4d5f65a61dbbf89@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com, richard@nod.at,
	syzkaller-bugs@googlegroups.com, vigneshr@ti.com,
	Fabian Frederick <fabf@skynet.be>
Subject: Re: [syzbot] [mtd?] divide error in block2mtd_setup2
Date: Mon, 10 Aug 2026 09:27:03 -0700	[thread overview]
Message-ID: <ann719YIqopUBCv5@cashel.logfs.org> (raw)
In-Reply-To: <ankxaiwtTltL0xMj@cashel.logfs.org>

On Sun, Aug 09, 2026 at 07:03:22PM -0700, Jörn Engel wrote:
> 
> Best guess would be this:
> 
> 	if ((long)size % erase_size) {

While at it, what purpose does the cast to (long) serve?

As far as I can see, it is useless and should be removed.  Fabian, do
you remember why it was necessary?

Jörn

--
The real voyage of discovery consists not in seeking new landscapes,
but in having new eyes.
-- Marcel Proust

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Jörn Engel" <joern@barelysecure.org>
To: syzbot <syzbot+b320a4d5f65a61dbbf89@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
	miquel.raynal@bootlin.com, richard@nod.at,
	syzkaller-bugs@googlegroups.com, vigneshr@ti.com,
	Fabian Frederick <fabf@skynet.be>
Subject: Re: [syzbot] [mtd?] divide error in block2mtd_setup2
Date: Mon, 10 Aug 2026 09:27:03 -0700	[thread overview]
Message-ID: <ann719YIqopUBCv5@cashel.logfs.org> (raw)
In-Reply-To: <ankxaiwtTltL0xMj@cashel.logfs.org>

On Sun, Aug 09, 2026 at 07:03:22PM -0700, Jörn Engel wrote:
> 
> Best guess would be this:
> 
> 	if ((long)size % erase_size) {

While at it, what purpose does the cast to (long) serve?

As far as I can see, it is useless and should be removed.  Fabian, do
you remember why it was necessary?

Jörn

--
The real voyage of discovery consists not in seeking new landscapes,
but in having new eyes.
-- Marcel Proust

  parent reply	other threads:[~2026-08-10 16:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10  0:34 [syzbot] [mtd?] divide error in block2mtd_setup2 syzbot
2026-08-10  0:34 ` syzbot
2026-08-10  2:03 ` Jörn Engel
2026-08-10  2:03   ` Jörn Engel
2026-08-10  9:17   ` Pei Xiao
2026-08-10  9:17     ` Pei Xiao
2026-08-10 12:40     ` Miquel Raynal
2026-08-10 12:40       ` Miquel Raynal
2026-08-11  3:02       ` Pei Xiao
2026-08-11  3:02         ` Pei Xiao
2026-08-10 16:27   ` Jörn Engel [this message]
2026-08-10 16:27     ` Jörn Engel
2026-08-11  1:21     ` Pei Xiao
2026-08-11  1:21       ` Pei Xiao
2026-08-10  9:12 ` [PATCH] mtd: block2mtd: Fix divide error when erase_size is zero Pei Xiao
2026-08-10  9:12   ` Pei Xiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ann719YIqopUBCv5@cashel.logfs.org \
    --to=joern@barelysecure.org \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=syzbot+b320a4d5f65a61dbbf89@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.