From: Dmitry Ilvokhin <d@ilvokhin.com>
To: Breno Leitao <leitao@debian.org>
Cc: paulmck@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
kernel-team@meta.com, Thomas Gleixner <tglx@kernel.org>
Subject: Re: [PATCH v2 1/3] locking/csd-lock: Pack csd_lock_wait_toolong() state into a struct
Date: Mon, 10 Aug 2026 14:32:48 +0000 [thread overview]
Message-ID: <annhEBmTxZcQB530@shell.ilvokhin.com> (raw)
In-Reply-To: <20260810-csd-stall-duration-v2-1-795083bf04a4@debian.org>
On Mon, Aug 10, 2026 at 04:29:24AM -0700, Breno Leitao wrote:
> csd_lock_wait_toolong() has some fields and they are being expanded now,
> separate them into a structure, that can be easily digestible.
>
> This simplify the function aslo, given the fields were passed by
> reference, and the ts0/ts1 names say nothing about what the two
> timestamps hold.
>
> Pack them into struct csd_wait_state and name the timestamps for what
> they store, ts_start and ts_report. The local ts2 becomes ts_now.
>
> Reporting a further timestamp, such as next patch, then costs a struct
> member rather than another argument.
>
> No functional change.
>
> Suggested-by: Dmitry Ilvokhin <d@ilvokhin.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com>
next prev parent reply other threads:[~2026-08-10 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 11:29 [PATCH v2 0/3] locking/csd-lock: Report how long a CSD stall lasted Breno Leitao
2026-08-10 11:29 ` [PATCH v2 1/3] locking/csd-lock: Pack csd_lock_wait_toolong() state into a struct Breno Leitao
2026-08-10 14:32 ` Dmitry Ilvokhin [this message]
2026-08-10 11:29 ` [PATCH v2 2/3] locking/csd-lock: Report how long a stuck CSD lock took to recover Breno Leitao
2026-08-10 11:29 ` [PATCH v2 3/3] lib/test_csd_lock: Add a module to stall a CPU on a CSD lock Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=annhEBmTxZcQB530@shell.ilvokhin.com \
--to=d@ilvokhin.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.