All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ACPI: scan: Avoid registering platform devices with resource overlaps
@ 2026-08-07 10:22 Rafael J. Wysocki
  2026-08-07 12:57 ` Paul Menzel
                   ` (3 more replies)
  0 siblings, 4 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2026-08-07 10:22 UTC (permalink / raw)
  To: Linux ACPI
  Cc: LKML, Andy Shevchenko, Mika Westerberg, Julien, jarkko,
	linux-integrity

From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

If acpi_dev_get_resources() returns overlapping I/O or memory resources,
the subsequent registration of a platform device will fail with -EBUSY
due to a resource conflict.  This is reported to happen on Acer Aspire
ES1-572 [1].

Avoid that by adjusting resources returned by acpi_dev_get_resources()
to eliminate partial overlaps between them.

This has not been regarded as necessary before because putting
overlapping resources into the _CRS of one device is really pointless,
but now that the issue has been reported to actually happen in the
field, it needs to be done.

Fixes: ab06eb920401 ("ACPI: scan: Register platform devices for fixed event buttons")
Reported-by: Julien <julien82453@gmail.com>
Closes: https://lore.kernel.org/linux-integrity/CAJOGg3z6LJPDsdPNBxajgy8_wQxfhYBRxe4EiurZf3kPU5A5Bw@mail.gmail.com/ [1]
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

v2 -> v3:
   * Use resource_union() and adjust code and comment (Andy)
   * Include ioport.h directly

v1 -> v2:
   * Add the expanded resource instead of and not in addition to the other
     overlapping one (Sashiko)

---
 drivers/acpi/acpi_platform.c |   39 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -12,6 +12,7 @@
 #include <linux/bits.h>
 #include <linux/device.h>
 #include <linux/err.h>
+#include <linux/ioport.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/dma-mapping.h>
@@ -71,6 +72,36 @@ static struct notifier_block acpi_platfo
 	.notifier_call = acpi_platform_device_remove_notify,
 };
 
+static unsigned int acpi_platform_adjust_resources(struct acpi_device *adev,
+						   struct resource *new_res,
+						   struct resource *resources,
+						   unsigned int count)
+{
+	unsigned int i;
+
+	if (!(new_res->flags & (IORESOURCE_IO | IORESOURCE_MEM)))
+		return count;
+
+	for (i = 0; i < count; ) {
+		struct resource *res = &resources[i];
+
+		if (resource_type(new_res) != resource_type(res) ||
+		    !resource_union(new_res, res, new_res)) {
+			i++;
+			continue;
+		}
+
+		dev_info(&adev->dev, "%pR expanded to avoid overlap\n", new_res);
+		/*
+		 * Eliminate the previously processed resource that overlapped
+		 * with the new one because it is not necessary any more.
+		 */
+		memmove(res, res + 1, (--count - i) * sizeof(*res));
+	}
+
+	return count;
+}
+
 static void acpi_platform_fill_resource(struct acpi_device *adev,
 	const struct resource *src, struct resource *dest)
 {
@@ -151,10 +182,14 @@ struct platform_device *acpi_create_plat
 				return ERR_PTR(-ENOMEM);
 			}
 			count = 0;
-			list_for_each_entry(rentry, &resource_list, node)
+			list_for_each_entry(rentry, &resource_list, node) {
+				count = acpi_platform_adjust_resources(adev,
+								       rentry->res,
+								       resources,
+								       count);
 				acpi_platform_fill_resource(adev, rentry->res,
 							    &resources[count++]);
-
+			}
 			acpi_dev_free_resource_list(&resource_list);
 		}
 	}




^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2026-08-19 19:54 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-07 10:22 [PATCH v3] ACPI: scan: Avoid registering platform devices with resource overlaps Rafael J. Wysocki
2026-08-07 12:57 ` Paul Menzel
2026-08-07 13:31   ` Rafael J. Wysocki (Intel)
2026-08-08 20:04 ` Andy Shevchenko
2026-08-10 10:41   ` Rafael J. Wysocki (Intel)
2026-08-10 15:35 ` Jarkko Sakkinen
2026-08-12 11:58   ` Rafael J. Wysocki (Intel)
2026-08-19  0:37 ` Nathan Chancellor
2026-08-19  7:46   ` Andy Shevchenko
2026-08-19 10:35     ` Rafael J. Wysocki (Intel)
2026-08-19 13:36       ` Andy Shevchenko
2026-08-19 10:18   ` Rafael J. Wysocki (Intel)
2026-08-19 11:06     ` Rafael J. Wysocki (Intel)
2026-08-19 13:55       ` Rafael J. Wysocki
2026-08-19 17:31         ` Nathan Chancellor
2026-08-19 19:00           ` Rafael J. Wysocki (Intel)
2026-08-19 19:40             ` Nathan Chancellor
2026-08-19 19:53               ` Rafael J. Wysocki (Intel)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.