All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: use -w instead of --path for man program portability
@ 2026-08-03 11:58 Anthony Iliopoulos
  2026-08-04 12:16 ` David Disseldorp
  2026-08-10 21:31 ` Zorro Lang
  0 siblings, 2 replies; 3+ messages in thread
From: Anthony Iliopoulos @ 2026-08-03 11:58 UTC (permalink / raw)
  To: fstests

Some implementations of man(1) do not support the long option --path to
display the actual location of a man page, which can cause these tests
to fail on systems using alternative man packages, such as mandoc.

Switch to using the more standard -w flag across these tests to improve
portability while maintaining the same behavior, given that the --path
option is just an alias to -w in the standard man-db utility.

Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
---
 tests/xfs/293 | 2 +-
 tests/xfs/505 | 2 +-
 tests/xfs/514 | 2 +-
 tests/xfs/515 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/xfs/293 b/tests/xfs/293
index 3e887f1c40cf..9735c441ab32 100755
--- a/tests/xfs/293
+++ b/tests/xfs/293
@@ -19,7 +19,7 @@ _require_command "$MAN_PROG" man
 
 echo "Silence is golden"
 
-MANPAGE=`$MAN_PROG --path xfs_io`
+MANPAGE=`$MAN_PROG -w xfs_io`
 
 case "$MANPAGE" in
 *.gz|*.z\|*.Z)	CAT=zcat;;
diff --git a/tests/xfs/505 b/tests/xfs/505
index 81f53ffac23d..f0f435241dda 100755
--- a/tests/xfs/505
+++ b/tests/xfs/505
@@ -16,7 +16,7 @@ _require_command "$MAN_PROG" man
 
 echo "Silence is golden"
 
-MANPAGE=$($MAN_PROG --path xfs_spaceman)
+MANPAGE=$($MAN_PROG -w xfs_spaceman)
 
 case "$MANPAGE" in
 *.gz|*.z\|*.Z)	CAT=zcat;;
diff --git a/tests/xfs/514 b/tests/xfs/514
index d3641c3e1af6..215ae5e7cc5a 100755
--- a/tests/xfs/514
+++ b/tests/xfs/514
@@ -24,7 +24,7 @@ _require_test
 
 echo "Silence is golden"
 
-MANPAGE=$($MAN_PROG --path xfs_db)
+MANPAGE=$($MAN_PROG -w xfs_db)
 
 case "$MANPAGE" in
 *.gz|*.z\|*.Z)	CAT=zcat;;
diff --git a/tests/xfs/515 b/tests/xfs/515
index 7d6e99405972..0596457e5adc 100755
--- a/tests/xfs/515
+++ b/tests/xfs/515
@@ -24,7 +24,7 @@ _require_test
 
 echo "Silence is golden"
 
-MANPAGE=$($MAN_PROG --path xfs_quota)
+MANPAGE=$($MAN_PROG -w xfs_quota)
 
 case "$MANPAGE" in
 *.gz|*.z\|*.Z)	CAT=zcat;;
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: use -w instead of --path for man program portability
  2026-08-03 11:58 [PATCH] xfs: use -w instead of --path for man program portability Anthony Iliopoulos
@ 2026-08-04 12:16 ` David Disseldorp
  2026-08-10 21:31 ` Zorro Lang
  1 sibling, 0 replies; 3+ messages in thread
From: David Disseldorp @ 2026-08-04 12:16 UTC (permalink / raw)
  To: Anthony Iliopoulos; +Cc: fstests

Looks fine.
Reviewed-by: David Disseldorp <ddiss@suse.de>

On Mon,  3 Aug 2026 13:58:19 +0200, Anthony Iliopoulos wrote:

> Some implementations of man(1) do not support the long option --path to
> display the actual location of a man page, which can cause these tests
> to fail on systems using alternative man packages, such as mandoc.
> 
> Switch to using the more standard -w flag across these tests to improve
> portability while maintaining the same behavior

The mandoc man.options.1 page seems to do a pretty good job of
tracking where the various flags appear across man utils.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] xfs: use -w instead of --path for man program portability
  2026-08-03 11:58 [PATCH] xfs: use -w instead of --path for man program portability Anthony Iliopoulos
  2026-08-04 12:16 ` David Disseldorp
@ 2026-08-10 21:31 ` Zorro Lang
  1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2026-08-10 21:31 UTC (permalink / raw)
  To: Anthony Iliopoulos; +Cc: fstests

On Mon, Aug 03, 2026 at 01:58:19PM +0200, Anthony Iliopoulos wrote:
> Some implementations of man(1) do not support the long option --path to
> display the actual location of a man page, which can cause these tests
> to fail on systems using alternative man packages, such as mandoc.
> 
> Switch to using the more standard -w flag across these tests to improve
> portability while maintaining the same behavior, given that the --path
> option is just an alias to -w in the standard man-db utility.
> 
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> ---

Looks harmless and effective,

Reviewed-by: Zorro Lang <zlang@kernel.org>

>  tests/xfs/293 | 2 +-
>  tests/xfs/505 | 2 +-
>  tests/xfs/514 | 2 +-
>  tests/xfs/515 | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/xfs/293 b/tests/xfs/293
> index 3e887f1c40cf..9735c441ab32 100755
> --- a/tests/xfs/293
> +++ b/tests/xfs/293
> @@ -19,7 +19,7 @@ _require_command "$MAN_PROG" man
>  
>  echo "Silence is golden"
>  
> -MANPAGE=`$MAN_PROG --path xfs_io`
> +MANPAGE=`$MAN_PROG -w xfs_io`
>  
>  case "$MANPAGE" in
>  *.gz|*.z\|*.Z)	CAT=zcat;;
> diff --git a/tests/xfs/505 b/tests/xfs/505
> index 81f53ffac23d..f0f435241dda 100755
> --- a/tests/xfs/505
> +++ b/tests/xfs/505
> @@ -16,7 +16,7 @@ _require_command "$MAN_PROG" man
>  
>  echo "Silence is golden"
>  
> -MANPAGE=$($MAN_PROG --path xfs_spaceman)
> +MANPAGE=$($MAN_PROG -w xfs_spaceman)
>  
>  case "$MANPAGE" in
>  *.gz|*.z\|*.Z)	CAT=zcat;;
> diff --git a/tests/xfs/514 b/tests/xfs/514
> index d3641c3e1af6..215ae5e7cc5a 100755
> --- a/tests/xfs/514
> +++ b/tests/xfs/514
> @@ -24,7 +24,7 @@ _require_test
>  
>  echo "Silence is golden"
>  
> -MANPAGE=$($MAN_PROG --path xfs_db)
> +MANPAGE=$($MAN_PROG -w xfs_db)
>  
>  case "$MANPAGE" in
>  *.gz|*.z\|*.Z)	CAT=zcat;;
> diff --git a/tests/xfs/515 b/tests/xfs/515
> index 7d6e99405972..0596457e5adc 100755
> --- a/tests/xfs/515
> +++ b/tests/xfs/515
> @@ -24,7 +24,7 @@ _require_test
>  
>  echo "Silence is golden"
>  
> -MANPAGE=$($MAN_PROG --path xfs_quota)
> +MANPAGE=$($MAN_PROG -w xfs_quota)
>  
>  case "$MANPAGE" in
>  *.gz|*.z\|*.Z)	CAT=zcat;;
> -- 
> 2.49.0
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-10 21:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 11:58 [PATCH] xfs: use -w instead of --path for man program portability Anthony Iliopoulos
2026-08-04 12:16 ` David Disseldorp
2026-08-10 21:31 ` Zorro Lang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.