Re: [PATCH v2 00/39] Make HMP optional (and later standalone)

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Aug 10, 2026 at 11:49:08PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Marc-André,
> 
> On 25/6/26 23:19, Marc-André Lureau wrote:
> > Hi,
> > 
> > This series makes HMP compile-time optional via --disable-hmp. The
> > resulting binary speaks only QMP - reducing the attack surface, binary
> > size and enforcing a separation between machine-readable interface and
> > interactive debugging console.
> > 
> > QMP offers almost all the functionality HMP could provide, so a separate
> > standalone "HMP-like" console could be implemented on top of it.
> 
> I'm in favor of the overall goal, but am reluctant to the amount of
> CONFIG_HMP #ifdef'ry added. During the last years we changed our style
> to link unreachable stubs, allowing easier code maintenance. Are we OK
> to deviate in this case?

IMHO the right long term solution is for every HMP command impl to be
moved into a separate file - many are already in separate files, just
need to finish the job. Then the condition just becomes a meson.build
rule instead of an #ifdef for everything except some code in monitor/
directory. Until that's done, I think the #ifdef's are bearable as
is.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|