[PATCH] staging: media: atomisp: Remove spaces at the start of a line

[PATCH] staging: media: atomisp: Remove spaces at the start of a line

[Diego Schild Smiths]

    Fix checkpatch.pl warnings:
    WARNING: please, no spaces at the start of a line

Signed-off-by: Diego Schild Smiths <diegossmiths@fastmail.com>

---

Hey, this is my first patch. I learned this at DebConf 26.
I appreciate any feedback. Thanks.
---
 .../isp/kernels/eed1_8/ia_css_eed1_8.host.c   | 32 ++++++++-----------
 1 file changed, 14 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c
index 76d76ca4401a..3d8e473275e0 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/eed1_8/ia_css_eed1_8.host.c
@@ -31,8 +31,8 @@ static const s16 chgrinv_x[NUMBER_OF_CHGRINV_POINTS] = {
 
 static const s16 chgrinv_a[NUMBER_OF_CHGRINV_POINTS] = {
 	-7171, -256, -29, -3456, -1071, -475, -189, -102,
-	    -48, -38, -10, -9, -7, -6, 0
-    };
+	-48, -38, -10, -9, -7, -6, 0
+};
 
 static const s16 chgrinv_b[NUMBER_OF_CHGRINV_POINTS] = {
 	8191, 1021, 256, 114, 60, 37, 24, 17,
@@ -50,7 +50,7 @@ static const s16 tcinv_x[NUMBER_OF_TCINV_POINTS] = {
 
 static const s16 tcinv_a[NUMBER_OF_TCINV_POINTS] = {
 	-6364, -631, -126, -34, -13, -6, -4452, -2156, 0
-    };
+};
 
 static const s16 tcinv_b[NUMBER_OF_TCINV_POINTS] = {
 	8191, 1828, 726, 352, 197, 121, 80, 55, 40
@@ -66,7 +66,7 @@ static const s16 fcinv_x[NUMBER_OF_FCINV_POINTS] = {
 
 static const s16 fcinv_a[NUMBER_OF_FCINV_POINTS] = {
 	-5244, -486, -86, -2849, -961, -400, -180, -86, 0
-    };
+};
 
 static const s16 fcinv_b[NUMBER_OF_FCINV_POINTS] = {
 	8191, 1637, 607, 287, 159, 98, 64, 44, 32
@@ -77,10 +77,9 @@ static const s16 fcinv_c[NUMBER_OF_FCINV_POINTS] = {
 };
 
 void
-ia_css_eed1_8_vmem_encode(
-    struct eed1_8_vmem_params *to,
-    const struct ia_css_eed1_8_config *from,
-    size_t size)
+ia_css_eed1_8_vmem_encode(struct eed1_8_vmem_params *to,
+			  const struct ia_css_eed1_8_config *from,
+			  size_t size)
 {
 	unsigned int i, j, base;
 	const unsigned int total_blocks = 4;
@@ -208,10 +207,9 @@ ia_css_eed1_8_vmem_encode(
 }
 
 void
-ia_css_eed1_8_encode(
-    struct eed1_8_dmem_params *to,
-    const struct ia_css_eed1_8_config *from,
-    size_t size)
+ia_css_eed1_8_encode(struct eed1_8_dmem_params *to,
+		     const struct ia_css_eed1_8_config *from,
+		     size_t size)
 {
 	int i;
 	int min_exp = 0;
@@ -266,18 +264,16 @@ ia_css_eed1_8_encode(
 }
 
 void
-ia_css_init_eed1_8_state(
-    void *state,
-    size_t size)
+ia_css_init_eed1_8_state(void *state,
+			 size_t size)
 {
 	memset(state, 0, size);
 }
 
 #ifndef IA_CSS_NO_DEBUG
 void
-ia_css_eed1_8_debug_dtrace(
-    const struct ia_css_eed1_8_config *eed,
-    unsigned int level)
+ia_css_eed1_8_debug_dtrace(const struct ia_css_eed1_8_config *eed,
+			   unsigned int level)
 {
 	if (!eed)
 		return;
-- 
2.55.0

Re: [PATCH] staging: media: atomisp: Remove spaces at the start of a line

[Andy Shevchenko]

On Sun, Jul 26, 2026 at 10:08:10PM -0300, Diego Schild Smiths wrote:
>     Fix checkpatch.pl warnings:
>     WARNING: please, no spaces at the start of a line

Describe the problem in plain English. Do not dump some tool output to the face
of the reader of this.

> Signed-off-by: Diego Schild Smiths <diegossmiths@fastmail.com>

While fixing indentation in the code, the Subject is wrong.

...

>  void
> -ia_css_eed1_8_vmem_encode(
> -    struct eed1_8_vmem_params *to,
> -    const struct ia_css_eed1_8_config *from,
> -    size_t size)
> +ia_css_eed1_8_vmem_encode(struct eed1_8_vmem_params *to,
> +			  const struct ia_css_eed1_8_config *from,
> +			  size_t size)

I believe there are much more of the cases.

...

Please, read lore.kernel.org linux-media@ archives against this driver to
understand why this patch is no-go.

Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.

-- 
With Best Regards,
Andy Shevchenko