[PATCH] openrisc: drop unneeded semicolon

[PATCH] openrisc: drop unneeded semicolon

[Julia Lawall]

When a function-like macro expands to an expression, that expression
doesn't need a semicolon after it.  All uses have been verified to
have their own semicolons.

This was found using the following Coccinelle semantic patch:

@r@
identifier i : script:ocaml() { String.lowercase_ascii i = i };
expression e;
@@

*#define i(...) e;

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 arch/openrisc/mm/tlb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/openrisc/mm/tlb.c b/arch/openrisc/mm/tlb.c
index 3115f2e4f..2ee00bf30 100644
--- a/arch/openrisc/mm/tlb.c
+++ b/arch/openrisc/mm/tlb.c
@@ -74,11 +74,11 @@ void local_flush_tlb_all(void)
 
 #define flush_dtlb_page_eir(addr) mtspr(SPR_DTLBEIR, addr)
 #define flush_dtlb_page_no_eir(addr) \
-	mtspr_off(SPR_DTLBMR_BASE(0), DTLB_OFFSET(addr), 0);
+	mtspr_off(SPR_DTLBMR_BASE(0), DTLB_OFFSET(addr), 0)
 
 #define flush_itlb_page_eir(addr) mtspr(SPR_ITLBEIR, addr)
 #define flush_itlb_page_no_eir(addr) \
-	mtspr_off(SPR_ITLBMR_BASE(0), ITLB_OFFSET(addr), 0);
+	mtspr_off(SPR_ITLBMR_BASE(0), ITLB_OFFSET(addr), 0)
 
 void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
 {

Re: [PATCH] openrisc: drop unneeded semicolon

[Stafford Horne]

On Sat, Aug 01, 2026 at 09:09:50PM +0200, Julia Lawall wrote:
> When a function-like macro expands to an expression, that expression
> doesn't need a semicolon after it.  All uses have been verified to
> have their own semicolons.
> 
> This was found using the following Coccinelle semantic patch:
> 
> @r@
> identifier i : script:ocaml() { String.lowercase_ascii i = i };
> expression e;
> @@
> 
> *#define i(...) e;
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Thank you, this looks fine to me.  I have queued it, sorry for delay I have been
away.

> ---
>  arch/openrisc/mm/tlb.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/openrisc/mm/tlb.c b/arch/openrisc/mm/tlb.c
> index 3115f2e4f..2ee00bf30 100644
> --- a/arch/openrisc/mm/tlb.c
> +++ b/arch/openrisc/mm/tlb.c
> @@ -74,11 +74,11 @@ void local_flush_tlb_all(void)
>  
>  #define flush_dtlb_page_eir(addr) mtspr(SPR_DTLBEIR, addr)
>  #define flush_dtlb_page_no_eir(addr) \
> -	mtspr_off(SPR_DTLBMR_BASE(0), DTLB_OFFSET(addr), 0);
> +	mtspr_off(SPR_DTLBMR_BASE(0), DTLB_OFFSET(addr), 0)
>  
>  #define flush_itlb_page_eir(addr) mtspr(SPR_ITLBEIR, addr)
>  #define flush_itlb_page_no_eir(addr) \
> -	mtspr_off(SPR_ITLBMR_BASE(0), ITLB_OFFSET(addr), 0);
> +	mtspr_off(SPR_ITLBMR_BASE(0), ITLB_OFFSET(addr), 0)
>  
>  void local_flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
>  {
>