Fixes tags need work in the drm-intel tree

Fixes tags need work in the drm-intel tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

In commit

  3b1f4d5e47b36 ("drm/amd/display: Fix dangling pointer in connector reset function")

Fixes tag

  Fixes: e7b07ceef2a6 ("drm/amd/display: Merge amdgpu_dm_crtc and dm_crtc_state")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Fixes tags need work in the drm-intel tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

In commit

  0aeed866cb938 ("drm/amd/display: Fix dangling pointer in CRTC reset function")

Fixes tag

  Fixes: e7b07ceef2a6 ("drm/amd/display: Merge amdgpu_dm_crtc and dm_crtc_state")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Fixes tags need work in the drm-intel tree

[Joonas Lahtinen]

You may want to include the repository name in the body of the message,
not just title. The full repo name would help, too.

As there's no drm-intel tree, one would assume drm-intel-next, the
below commit is not there. Seems to be from drm-misc-next.

It seems to also be drm-intel-next-fixes tree which has been reset to
equal drm/drm-next to prepare for -next-fixes PRs.

Maybe you want to only send the notification once per unique HEAD
(ignoring merges)? That'd then target the original commit and
any cherry-picks.

Regards, Joonas

Quoting Mark Brown (2026-08-18 18:42:39)
> In commit
> 
>   0aeed866cb938 ("drm/amd/display: Fix dangling pointer in CRTC reset function")
> 
> Fixes tag
> 
>   Fixes: e7b07ceef2a6 ("drm/amd/display: Merge amdgpu_dm_crtc and dm_crtc_state")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'

Re: Fixes tags need work in the drm-intel tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]

On Wed, Aug 19, 2026 at 10:09:39AM +0300, Joonas Lahtinen wrote:

> You may want to include the repository name in the body of the message,
> not just title. The full repo name would help, too.

It's whatever the tree is called in -next; I think the general hope is
that if you have included a tree that is -next you'll be aware of what
it is.  As a reminder the trees I currently have you (amost others) as a
contact for are:

   drm-intel-fixes:
       https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next-fixes

   drm-intel:
       https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next

> As there's no drm-intel tree, one would assume drm-intel-next, the
> below commit is not there. Seems to be from drm-misc-next.

> It seems to also be drm-intel-next-fixes tree which has been reset to
> equal drm/drm-next to prepare for -next-fixes PRs.

> Maybe you want to only send the notification once per unique HEAD
> (ignoring merges)? That'd then target the original commit and
> any cherry-picks.

That's what happens currently, these notifications are generated based
on checks done on the new non-mainline commits that appear in your tree
each day.

Are you sure this isn't something that you've picked up in one of your
inter-tree DRM merges?  There's a general pattern of DRM trees sending
unadressed issues to their upstream and being slow with sending the
fixes, then the same issue appearing in all the other DRM trees as you
the various DRM branches cross merge with each other.  For Fixes stuff
that's just going to happen unfortunately given that you don't rebase.
The common case here is that downstreams are sending things to their
upstreams, in general it is useful for the upstream maintainers to get
notified about issues.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]