From: Mike Rapoport <rppt@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 5/6] mm/execmem: use VM_FLUSH_RESET_PERMS for ROX cache allocations
Date: Wed, 19 Aug 2026 10:03:17 +0300 [thread overview]
Message-ID: <aoVVNXbXvWarDkSR@kernel.org> (raw)
In-Reply-To: <20260816111727.0A6521F00A3D@smtp.kernel.org>
On Sun, Aug 16, 2026 at 11:17:26AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>
> Pre-existing issues:
> - [Critical] execmem_cache_clean() calls vfree() on partial or interior chunks of a larger vmalloc allocation, causing a use-after-free for actively used regions.
> - [High] Unchecked return value of mas_store_gfp() during maple tree deletion can leave a dangling pointer in the free tree if deletion fails.
> - [Medium] Cache memory may never be freed because execmem_vmalloc() does not guarantee PMD_SIZE alignment on all architectures, preventing execmem_cache_clean() from matching its alignment checks.
Noted, will check which of those are real and address them with separate
patches.
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-08-19 7:03 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 10:59 [PATCH 0/6] arch, mm/execmem: resolve confusion about set_direct_map_valid_noflush() Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 10:59 ` [PATCH 1/6] set_memory: add number of pages parameter to set_direct_map APIs Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 11:12 ` sashiko-bot
2026-08-17 12:10 ` Brendan Jackman
2026-08-17 12:10 ` Brendan Jackman
2026-08-19 6:52 ` Mike Rapoport
2026-08-19 6:52 ` Mike Rapoport
2026-08-16 10:59 ` [PATCH 2/6] mm/vmalloc: set area's page_order after allocation succeeds Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 11:08 ` sashiko-bot
2026-08-17 17:31 ` Uladzislau Rezki
2026-08-17 17:31 ` Uladzislau Rezki
2026-08-19 6:58 ` Mike Rapoport
2026-08-19 6:58 ` Mike Rapoport
2026-08-19 11:48 ` Uladzislau Rezki
2026-08-19 11:48 ` Uladzislau Rezki
2026-08-16 10:59 ` [PATCH 3/6] mm/vmalloc: constify vm parameter of get_vm_area_page_order() Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 11:03 ` sashiko-bot
2026-08-19 11:49 ` Uladzislau Rezki
2026-08-19 11:49 ` Uladzislau Rezki
2026-08-16 10:59 ` [PATCH 4/6] mm/vmalloc: make set_area_direct_map HUGE_VMAP friendly Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 11:10 ` sashiko-bot
2026-08-17 12:21 ` Brendan Jackman
2026-08-17 12:21 ` Brendan Jackman
2026-08-19 7:01 ` Mike Rapoport
2026-08-19 7:01 ` Mike Rapoport
2026-08-16 10:59 ` [PATCH 5/6] mm/execmem: use VM_FLUSH_RESET_PERMS for ROX cache allocations Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 11:17 ` sashiko-bot
2026-08-19 7:03 ` Mike Rapoport [this message]
2026-08-16 10:59 ` [PATCH 6/6] Revert "arch: introduce set_direct_map_valid_noflush()" Mike Rapoport (Microsoft)
2026-08-16 10:59 ` Mike Rapoport (Microsoft)
2026-08-16 11:03 ` sashiko-bot
2026-08-17 15:14 ` Brendan Jackman
2026-08-17 15:14 ` Brendan Jackman
2026-08-19 7:13 ` Mike Rapoport
2026-08-19 7:13 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoVVNXbXvWarDkSR@kernel.org \
--to=rppt@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.