* [PATCH] tools: ynl: handle calloc failure in ynl_ntf_parse
@ 2026-08-18 13:27 Triet Hoang
2026-08-19 8:11 ` Hangbin Liu
0 siblings, 1 reply; 2+ messages in thread
From: Triet Hoang @ 2026-08-18 13:27 UTC (permalink / raw)
To: netdev; +Cc: donald.hunter, kuba, davem, edumazet, pabeni, horms, Triet Hoang
Check the return value of calloc() before dereferencing the allocated
response structure in ynl_ntf_parse().
Signed-off-by: Triet Hoang <triet.hoang.dev@gmail.com>
---
tools/net/ynl/lib/ynl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/net/ynl/lib/ynl.c b/tools/net/ynl/lib/ynl.c
index 2bcd781111d7..af101544c31a 100644
--- a/tools/net/ynl/lib/ynl.c
+++ b/tools/net/ynl/lib/ynl.c
@@ -889,6 +889,9 @@ static int ynl_ntf_parse(struct ynl_sock *ys, const struct nlmsghdr *nlh)
return YNL_PARSE_CB_ERROR;
rsp = calloc(1, info->alloc_sz);
+ if (!rsp)
+ return YNL_PARSE_CB_ERROR;
+
rsp->free = info->free;
yarg.data = rsp->data;
yarg.rsp_policy = info->policy;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools: ynl: handle calloc failure in ynl_ntf_parse
2026-08-18 13:27 [PATCH] tools: ynl: handle calloc failure in ynl_ntf_parse Triet Hoang
@ 2026-08-19 8:11 ` Hangbin Liu
0 siblings, 0 replies; 2+ messages in thread
From: Hangbin Liu @ 2026-08-19 8:11 UTC (permalink / raw)
To: Triet Hoang; +Cc: netdev, donald.hunter, kuba, davem, edumazet, pabeni, horms
Hi Triet,
I think your target tree is net-next, but it's close now. You can repost
the patch with the net-next tag after it's reopened.
https://netdev.bots.linux.dev/net-next.html
Thanks
Hangbin
On Tue, Aug 18, 2026 at 01:27:39PM +0000, Triet Hoang wrote:
> Check the return value of calloc() before dereferencing the allocated
> response structure in ynl_ntf_parse().
>
> Signed-off-by: Triet Hoang <triet.hoang.dev@gmail.com>
> ---
> tools/net/ynl/lib/ynl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/net/ynl/lib/ynl.c b/tools/net/ynl/lib/ynl.c
> index 2bcd781111d7..af101544c31a 100644
> --- a/tools/net/ynl/lib/ynl.c
> +++ b/tools/net/ynl/lib/ynl.c
> @@ -889,6 +889,9 @@ static int ynl_ntf_parse(struct ynl_sock *ys, const struct nlmsghdr *nlh)
> return YNL_PARSE_CB_ERROR;
>
> rsp = calloc(1, info->alloc_sz);
> + if (!rsp)
> + return YNL_PARSE_CB_ERROR;
> +
> rsp->free = info->free;
> yarg.data = rsp->data;
> yarg.rsp_policy = info->policy;
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-19 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18 13:27 [PATCH] tools: ynl: handle calloc failure in ynl_ntf_parse Triet Hoang
2026-08-19 8:11 ` Hangbin Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.