All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Ian Rogers <irogers@google.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	namhyung@kernel.org, acme@kernel.org,
	linux-perf-users@vger.kernel.org, Andi Kleen <ak@kernel.org>
Subject: Re: [PATCH v1] perf top: Merge hybrid common events
Date: Wed, 19 Aug 2026 09:11:24 -0700	[thread overview]
Message-ID: <aoXVrD-Qbhi5qd2D@tassilo> (raw)
In-Reply-To: <CAP-5=fXLe9tqR7wHh9auRxqX82Fw6zYh1EoTOXjPhOXcRXB92A@mail.gmail.com>

> With frequency scaling, doesn't IPC remain relatively constant with
> frequency when ignoring external factors like memory? The IPC on an
> e-core is expected to be lower than on a p-core.

For most workloads you cannot ignore memory.

Also the e-core IPC is often not lower than p-core, it's 
actually quite competitive in many things. It just has
a much lower frequency ceiling.

> So I was in a presentation today where someone claimed that larger
> cycle counts translated to memory system overhead, but they could be
> unique :-) In my two loop example the lower IPC core's loop would show
> a greater number of cycles than the higher-IPC core's loop. This would
> make it appear higher in `perf top`, leading the user to drill into it
> assuming more time was spent there due to issues with the code. As I'm
> hypothesizing the code is identical then the higher `perf top` is down
> to being scheduled on the e-core and its lower IPC. Having identical
> code where by default in perf one appears worse than the other doesn't
> strike me as desirable as the same behavior wouldn't happen on a
> non-hybrid system.

Yes performance analysis is hard and a lot of people get it wrong.

> 
> > > How can we merge non-legacy events? On ARM there is no PMU with a type
> > > number file with TYPE_HARDWARE.
> >
> > Very few people use top with anything other than cycles, so it's
> > probably
> > not a very urgent problem.  I suppose you could push the problem to
> > the user with some configuration file.
> 
> So I think users (and me) don't like the choose your event thing at
> the beginning of `perf top`. I think the work in the histogram code to

I'm not sure what you're proposing here. You want to make 
merging default to off?


-Andi

  reply	other threads:[~2026-08-19 16:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 13:25 [PATCH v1] perf top: Merge hybrid common events Andi Kleen
2026-08-13 13:57 ` sashiko-bot
2026-08-17 19:40 ` Ian Rogers
2026-08-18 17:29   ` Andi Kleen
2026-08-19  2:58     ` Ian Rogers
2026-08-19  3:34       ` Andi Kleen
2026-08-19  4:16         ` Ian Rogers
2026-08-19 16:11           ` Andi Kleen [this message]
2026-08-19 17:58             ` Ian Rogers
2026-08-19 18:25               ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoXVrD-Qbhi5qd2D@tassilo \
    --to=ak@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=ak@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.