From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: lijun <lijun01@kylinos.cn>
Cc: andy@kernel.org, geert@linux-m68k.org, fourier.thomas@gmail.com,
bhelgaas@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management
Date: Thu, 20 Aug 2026 09:31:29 +0200 [thread overview]
Message-ID: <aoarrtXkSalfRIGa@monoceros> (raw)
In-Reply-To: <8f38b185-a0df-46ad-98cb-b5acda1823b6@kylinos.cn>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
On Thu, Aug 20, 2026 at 02:04:46PM +0800, lijun wrote:
> Thank you! This suggestion is very useful to me.
> --------
> I think the same is needed for your firmware/arm_scmi patch and also for
> the bluetooth one.
>
> The usage of DEFINE_SIMPLE_DEV_PM_OPS() is an improvement, but now you
> have (at least) three series in flight and the trivial feedback you
> received here applies to all three. As someone who also sends many
> patches, I recommend to get up to speed slowly. Work on a single patch
> first, and only once you get that in---or at least positive feedback on
> it---address one or two further drivers. When you have a handful of
> patches in, you can speed up. But as it is now, you only occupy many
> people finding the same issues in your patches.
Please also fix your mail user agent to use proper quoting. (For
Thunderbird maybe: "Account Settings" -> "Composition & Adressing" ->
[x] "Automatically quote the original message when replying" + "When
quoting start my reply below the quote".)
Thanks
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2026-08-20 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 1:38 [PATCH v3] auxdisplay: arm-charlcd: Use DEFINE_SIMPLE_DEV_PM_OPS for power management Li Jun
2026-08-20 5:04 ` Uwe Kleine-König
2026-08-20 6:04 ` lijun
2026-08-20 7:31 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoarrtXkSalfRIGa@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=fourier.thomas@gmail.com \
--cc=geert@linux-m68k.org \
--cc=lijun01@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.