All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: "Falcon, Thomas" <thomas.falcon@intel.com>
Cc: "Rogers, Ian" <irogers@google.com>,
	"james.clark@linaro.org" <james.clark@linaro.org>,
	"alexander.shishkin@linux.intel.com"
	<alexander.shishkin@linux.intel.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"linux-perf-users@vger.kernel.org"
	<linux-perf-users@vger.kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"dapeng1.mi@linux.intel.com" <dapeng1.mi@linux.intel.com>,
	"Hunter, Adrian" <adrian.hunter@intel.com>
Subject: Re: [PATCH v4 4/6] perf tools: Show memory region in perf-c2c subcommand
Date: Thu, 20 Aug 2026 14:24:26 -0700	[thread overview]
Message-ID: <aodwioqUb5vxdHJo@google.com> (raw)
In-Reply-To: <9762e0ab86bd30c9115b35fce312f7fdbf6f96df.camel@intel.com>

On Wed, Aug 19, 2026 at 10:03:58PM +0000, Falcon, Thomas wrote:
> On Wed, 2026-08-19 at 11:29 -0700, Namhyung Kim wrote:
> > Hello,
> > 
> > On Mon, Aug 17, 2026 at 02:35:44PM -0700, Ian Rogers wrote:
> > > On Tue, Aug 11, 2026 at 10:34 AM Thomas Falcon
> > > > @@ -2898,8 +2948,9 @@ static int ui_quirks(void)
> > > >         /* Fix the zero line for dcacheline column. */
> > > >         buf = fill_line(chk_double_cl ? "Double-Cacheline" : "Cacheline",
> > > >                                 dim_dcacheline.width +
> > > > +                               dim_dcacheline_mem_region.width +
> > > >                                 dim_dcacheline_node.width +
> > > > -                               dim_dcacheline_count.width + 4);
> > > > +                               dim_dcacheline_count.width + 6);
> 
> Do you think this needs to be handled dynamically too?
 
Ideally it should not change anything when memory region is not
available.

Thanks,
Namhyung


> > > >         if (!buf)
> > > >                 return -ENOMEM;
> > > > 

  reply	other threads:[~2026-08-20 21:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 17:33 [PATCH v4 0/6] perf: Add support for memory region/range reporting Thomas Falcon
2026-08-11 17:33 ` [PATCH v4 1/6] perf mem: Fix size tracking for mem_lvl's in perf_script__meminfo_scnprintf() Thomas Falcon
2026-08-17 21:24   ` Ian Rogers
2026-08-11 17:33 ` [PATCH v4 2/6] perf mem: Add support for printing PERF_MEM_LVLNUM_L0 Thomas Falcon
2026-08-17 21:28   ` Ian Rogers
2026-08-11 17:33 ` [PATCH v4 3/6] perf header: Support memory ranges Thomas Falcon
2026-08-17 21:34   ` Ian Rogers
2026-08-18 18:16     ` Falcon, Thomas
2026-08-19  2:34       ` Ian Rogers
2026-08-11 17:33 ` [PATCH v4 4/6] perf tools: Show memory region in perf-c2c subcommand Thomas Falcon
2026-08-17 21:35   ` Ian Rogers
2026-08-19 18:29     ` Namhyung Kim
2026-08-19 22:03       ` Falcon, Thomas
2026-08-20 21:24         ` Namhyung Kim [this message]
2026-08-11 17:33 ` [PATCH v4 5/6] perf tools: Show memory region in perf-script subcommand Thomas Falcon
2026-08-17 21:36   ` Ian Rogers
2026-08-11 17:33 ` [PATCH v4 6/6] perf c2c: print memory region data with stdio output Thomas Falcon
2026-08-17 21:39   ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aodwioqUb5vxdHJo@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=thomas.falcon@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.