* [PATCH] char: tpm: Use SIMPLE_DEV_PM_OPS for ibmvtpm power management
@ 2026-08-19 8:35 Li Jun
2026-08-21 1:16 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Li Jun @ 2026-08-19 8:35 UTC (permalink / raw)
To: lijun01, maddy, mpe, npiggin, chleroy, peterhuewe, jarkko, jgg,
linuxppc-dev, linux-integrity
Replace the manually defined dev_pm_ops structure with the
SIMPLE_DEV_PM_OPS macro to simplify the power management code.
This macro automatically handles CONFIG_PM_SLEEP configuration,
generating the same suspend/resume callbacks while reducing
boilerplate code.Add the value of 'thaw,freeze,poweroff,restore'.
Signed-off-by: Li Jun <lijun01@kylinos.cn>
---
drivers/char/tpm/tpm_ibmvtpm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 6fb4d30eb6f6..51c7e2add3d2 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -462,10 +462,7 @@ static const struct tpm_class_ops tpm_ibmvtpm = {
.req_canceled = tpm_ibmvtpm_req_canceled,
};
-static const struct dev_pm_ops tpm_ibmvtpm_pm_ops = {
- .suspend = tpm_ibmvtpm_suspend,
- .resume = tpm_ibmvtpm_resume,
-};
+static SIMPLE_DEV_PM_OPS(tpm_ibmvtpm_pm_ops, tpm_ibmvtpm_suspend, tpm_ibmvtpm_resume);
/**
* ibmvtpm_crq_get_next - Get next responded crq
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] char: tpm: Use SIMPLE_DEV_PM_OPS for ibmvtpm power management
2026-08-19 8:35 [PATCH] char: tpm: Use SIMPLE_DEV_PM_OPS for ibmvtpm power management Li Jun
@ 2026-08-21 1:16 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2026-08-21 1:16 UTC (permalink / raw)
To: Li Jun
Cc: maddy, mpe, npiggin, chleroy, peterhuewe, jgg, linuxppc-dev,
linux-integrity
On Wed, Aug 19, 2026 at 04:35:47PM +0800, Li Jun wrote:
> Replace the manually defined dev_pm_ops structure with the
> SIMPLE_DEV_PM_OPS macro to simplify the power management code.
> This macro automatically handles CONFIG_PM_SLEEP configuration,
> generating the same suspend/resume callbacks while reducing
> boilerplate code.Add the value of 'thaw,freeze,poweroff,restore'.
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 6fb4d30eb6f6..51c7e2add3d2 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -462,10 +462,7 @@ static const struct tpm_class_ops tpm_ibmvtpm = {
> .req_canceled = tpm_ibmvtpm_req_canceled,
> };
>
> -static const struct dev_pm_ops tpm_ibmvtpm_pm_ops = {
> - .suspend = tpm_ibmvtpm_suspend,
> - .resume = tpm_ibmvtpm_resume,
> -};
> +static SIMPLE_DEV_PM_OPS(tpm_ibmvtpm_pm_ops, tpm_ibmvtpm_suspend, tpm_ibmvtpm_resume);
>
> /**
> * ibmvtpm_crq_get_next - Get next responded crq
> --
> 2.25.1
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-21 1:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19 8:35 [PATCH] char: tpm: Use SIMPLE_DEV_PM_OPS for ibmvtpm power management Li Jun
2026-08-21 1:16 ` Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.