Re: [PATCH v2 2/2] kexec: fix error propagation in kexec_image_probe_default()

From: Mike Rapoport <rppt@kernel.org>
To: Mukesh Pilaniya <mpilaniy@redhat.com>
Cc: Pratyush Yadav <pratyush@kernel.org>,
	Philipp Rudo <prudo@redhat.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>, Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	Baoquan He <baoquan.he@linux.dev>,
	Pasha Tatashin <pasha.tatashin@soleen.com>,
	Tao Liu <ltao@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
	linux-riscv@lists.infradead.org, kexec@lists.infradead.org
Subject: Re: [PATCH v2 2/2] kexec: fix error propagation in kexec_image_probe_default()
Date: Fri, 21 Aug 2026 11:08:24 +0300	[thread overview]
Message-ID: <aogHeKQ8UnudNAMu@kernel.org> (raw)
In-Reply-To: <713ab0a0-235d-47cf-a0c2-73249fbc8f74@redhat.com>

On Fri, Aug 21, 2026 at 12:48:15PM +0530, Mukesh Pilaniya wrote:
> Hi Philipp,
> 
> On 20/08/26 11:41 pm, Pratyush Yadav wrote:
> > On Thu, Aug 20 2026, Philipp Rudo wrote:
> > 
> >> Hi Mukesh,
> >> Hi Pratyush,
> >>
> >> having this patch makes sense. Personally I'd go with having a
> >> switch-case rather than individual if-blocks. E.g.
> >>
> >> 	switch (ret) {
> >> 		case 0:
> >> 			image->fops = *fops;
> >> 			return 0;
> >> 		case -ENOEXEC:
> >> 			continue;
> >> 		default:
> >> 			return ret;
> >> 	}
> >>
> >> IMHO that is better readable and easier to extend in case other error
> >> codes need special handling as well. But that is only my personal
> >> opinion.
> > 
> > Well, IMO both look roughly the same so I unless Mukesh prefers your
> > version more, we can keep it as-is.
> > 
> Thanks for the review. I agree the switch-case reads nicely, but since
> the current version is functionally equivalent and already
> reviewed, I'll keep it as-is to avoid re-spinning for a style change.
> Happy to switch if you or Pratyush feel strongly about it.

I'd like to request another style change :)

In newer code we often use 'err' rather than 'ret', so it's more obvious
what this variable about.

I don't feel strong about if or switch, but if you go with if, please don't
compare to 0, use !err.

-- 
Sincerely yours,
Mike.