All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/qt5: relax openssl constraint to allow compatible implementations
@ 2026-08-21 17:11 Alexis Lothoré via buildroot
  2026-08-21 20:18 ` Thomas Petazzoni via buildroot
  2026-08-29 21:06 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Alexis Lothoré via buildroot @ 2026-08-21 17:11 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni, Giulio Benetti, Alexis Lothoré

Qt5 can be built with or without openssl support. Following some build
failures, commit a94d39d693d8 ("package/qt5: fix build failure due to
libressl use") enforced libopenssl as the only valid implementation for
Qt5 openssl support.

While this solution is fine to filter between the two openssl variants
officially supported by Buildroot, it prevents users bringing their own
OpenSSL implementations (through the virtual package mechanism) from
building Qt5 with openssl support, even if the custom implementation
matches the expected OpenSSL API.

Allow compatible external implementations to be provided for Qt5 openssl
support. Relax the constraint by partially reverting a94d39d693d8 and
checking that the selected openssl implementation isn't libressl. It
then becomes up to users to ensure that the implementation they are
providing is fully compatible with libopenssl's. Some qt5
sub-packages enforce BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL, they don't
need any update as it does not really strictly select libopenssl, it
rather prevents libressl, so it still allows custom providers.

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
---
Changes in v2:
- s/provides mechanism/virtual package mechanism/ (Thomas P.)
- use ifeq on pair or kconfig variables to clarify the condition (Thomas P.)
- Link to v1: https://patch.msgid.link/20260821-qt5_allow_other_openssl_implementations-v1-1-be1438707393@bootlin.com

To: buildroot@buildroot.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
The issue affects 2025.02.x, 2026.05.x, 2026.08.x and master
---
 package/qt5/qt5base/qt5base.mk | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index 159d411de85b..3e54465ed789 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -230,8 +230,16 @@ else
 QT5BASE_CONFIGURE_OPTS += -no-eglfs
 endif
 
-QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_LIBOPENSSL),-openssl,-no-openssl)
-QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_LIBOPENSSL),openssl)
+# Qt5 officially only supports OpenSSL. Users can also provide their own
+# OpenSSL variant through the virtual package mechanism, but it is then up
+# to them to ensure that the provided API is exactly compatible with the
+# libopenssl one
+ifeq ($(BR2_PACKAGE_OPENSSL):$(BR2_PACKAGE_LIBRESSL),y:)
+QT5BASE_CONFIGURE_OPTS += -openssl
+QT5BASE_DEPENDENCIES   += openssl
+else
+QT5BASE_CONFIGURE_OPTS += -no-openssl
+endif
 
 QT5BASE_CONFIGURE_OPTS += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),-fontconfig,-no-fontconfig)
 QT5BASE_DEPENDENCIES   += $(if $(BR2_PACKAGE_QT5BASE_FONTCONFIG),fontconfig)

---
base-commit: 5245c41441bacca292d129d4339e79e5179af79c
change-id: 20260820-qt5_allow_other_openssl_implementations-623cf35cf3a9

Best regards,
--  
Alexis Lothoré <alexis.lothore@bootlin.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/qt5: relax openssl constraint to allow compatible implementations
  2026-08-21 17:11 [Buildroot] [PATCH v2] package/qt5: relax openssl constraint to allow compatible implementations Alexis Lothoré via buildroot
@ 2026-08-21 20:18 ` Thomas Petazzoni via buildroot
  2026-08-29 21:06 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-08-21 20:18 UTC (permalink / raw)
  To: Alexis Lothoré; +Cc: buildroot, Giulio Benetti

On Fri, Aug 21, 2026 at 07:11:42PM +0200, Alexis Lothoré wrote:
> Qt5 can be built with or without openssl support. Following some build
> failures, commit a94d39d693d8 ("package/qt5: fix build failure due to
> libressl use") enforced libopenssl as the only valid implementation for
> Qt5 openssl support.
> 
> While this solution is fine to filter between the two openssl variants
> officially supported by Buildroot, it prevents users bringing their own
> OpenSSL implementations (through the virtual package mechanism) from
> building Qt5 with openssl support, even if the custom implementation
> matches the expected OpenSSL API.
> 
> Allow compatible external implementations to be provided for Qt5 openssl
> support. Relax the constraint by partially reverting a94d39d693d8 and
> checking that the selected openssl implementation isn't libressl. It
> then becomes up to users to ensure that the implementation they are
> providing is fully compatible with libopenssl's. Some qt5
> sub-packages enforce BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL, they don't
> need any update as it does not really strictly select libopenssl, it
> rather prevents libressl, so it still allows custom providers.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

(This is material for next: it's an improvement, not a fix.)

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH v2] package/qt5: relax openssl constraint to allow compatible implementations
  2026-08-21 17:11 [Buildroot] [PATCH v2] package/qt5: relax openssl constraint to allow compatible implementations Alexis Lothoré via buildroot
  2026-08-21 20:18 ` Thomas Petazzoni via buildroot
@ 2026-08-29 21:06 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-08-29 21:06 UTC (permalink / raw)
  To: Alexis Lothoré; +Cc: buildroot, Giulio Benetti

On Fri, Aug 21, 2026 at 07:11:42PM +0200, Alexis Lothoré via buildroot wrote:
> Qt5 can be built with or without openssl support. Following some build
> failures, commit a94d39d693d8 ("package/qt5: fix build failure due to
> libressl use") enforced libopenssl as the only valid implementation for
> Qt5 openssl support.
> 
> While this solution is fine to filter between the two openssl variants
> officially supported by Buildroot, it prevents users bringing their own
> OpenSSL implementations (through the virtual package mechanism) from
> building Qt5 with openssl support, even if the custom implementation
> matches the expected OpenSSL API.
> 
> Allow compatible external implementations to be provided for Qt5 openssl
> support. Relax the constraint by partially reverting a94d39d693d8 and
> checking that the selected openssl implementation isn't libressl. It
> then becomes up to users to ensure that the implementation they are
> providing is fully compatible with libopenssl's. Some qt5
> sub-packages enforce BR2_PACKAGE_OPENSSL_FORCE_LIBOPENSSL, they don't
> need any update as it does not really strictly select libopenssl, it
> rather prevents libressl, so it still allows custom providers.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>

Applied to next, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-29 21:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 17:11 [Buildroot] [PATCH v2] package/qt5: relax openssl constraint to allow compatible implementations Alexis Lothoré via buildroot
2026-08-21 20:18 ` Thomas Petazzoni via buildroot
2026-08-29 21:06 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.