From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: don't leave the hashed inode while it's unlinked
Date: Mon, 24 Aug 2026 15:12:57 +0000 [thread overview]
Message-ID: <aoxfebJ1X6uV_D88@google.com> (raw)
In-Reply-To: <20260823095648.3107875-1-qiwenjie@xiaomi.com>
Hi Wenjie,
Yeah, valid points. Let me send v3.
On 08/23, Wenjie Qi wrote:
> Hi Jaegeuk,
>
> It looks like the original symlink construction error is lost here:
>
> err = __do_unlink(dir, inode, &dentry->d_name);
>
> If fscrypt_encrypt_symlink() or page_symlink() fails but __do_unlink()
> succeeds, err becomes zero. f2fs_handle_failed_inode() then releases the
> inode, and f2fs_symlink() returns success even though the directory entry
> has been removed.
>
> Is this intended? Should the rollback result be stored separately, for
> example in ret, while preserving the original construction error in err?
>
> There seems to be a similar issue in the give_up path. If rollback fails
> in a DIRSYNC directory, a successful f2fs_sync_fs() can overwrite the
> existing error with zero.
>
> Regards,
> Wenjie
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com
Subject: Re: [PATCH v2] f2fs: don't leave the hashed inode while it's unlinked
Date: Mon, 24 Aug 2026 15:12:57 +0000 [thread overview]
Message-ID: <aoxfebJ1X6uV_D88@google.com> (raw)
In-Reply-To: <20260823095648.3107875-1-qiwenjie@xiaomi.com>
Hi Wenjie,
Yeah, valid points. Let me send v3.
On 08/23, Wenjie Qi wrote:
> Hi Jaegeuk,
>
> It looks like the original symlink construction error is lost here:
>
> err = __do_unlink(dir, inode, &dentry->d_name);
>
> If fscrypt_encrypt_symlink() or page_symlink() fails but __do_unlink()
> succeeds, err becomes zero. f2fs_handle_failed_inode() then releases the
> inode, and f2fs_symlink() returns success even though the directory entry
> has been removed.
>
> Is this intended? Should the rollback result be stored separately, for
> example in ret, while preserving the original construction error in err?
>
> There seems to be a similar issue in the give_up path. If rollback fails
> in a DIRSYNC directory, a successful f2fs_sync_fs() can overwrite the
> existing error with zero.
>
> Regards,
> Wenjie
next prev parent reply other threads:[~2026-08-24 15:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:01 [PATCH] f2fs: don't leave the hashed inode while it's unlinked Jaegeuk Kim
2026-08-18 20:01 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-19 2:56 ` Chao Yu via Linux-f2fs-devel
2026-08-19 2:56 ` Chao Yu
2026-08-21 15:23 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-21 15:23 ` Jaegeuk Kim
2026-08-22 7:37 ` Chao Yu via Linux-f2fs-devel
2026-08-22 7:37 ` Chao Yu
2026-08-23 9:56 ` Wenjie Qi
2026-08-23 9:56 ` Wenjie Qi
2026-08-24 15:12 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2026-08-24 15:12 ` Jaegeuk Kim
2026-08-24 13:16 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-24 13:16 ` Chao Yu
2026-08-24 20:12 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2026-08-24 20:12 ` Jaegeuk Kim via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoxfebJ1X6uV_D88@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.