All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: "Laguna, Lukasz" <lukasz.laguna@intel.com>
Cc: sashiko-reviews@lists.linux.dev, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v10 08/10] drm/xe: Introduce temporary device wedging
Date: Mon, 24 Aug 2026 18:08:33 +0200	[thread overview]
Message-ID: <aoxsgT0tRuJecTbp@black.igk.intel.com> (raw)
In-Reply-To: <45efbcf8-b598-463e-b415-dfee2a3afe66@intel.com>

On Mon, Aug 24, 2026 at 04:30:25PM +0200, Laguna, Lukasz wrote:
> On 8/21/2026 13:37, sashiko-bot@kernel.org wrote:

...

> > - [High] Unprotected state modification and double-increment of `wedged.ref` in `prepare_device_for_reset()`.
> 
> Valid. It should be enough to just take the lock and check xe->wedged.perm
> before taking the reference.

We have a xe_device_wedged() sanity check before landing here, so ideally
we shouldn't be at this point with an active ref. But as mentioned in the
comment, the plan is to drop the whole prepare_device_for_reset() once we
land this series.

Raag

> > > +	/* TODO: We shouldn't be doing such ugly hacks, reuse FLR helpers and drop this. */
> > > +	xe->wedged.perm = true;

  reply	other threads:[~2026-08-24 16:08 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 11:23 [PATCH v10 00/10] Introduce Xe PCIe FLR Raag Jadav
2026-08-21 11:23 ` [PATCH v10 01/10] drm/xe/uc_fw: Allow re-initializing firmware Raag Jadav
2026-08-21 11:41   ` sashiko-bot
2026-08-21 11:23 ` [PATCH v10 02/10] drm/xe/guc_submit: Introduce guc_exec_queue_reinit_kernel() Raag Jadav
2026-08-21 11:52   ` sashiko-bot
2026-08-21 11:23 ` [PATCH v10 03/10] drm/xe/gt: Introduce FLR helpers Raag Jadav
2026-08-26  9:39   ` Tauro, Riana
2026-08-27 15:40     ` Raag Jadav
2026-08-21 11:23 ` [PATCH v10 04/10] drm/xe/bo_evict: Introduce xe_bo_restore_map() Raag Jadav
2026-08-21 11:23 ` [PATCH v10 05/10] drm/xe/exec_queue: Introduce xe_exec_queue_reinit() Raag Jadav
2026-08-21 11:43   ` sashiko-bot
2026-08-21 11:23 ` [PATCH v10 06/10] drm/xe/migrate: Introduce xe_migrate_reinit() Raag Jadav
2026-08-21 11:39   ` sashiko-bot
2026-08-21 11:23 ` [PATCH v10 07/10] drm/xe/pm: Introduce xe_device_suspend/resume() Raag Jadav
2026-08-21 11:43   ` sashiko-bot
2026-08-24 18:22     ` Rodrigo Vivi
2026-08-26  7:01       ` Raag Jadav
2026-08-21 11:23 ` [PATCH v10 08/10] drm/xe: Introduce temporary device wedging Raag Jadav
2026-08-21 11:37   ` sashiko-bot
2026-08-24 14:30     ` Laguna, Lukasz
2026-08-24 16:08       ` Raag Jadav [this message]
2026-08-24 18:29       ` Rodrigo Vivi
2026-08-25  7:41         ` Raag Jadav
2026-08-21 11:23 ` [PATCH v10 09/10] drm/xe/pci: Introduce PCIe Function Level Reset Raag Jadav
2026-08-21 11:39   ` sashiko-bot
2026-08-25 10:06   ` Laguna, Lukasz
2026-08-26  9:01     ` Raag Jadav
2026-08-26  9:52       ` Tauro, Riana
2026-08-26 11:38         ` Raag Jadav
2026-08-21 11:23 ` [PATCH v10 10/10] drm/xe/doc: Wire up PCI Error Handling Raag Jadav
2026-08-21 11:31 ` ✗ CI.checkpatch: warning for Introduce Xe PCIe FLR (rev10) Patchwork
2026-08-21 11:33 ` ✓ CI.KUnit: success " Patchwork
2026-08-21 12:37 ` ✓ Xe.CI.BAT: " Patchwork
2026-08-21 14:38 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aoxsgT0tRuJecTbp@black.igk.intel.com \
    --to=raag.jadav@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lukasz.laguna@intel.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.