All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to AVX10_V1_AUX
@ 2026-09-08  6:13 Hao Xiang
  2026-09-08  7:10 ` zhao1.liu
  0 siblings, 1 reply; 2+ messages in thread
From: Hao Xiang @ 2026-09-08  6:13 UTC (permalink / raw)
  To: kvm, linux-kernel, xianghao.xiang, hao.xiang, zhao1.liu, seanjc,
	pbonzini, shannon.zhao

CPUID feature bit AVX10_VNNI_INT is renamed to AVX10_V1_AUX to account
for additional AVX10.2 isntructions sep-arated to have ”OR” sensitivity
for platforms which may not support all of AVX10.2[*]. This CPUID bit now
applies to the following VNNI instructions: VPDPB[SU,UU,SS]D[,S]
VPDPW[SU,US,UU]D[,S], as well as the following convert in-structions:
VCVT[,2]PH2[B,H]F8[,S], VCVT2PS2PHX, VCVT-BIASPH2[B,H]F8[,S],
VCVTHF82PH.

[*]: Intel® Advanced Vector Extensions 10.2 Architecture Specification
      (rev 7.0).

Signed-off-by: Hao Xiang <hao.xiang@linux.alibaba.com>
---
  arch/x86/kvm/cpuid.c         | 2 +-
  arch/x86/kvm/reverse_cpuid.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 851f151efb35..1e5bf6fff9c9 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -1095,7 +1095,7 @@ void kvm_initialize_cpu_caps(void)
      );

      kvm_cpu_cap_init(CPUID_24_1_ECX,
-        F(AVX10_VNNI_INT),
+        F(AVX10_V1_AUX),
      );

      kvm_cpu_cap_init(CPUID_8000_0001_ECX,
diff --git a/arch/x86/kvm/reverse_cpuid.h b/arch/x86/kvm/reverse_cpuid.h
index 2ad25781cefb..89345af0f7ad 100644
--- a/arch/x86/kvm/reverse_cpuid.h
+++ b/arch/x86/kvm/reverse_cpuid.h
@@ -66,7 +66,7 @@
  #define X86_FEATURE_AVX10_512 KVM_X86_FEATURE(CPUID_24_0_EBX, 18)

  /* Intel-defined sub-features, CPUID level 0x00000024:1 (ECX) */
-#define X86_FEATURE_AVX10_VNNI_INT KVM_X86_FEATURE(CPUID_24_1_ECX, 2)
+#define X86_FEATURE_AVX10_V1_AUX    KVM_X86_FEATURE(CPUID_24_1_ECX, 2)

  /* CPUID level 0x80000007 (EDX). */
  #define KVM_X86_FEATURE_CONSTANT_TSC 
KVM_X86_FEATURE(CPUID_8000_0007_EDX, 8)
--
2.32.0.3.g01195cf9f

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to AVX10_V1_AUX
  2026-09-08  6:13 [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to AVX10_V1_AUX Hao Xiang
@ 2026-09-08  7:10 ` zhao1.liu
  0 siblings, 0 replies; 2+ messages in thread
From: zhao1.liu @ 2026-09-08  7:10 UTC (permalink / raw)
  To: Hao Xiang
  Cc: kvm, linux-kernel, xianghao.xiang, seanjc, pbonzini, shannon.zhao,
	Zhao Liu

On Tue, Sep 08, 2026 at 02:13:17PM +0800, Hao Xiang wrote:
> Date: Tue, 08 Sep 2026 14:13:17 +0800
> From: Hao Xiang <hao.xiang@linux.alibaba.com>
> Subject: [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to
>  AVX10_V1_AUX
> X-Mailer: [Alimail-Mailagent][W4_0.2.3][v5ForWebDing][Chrome]
> 
> CPUID feature bit AVX10_VNNI_INT is renamed to AVX10_V1_AUX to account
> for additional AVX10.2 isntructions sep-arated to have ”OR” sensitivity

nits:

s/isntructions/instructions/ - though it's a typo in spec :-(.
s/sep-arated/separated/ - there are no line breaks here.

> for platforms which may not support all of AVX10.2[*]. This CPUID bit now
> applies to the following VNNI instructions: VPDPB[SU,UU,SS]D[,S]
> VPDPW[SU,US,UU]D[,S], as well as the following convert in-structions:

s/in-structions/instructions/

> VCVT[,2]PH2[B,H]F8[,S], VCVT2PS2PHX, VCVT-BIASPH2[B,H]F8[,S],
> VCVTHF82PH.
> 
> [*]: Intel® Advanced Vector Extensions 10.2 Architecture Specification
>       (rev 7.0).
> 
> Signed-off-by: Hao Xiang <hao.xiang@linux.alibaba.com>
> ---
>   arch/x86/kvm/cpuid.c         | 2 +-
>   arch/x86/kvm/reverse_cpuid.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

I hadn't renamed it before because I thought this bit's name is not
exposed to user space, and it's enough to refer to it simply as
"this bit". But, semantically speaking, VNNI_INT is indeed no longer
correct. As noted in your commit message, the feature represented by
this bit now includes more convert instructions. And more accurate
naming is better, as it makes it easier to look up the spec.

This name change looks good to me, so

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

And BTW, the prefix of subject should be "KVM: x86:", referring
"Shortlog" section of Documentation/process/maintainer-kvm-x86.rst.

Thanks,
Zhao


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-08  7:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-08  6:13 [PATCH] i386/cpu: Rename CPUID feature bit AVX10_VNNI_INT to AVX10_V1_AUX Hao Xiang
2026-09-08  7:10 ` zhao1.liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.