From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] xfs: add xfs_error_report the ability to display an error code
Date: Sun, 6 Sep 2026 23:04:44 -0700 [thread overview]
Message-ID: <ap5T_Pcvk4QAMcWb@infradead.org> (raw)
In-Reply-To: <20260905010851.GE1933798@frogsfrogsfrogs>
On Fri, Sep 04, 2026 at 06:08:51PM -0700, Darrick J. Wong wrote:
> > @@ -387,6 +388,10 @@ xfs_error_report(
> > "Internal error %s at line %d of file %s. Caller %pS",
> > tag, linenum, filename, failaddr);
> >
> > + if (error)
> > + xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT,
> > + "Error Code: %d", error);
>
> /me wonders, should the error erport just go in the "Internal error..."
> message above?
>
> "Internal error $tag ($error) at line..."
Yeah, that seems much easier to follow. Maybe make it conditional on
an error being passed.
> > +extern void xfs_error_report(const char *tag, int level, int error,
> > + struct xfs_mount *mp, const char *filename,
> > + int linenum, xfs_failaddr_t failaddr);
.. and let's drop the pointless extern here while we touch this.
> > - XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, log->l_mp);
> > + XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, log->l_mp);
Overly long line here now.
next prev parent reply other threads:[~2026-09-07 6:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 11:32 [RFC PATCH 0/3] Log transaction cancel error codes in the kernel log buffer cem
2026-09-04 11:32 ` [RFC PATCH 1/3] xfs: add xfs_error_report the ability to display an error code cem
2026-09-05 1:08 ` Darrick J. Wong
2026-09-07 6:04 ` Christoph Hellwig [this message]
2026-09-07 6:39 ` Carlos Maiolino
2026-09-08 5:36 ` Carlos Maiolino
2026-09-08 14:54 ` Darrick J. Wong
2026-09-04 11:32 ` [RFC PATCH 2/3] xfs: enable xfs_trans_cancel() to report and " cem
2026-09-05 1:10 ` Darrick J. Wong
2026-09-07 6:05 ` Christoph Hellwig
2026-09-08 6:36 ` Carlos Maiolino
2026-09-04 11:32 ` [RFC PATCH 3/3] xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel cem
2026-09-05 1:11 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap5T_Pcvk4QAMcWb@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.