Re: [RFC PATCH 1/3] xfs: add xfs_error_report the ability to display an error code

[Carlos Maiolino <cem@kernel.org>]

On Sun, Sep 06, 2026 at 11:04:44PM -0700, Christoph Hellwig wrote:
> On Fri, Sep 04, 2026 at 06:08:51PM -0700, Darrick J. Wong wrote:
> > > @@ -387,6 +388,10 @@ xfs_error_report(
> > >  		"Internal error %s at line %d of file %s.  Caller %pS",
> > >  			    tag, linenum, filename, failaddr);
> > >  
> > > +		if (error)
> > > +			xfs_alert_tag(mp, XFS_PTAG_ERROR_REPORT,
> > > +				      "Error Code: %d", error);
> > 
> > /me wonders, should the error erport just go in the "Internal error..."
> > message above?
> > 
> > "Internal error $tag ($error) at line..."
> 
> Yeah, that seems much easier to follow.  Maybe make it conditional on
> an error being passed.
> 
> > > +extern void xfs_error_report(const char *tag, int level, int error,
> > > +			     struct xfs_mount *mp, const char *filename,
> > > +			     int linenum, xfs_failaddr_t failaddr);
> 
> .. and let's drop the pointless extern here while we touch this.
> 
> > > -			XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, log->l_mp);
> > > +			XFS_ERROR_REPORT(__func__, XFS_ERRLEVEL_LOW, 0, log->l_mp);
> 
> Overly long line here now.
> 
> 

Thanks both for the review. I'll work on it and send a proper patch
later on, I need to finish a case for xfstests first, then I'll move to
this one...