From: Breno Leitao <leitao@debian.org>
To: Hangbin Liu <hangbin.liu@linux.dev>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Shuah Khan" <shuah@kernel.org>,
"Jay Vosburgh" <jv@jvosburgh.net>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowangio@gmail.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Petr Machata" <petrm@nvidia.com>,
"Matthieu Baerts" <matttbe@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
"Hangbin Liu" <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net] selftests/drivers/net: include lib/sh/*.sh
Date: Mon, 7 Sep 2026 05:05:56 -0700 [thread overview]
Message-ID: <ap6oi4YujKEgoKhu@gmail.com> (raw)
In-Reply-To: <20260907-selftest_lib_defer-v1-1-8af94645aaa3@kylinos.cn>
On Mon, Sep 07, 2026 at 03:28:09PM +0800, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
>
> When I tried to install and run bonding selftests via:
>
> make INSTALL_PATH=/tmp/kself TARGETS=drivers/net/bonding \
> -C tools/testing/selftests install
>
> Some tests fail because net/lib/sh/defer.sh is missing:
>
> /tmp/kself/net/forwarding/../lib.sh: line 5: /tmp/kself/net/lib/sh/defer.sh: No such file or directory
>
> One option is to add defer.sh directly to TEST_INCLUDES. Alternatively,
> follow the approach from commit f72aa1b27628 ("selftests: net: include
> lib/sh/*.sh with lib.sh"), which pulls in all .sh files to accommodate
> future changes to the library directory.
>
> This patch adds a wildcard to include all shell files for drivers/net
> tests that consume net lib.sh. TEST_INCLUDES is also sorted to avoid
> ordering‑related problems for future modifications. The team driver is
> not affected by this bug, but we use the wildcard for it as well, rather
> than listing only defer.sh.
>
> Fixes: a6e263f125cd ("selftests: net: lib: Introduce deferred commands")
> Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2026-09-07 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 7:28 [PATCH net] selftests/drivers/net: include lib/sh/*.sh Hangbin Liu
2026-09-07 8:55 ` Petr Machata
2026-09-07 12:05 ` Breno Leitao [this message]
2026-09-07 15:14 ` Matthieu Baerts
2026-09-08 7:29 ` netdev-bot+sashiko
2026-09-08 8:26 ` Hangbin Liu
2026-09-09 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap6oi4YujKEgoKhu@gmail.com \
--to=leitao@debian.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hangbin.liu@linux.dev \
--cc=jasowangio@gmail.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=matttbe@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.