From: Hangbin Liu <hangbin.liu@linux.dev>
To: netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org,
jv@jvosburgh.net, olteanv@gmail.com, leitao@debian.org,
jiri@resnulli.us, mst@redhat.com, jasowangio@gmail.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
petrm@nvidia.com, matttbe@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev
Subject: Re: [PATCH net] selftests/drivers/net: include lib/sh/*.sh
Date: Tue, 8 Sep 2026 16:26:02 +0800 [thread overview]
Message-ID: <ap_GmmpU95LQvzTC@fedora> (raw)
In-Reply-To: <178885255602.219967.561231920123759325@kernel.org>
On Tue, Sep 08, 2026 at 07:29:16AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> - [Medium] Incomplete fix:
> `tools/testing/selftests/drivers/net/netdevsim/Makefile` is the only…
>
> --
>
> selftests/drivers/net: include lib/sh/*.sh
>
> This adds $(wildcard ../../net/lib/sh/*.sh) to TEST_INCLUDES in the
> drivers/net selftest Makefiles so that net/lib/sh/defer.sh gets installed
> by "make install", and sorts the TEST_INCLUDES lists while at it.
>
> > diff --git a/tools/testing/selftests/drivers/net/Makefile b/tools/testing/selftests/drivers/net/Makefile
> > index d5bf4cb638a8c..ab39c2e508f0a 100644
> > --- a/tools/testing/selftests/drivers/net/Makefile
> > +++ b/tools/testing/selftests/drivers/net/Makefile
> > @@ -3,6 +3,7 @@ CFLAGS += $(KHDR_INCLUDES)
> >
> > TEST_INCLUDES := $(wildcard lib/py/*.py) \
> > $(wildcard lib/sh/*.sh) \
> > + $(wildcard ../../net/lib/sh/*.sh) \
> > ../../net/lib.sh \
> >
> > TEST_GEN_FILES := \
>
> [Severity: Medium]
> Was drivers/net/netdevsim intentionally left out? It is the only Makefile
> under tools/testing/selftests/drivers/net/ that this patch does not touch,
> and it defines no TEST_INCLUDES at all:
>
> tools/testing/selftests/drivers/net/netdevsim/Makefile:
> TEST_PROGS := \
> devlink.sh \
> ...
> peer.sh \
> ...
> # end of TEST_PROGS
>
> TEST_FILES := \
> ethtool-common.sh
> # end of TEST_FILES
>
> include ../../../lib.mk
Yes, netdevsim doesn't have TEST_INCLUDES at all. I think it deserves
its own separate patch.
Thanks
Hangbin
next prev parent reply other threads:[~2026-09-08 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 7:28 [PATCH net] selftests/drivers/net: include lib/sh/*.sh Hangbin Liu
2026-09-07 8:55 ` Petr Machata
2026-09-07 12:05 ` Breno Leitao
2026-09-07 15:14 ` Matthieu Baerts
2026-09-08 7:29 ` netdev-bot+sashiko
2026-09-08 8:26 ` Hangbin Liu [this message]
2026-09-09 0:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap_GmmpU95LQvzTC@fedora \
--to=hangbin.liu@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowangio@gmail.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.