Re: [PATCH v9 00/19] Add Freescale i.MX8qxp Display Controller support

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 4410 bytes --]

On Fri, Sep 04, 2026 at 04:49:19PM +0800, Liu Ying wrote:
> On Fri, Sep 04, 2026 at 10:38:08AM +0200, Maxime Ripard wrote:
> > On Fri, Sep 04, 2026 at 04:10:07PM +0800, Liu Ying wrote:
> > > Hi Maxime,
> > > 
> > > On Thu, Sep 03, 2026 at 03:41:15PM +0200, Maxime Ripard wrote:
> > > > On Thu, Jul 16, 2026 at 02:49:14PM +0800, Liu Ying wrote:
> > > > > On Thu, Jul 16, 2026 at 08:26:12AM +0200, Francesco Dolcini wrote:
> > > > > > On Thu, Jul 16, 2026 at 02:21:31PM +0800, Liu Ying wrote:
> > > > > > > On Tue, Jul 14, 2026 at 09:36:27PM +0200, Francesco Dolcini wrote:
> > > > > > > > On Mon, Apr 14, 2025 at 11:50:09AM +0800, Liu Ying wrote:
> > > > > > > > > Hi,
> > > > > > > > > 
> > > > > > > > > This patch series aims to add Freescale i.MX8qxp Display Controller support.
> > > > > > > > > 
> > > > > > > > > The controller is comprised of three main components that include a blit
> > > > > > > > > engine for 2D graphics accelerations, display controller for display output
> > > > > > > > > processing, as well as a command sequencer.
> > > > > > > > 
> > > > > > > > ...
> > > > > > > > 
> > > > > > > > > 
> > > > > > > > > To follow up i.MX8qxp TRM, I changed the controller name to "Display Controller"
> > > > > > > > > instead of the previous "DPU".  "DPU" is only mentioned in the SoC block
> > > > > > > > > diagram and represents the whole display subsystem which includes the display
> > > > > > > > > controller and prefech engines, etc.
> > > > > > > > > 
> > > > > > > > > With an additional patch[1] for simple-pm-bus.c, this series facilitates
> > > > > > > > > testing a LVDS panel on i.MX8qxp MEK.
> > > > > > > > > 
> > > > > > > > > Please do NOT merge patch 14-19.  They are only used to facilitate testing
> > > > > > > > > the LVDS panel.
> > > > > > > > 
> > > > > > > > What's the plan to conclude this work? What's the latest status?
> > > > > > > > I am looking forward to have a way to use the i.MX8QXP display with
> > > > > > > > mainline, but to my understanding some required changes on the SOC dtsi
> > > > > > > > are not merged.
> > > > > > > > 
> > > > > > > > Can you help?
> > > > > > > 
> > > > > > > I planned to add display controller DT node after prefetch engine support [1]
> > > > > > > is picked up so that the prefetch engine could be enabled together with the
> > > > > > > display controller.  Just want to avoid a DT that only enables the display
> > > > > > > controller or bypasses the prefetch engine.  It makes the display controller
> > > > > > > driver simpler.
> > > > > > > 
> > > > > > > [1] https://lore.kernel.org/all/20251027-imx8-dc-prefetch-v5-0-4ecb6c6d4941@nxp.com/
> > > > > > 
> > > > > > That series is from October 2025, is there anything blocking to move it
> > > > > > forward?
> > > > > 
> > > > > It lacks a Reviewed-by tag(at least a Acked-by tag) from a drm-misc committer
> > > > > for every driver patch in that series.  Also, it seems that Marek(Cc'ed) is
> > > > > not a big fan of [1](See i.MX95 display support discussion[2]).
> > > > 
> > > > I was just pointed at this series, and I'm not sure why it's blocked. It
> > > > looks like you were waiting for a Reviewed-by by a drm-misc maintainer,
> > > > but I gave mine already and I'm a drm-misc maintainer, sooo... :)
> > > 
> > > Your Reviewed-by tags were on the initial i.MX8qxp Display Controller driver
> > > patches.  And, those patches have already landed.
> > > 
> > > Now, I'm waiting for Acked-by or Reviewed-by tags on those driver patches
> > > which add i.MX8qxp Display Controller *prefetch engines* support.
> > > 'b4 trailers -u' doesn't include any Reviewed-by from you on those patches...
> > > I sent v6 prefetch engine patch series[1] just now.
> > > It would be great to have your Acked-by or Reviewed-by tags on those driver
> > > patches :)
> > 
> > It looks like you had a reviewed-by by someone on all these patches
> > already, so you could have merged them.
> 
> Oh, okay.  I *thought* one merge criteria is at least one Acked-by from a
> drm-misc committer on each driver patch by reading the guildlines[1].
> But now I've got the idea.  Thanks.
> 
> [1] https://drm.pages.freedesktop.org/maintainer-tools/committer/committer-drm-misc.html

For a driver, it's totally enough to have a reviewed-by by someone with
experience with the driver too.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]