All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Satya Tangirala <satyat@google.com>
Subject: Re: [PATCH] blk-crypto: Fix the num_prealloc_fallback_crypt_ctxs parameter description
Date: Mon, 7 Sep 2026 22:46:57 +0200	[thread overview]
Message-ID: <ap8gCoCnLk1QcPIT@gmail.com> (raw)
In-Reply-To: <20260906165952.2344-1-kmehltretter@gmail.com>

On Sun, Sep 06, 2026 at 06:59:52PM +0100, Karl Mehltretter wrote:
> The module parameter is num_prealloc_fallback_crypt_ctxs, but its
> MODULE_PARM_DESC() names num_prealloc_crypt_fallback_ctxs, so modinfo
> describes a parameter that does not exist and shows no description for
> the real one.

One correction to the changelog: BLK_INLINE_ENCRYPTION_FALLBACK is bool,
so this code is always built in and modinfo never shows it. The only
place the description ends up is modules.builtin.modinfo, where
module_param() and MODULE_PARM_DESC() produce one record each and name
different parameters.

I will wait a bit for other feedback, then send a v2 with the
changelog corrected.

Thanks,
Karl

      reply	other threads:[~2026-09-07 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-06 16:59 [PATCH] blk-crypto: Fix the num_prealloc_fallback_crypt_ctxs parameter description Karl Mehltretter
2026-09-07 20:46 ` Karl Mehltretter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap8gCoCnLk1QcPIT@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=satyat@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.