[PATCH] blk-crypto: Fix the num_prealloc_fallback_crypt_ctxs parameter description

[PATCH] blk-crypto: Fix the num_prealloc_fallback_crypt_ctxs parameter description

[Karl Mehltretter]

The module parameter is num_prealloc_fallback_crypt_ctxs, but its
MODULE_PARM_DESC() names num_prealloc_crypt_fallback_ctxs, so modinfo
describes a parameter that does not exist and shows no description for
the real one.

Use the parameter name in the description.

Fixes: 488f6682c832 ("block: blk-crypto-fallback for Inline Encryption")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 block/blk-crypto-fallback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c
index 2a8f40a65158..877934db18ef 100644
--- a/block/blk-crypto-fallback.c
+++ b/block/blk-crypto-fallback.c
@@ -34,7 +34,7 @@ MODULE_PARM_DESC(num_keyslots,
 
 static unsigned int num_prealloc_fallback_crypt_ctxs = 128;
 module_param(num_prealloc_fallback_crypt_ctxs, uint, 0);
-MODULE_PARM_DESC(num_prealloc_crypt_fallback_ctxs,
+MODULE_PARM_DESC(num_prealloc_fallback_crypt_ctxs,
 		 "Number of preallocated bio fallback crypto contexts for blk-crypto to use during crypto API fallback");
 
 struct bio_fallback_crypt_ctx {

base-commit: 986c24e0fe44f844b44d365b71ce831947f50298
-- 
2.53.0

Re: [PATCH] blk-crypto: Fix the num_prealloc_fallback_crypt_ctxs parameter description

[Karl Mehltretter]

On Sun, Sep 06, 2026 at 06:59:52PM +0100, Karl Mehltretter wrote:
> The module parameter is num_prealloc_fallback_crypt_ctxs, but its
> MODULE_PARM_DESC() names num_prealloc_crypt_fallback_ctxs, so modinfo
> describes a parameter that does not exist and shows no description for
> the real one.

One correction to the changelog: BLK_INLINE_ENCRYPTION_FALLBACK is bool,
so this code is always built in and modinfo never shows it. The only
place the description ends up is modules.builtin.modinfo, where
module_param() and MODULE_PARM_DESC() produce one record each and name
different parameters.

I will wait a bit for other feedback, then send a v2 with the
changelog corrected.

Thanks,
Karl