All of lore.kernel.org
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
To: george.moussalem@outlook.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] usb: dwc3: qcom: Add support for selecting UTMI as reference clock
Date: Thu, 27 Aug 2026 17:12:20 +0530	[thread overview]
Message-ID: <apAinJ1TEFL8t3ub@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <20260825-ipq-flatten-usb-v1-3-5c1f3170bbe9@outlook.com>

[...]
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index ac68b4218b56..17292517c594 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -617,6 +617,8 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>  	int			ret;
>  	bool			ignore_pipe_clk;
>  	bool			wakeup_source;
> +	bool			select_utmi_as_ref_clk;
> +	struct clk		*ref_clk;

Any reason why glue layer can't send the ref_clk_rate directly?

-Varada

>  	qcom = devm_kzalloc(&pdev->dev, sizeof(*qcom), GFP_KERNEL);
>  	if (!qcom)
> @@ -698,6 +700,18 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>  			qcom->current_role = USB_ROLE_DEVICE;
>  	}
>
> +	select_utmi_as_ref_clk = device_property_read_bool(dev,
> +					"qcom,select-utmi-as-ref-clk");
> +	if (select_utmi_as_ref_clk) {
> +		ref_clk = devm_clk_get_optional(dev, "mock_utmi");
> +		if (IS_ERR(ref_clk)) {
> +			ret = PTR_ERR(ref_clk);
> +			dev_warn(dev, "failed to get ref clock: %d\n", ret);
> +		} else {
> +			probe_data.ref_clk = ref_clk;
> +		}
> +	}
> +
>  	qcom->dwc.glue_ops = &dwc3_qcom_glue_ops;
>
>  	qcom->dwc.dev = dev;
>
> --
> 2.53.0
>
>

  parent reply	other threads:[~2026-08-27 11:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 10:42 [PATCH 0/9] Flatten USB Controller Nodes on IPQ SoCs George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 1/9] dt-bindings: usb: qcom,snps-dwc3: Add ability to select UTMI as reference clock George Moussalem via B4 Relay
2026-08-25 10:52   ` sashiko-bot
2026-08-30  9:41   ` Krzysztof Kozlowski
2026-08-30 13:17     ` George Moussalem
2026-08-31 12:26       ` Krzysztof Kozlowski
2026-08-25 10:42 ` [PATCH 2/9] usb: dwc3: core: Allow glue layer to pass " George Moussalem via B4 Relay
2026-08-30  9:42   ` Krzysztof Kozlowski
2026-09-03  4:57     ` George Moussalem
2026-08-25 10:42 ` [PATCH 3/9] usb: dwc3: qcom: Add support for selecting UTMI as " George Moussalem via B4 Relay
2026-08-25 10:59   ` sashiko-bot
2026-08-26  9:18   ` Konrad Dybcio
2026-08-26  9:37     ` George Moussalem
2026-08-26 10:27       ` Krishna Kurapati
2026-08-27 11:42   ` Varadarajan Narayanan [this message]
2026-08-27 11:49     ` George Moussalem
2026-08-25 10:42 ` [PATCH 4/9] arm64: dts: qcom: ipq5018: Flatten usb controller node George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 5/9] arm64: dts: qcom: ipq5332: " George Moussalem via B4 Relay
2026-08-25 10:42 ` [PATCH 6/9] arm64: dts: qcom: ipq5424: Flatten usb controller nodes George Moussalem via B4 Relay
2026-08-25 11:08   ` sashiko-bot
2026-08-25 10:42 ` [PATCH 7/9] arm64: dts: qcom: ipq6018: " George Moussalem via B4 Relay
2026-08-29 16:48   ` Krishna Kurapati
2026-08-30  3:12     ` George Moussalem
2026-09-01 15:24       ` Konrad Dybcio
2026-08-25 10:42 ` [PATCH 8/9] arm64: dts: qcom: ipq8074: " George Moussalem via B4 Relay
2026-08-29 16:41   ` Krishna Kurapati
2026-08-30  3:14     ` George Moussalem
2026-08-25 10:42 ` [PATCH 9/9] arm64: dts: qcom: ipq9574: Flatten usb controller node George Moussalem via B4 Relay
2026-08-29 16:44   ` Krishna Kurapati
2026-08-30  3:15     ` George Moussalem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apAinJ1TEFL8t3ub@hu-varada-blr.qualcomm.com \
    --to=varadarajan.narayanan@oss.qualcomm.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=george.moussalem@outlook.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.