All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Janani Sunil <jan.sun97@gmail.com>
Cc: "Janani Sunil" <janani.sunil@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Kent Gustavsson" <kent@minoris.se>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-spi@vger.kernel.org, "Kent Gustavsson" <nedo80@gmail.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support
Date: Thu, 27 Aug 2026 15:47:57 +0300	[thread overview]
Message-ID: <apAx_ZUDQ6G6XVuc@ashevche-desk.local> (raw)
In-Reply-To: <aed972ef-3776-4055-81aa-63255d072b8d@gmail.com>

On Thu, Aug 27, 2026 at 01:17:13PM +0200, Janani Sunil wrote:
> On 8/27/26 10:23, Andy Shevchenko wrote:
> > On Thu, Aug 27, 2026 at 09:34:48AM +0200, Janani Sunil wrote:

...

> > > +	for (unsigned int i = 0; i < ARRAY_SIZE(ad5529r_vss_supply_names); i++) {
> > > +		ret = devm_regulator_get_enable_optional(dev,
> > > +							 ad5529r_vss_supply_names[i]);
> > > +		if (ret && ret != -ENODEV)
> > > +			return dev_err_probe(dev, ret,
> > > +					     "Failed to get and enable %s regulator\n",
> > > +					     ad5529r_vss_supply_names[i]);
> > > +	}
> > Hmm... Can we use bulk regulator approach here?
> 
> I don´t think the bulk helper fits here. Each VSS supply is independently
> optional, and there is currently no optional bulk get-enable regulator
> helper.

Ah, I see. Yeah, then we have to live with a for-loop...

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Janani Sunil <jan.sun97@gmail.com>
Cc: "Janani Sunil" <janani.sunil@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Shuah Khan" <skhan@linuxfoundation.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"Marcus Folkesson" <marcus.folkesson@gmail.com>,
	"Kent Gustavsson" <kent@minoris.se>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-spi@vger.kernel.org, "Kent Gustavsson" <nedo80@gmail.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support
Date: Thu, 27 Aug 2026 15:47:57 +0300	[thread overview]
Message-ID: <apAx_ZUDQ6G6XVuc@ashevche-desk.local> (raw)
In-Reply-To: <aed972ef-3776-4055-81aa-63255d072b8d@gmail.com>

On Thu, Aug 27, 2026 at 01:17:13PM +0200, Janani Sunil wrote:
> On 8/27/26 10:23, Andy Shevchenko wrote:
> > On Thu, Aug 27, 2026 at 09:34:48AM +0200, Janani Sunil wrote:

...

> > > +	for (unsigned int i = 0; i < ARRAY_SIZE(ad5529r_vss_supply_names); i++) {
> > > +		ret = devm_regulator_get_enable_optional(dev,
> > > +							 ad5529r_vss_supply_names[i]);
> > > +		if (ret && ret != -ENODEV)
> > > +			return dev_err_probe(dev, ret,
> > > +					     "Failed to get and enable %s regulator\n",
> > > +					     ad5529r_vss_supply_names[i]);
> > > +	}
> > Hmm... Can we use bulk regulator approach here?
> 
> I don´t think the bulk helper fits here. Each VSS supply is independently
> optional, and there is currently no optional bulk get-enable regulator
> helper.

Ah, I see. Yeah, then we have to live with a for-loop...

-- 
With Best Regards,
Andy Shevchenko



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-08-27 12:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27  7:34 [PATCH v10 0/3] iio: dac: Add support for AD5529R DAC Janani Sunil
2026-08-27  7:34 ` Janani Sunil
2026-08-27  7:34 ` [PATCH v10 1/3] spi: dt-bindings: Add spi-device-addr peripheral property Janani Sunil
2026-08-27  7:34   ` Janani Sunil
2026-08-27  7:34 ` [PATCH v10 2/3] dt-bindings: iio: dac: Add AD5529R Janani Sunil
2026-08-27  7:34   ` Janani Sunil
2026-08-27  7:44   ` sashiko-bot
2026-08-27  7:34 ` [PATCH v10 3/3] iio: dac: Add AD5529R DAC driver support Janani Sunil
2026-08-27  7:34   ` Janani Sunil
2026-08-27  7:50   ` sashiko-bot
2026-08-27  8:23   ` Andy Shevchenko
2026-08-27  8:23     ` Andy Shevchenko
2026-08-27 11:17     ` Janani Sunil
2026-08-27 11:17       ` Janani Sunil
2026-08-27 12:47       ` Andy Shevchenko [this message]
2026-08-27 12:47         ` Andy Shevchenko
2026-08-30 23:16     ` Jonathan Cameron
2026-08-30 23:16       ` Jonathan Cameron
2026-08-31  7:10       ` Andy Shevchenko
2026-08-31  7:10         ` Andy Shevchenko
2026-09-01  1:38         ` Jonathan Cameron
2026-09-01  1:38           ` Jonathan Cameron
2026-08-27  8:30   ` Joshua Crofts
2026-08-27  8:30     ` Joshua Crofts
2026-08-27  9:18     ` Andy Shevchenko
2026-08-27  9:18       ` Andy Shevchenko
2026-08-30 23:30   ` Jonathan Cameron
2026-08-30 23:30     ` Jonathan Cameron
2026-09-02  8:48     ` Janani Sunil
2026-09-02  8:48       ` Janani Sunil
2026-09-02 11:02       ` Andy Shevchenko
2026-09-02 11:02         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apAx_ZUDQ6G6XVuc@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alex@ghiti.fr \
    --cc=andy@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=corbet@lwn.net \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jan.sun97@gmail.com \
    --cc=janani.sunil@analog.com \
    --cc=jic23@kernel.org \
    --cc=kent@minoris.se \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marcus.folkesson@gmail.com \
    --cc=marius.cristea@microchip.com \
    --cc=nedo80@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.