* [PATCH v2] iio: light: ltr390: Remove stale TODOs
@ 2026-08-28 7:10 Chang Yu
2026-08-28 7:47 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Chang Yu @ 2026-08-28 7:10 UTC (permalink / raw)
To: Chang Yu, Andy Shevchenko
Cc: Anshul Dalal, Jonathan Cameron, David Lechner, Nuno Sá,
linux-iio, linux-kernel
Remove stale TODOs from ltr390.c. All features have already been
implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
Configurable gain and resoluion: commit 13fad2607dad ("iio: light:
ltr390: Add configurable gain and resolution")
Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
Suspend and Resume support")
Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
Add ALS channel and support for gain and resolution")
Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts
and threshold event support")
Signed-off-by: Chang Yu <marcus.yu.56@gmail.com>
---
Changes since v2:
* Added commit hashes for each implemented feature.
drivers/iio/light/ltr390.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
index bc031f2c3141..f1bb066248e6 100644
--- a/drivers/iio/light/ltr390.c
+++ b/drivers/iio/light/ltr390.c
@@ -10,12 +10,6 @@
*
* Datasheet:
* https://optoelectronics.liteon.com/upload/download/DS86-2015-0004/LTR-390UV_Final_%20DS_V1%201.pdf
- *
- * TODO:
- * - Support for configurable gain and resolution
- * - Sensor suspend/resume support
- * - Add support for reading the ALS
- * - Interrupt support
*/
#include <linux/bitfield.h>
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] iio: light: ltr390: Remove stale TODOs
2026-08-28 7:10 [PATCH v2] iio: light: ltr390: Remove stale TODOs Chang Yu
@ 2026-08-28 7:47 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-08-28 7:47 UTC (permalink / raw)
To: Chang Yu
Cc: Andy Shevchenko, Anshul Dalal, Jonathan Cameron, David Lechner,
Nuno Sá, linux-iio, linux-kernel
On Fri, Aug 28, 2026 at 12:10:47AM -0700, Chang Yu wrote:
> Remove stale TODOs from ltr390.c. All features have already been
> implemented by Abhash Jha<abhashkumarjha123@gmail.com>'s patches:
>
> Configurable gain and resoluion: commit 13fad2607dad ("iio: light:
Misspelled 'resolution'.
> ltr390: Add configurable gain and resolution")
Here is trailing white space. Also you can do it in a way
[1] Configurable gain and resolution
[2] Suspend/resume support
[3] Support for reading the ALS
[4] Interrupt support
Link: https://git.kernel.org/torvalds/c/13fad2607dad [1]
Link: https://git.kernel.org/torvalds/c/288ce72fb5fc [2]
Link: https://git.kernel.org/torvalds/c/14e0d914a855 [3]
Link: https://git.kernel.org/torvalds/c/7ca4b8957066 [4]
> Suspend/resume support: commit 288ce72fb5fc ("iio: light: ltr390:
> Suspend and Resume support")
>
> Support for reading the ALS: commit 14e0d914a855 ("iio: light: ltr390:
> Add ALS channel and support for gain and resolution")
>
> Interrupt support: commit 7ca4b8957066 ("iio: light: ltr390: Interrupts
> and threshold event support")
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-28 7:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-28 7:10 [PATCH v2] iio: light: ltr390: Remove stale TODOs Chang Yu
2026-08-28 7:47 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.