Re: [PATCH 17/20] target/i386/tcg: implement CCMP/CTEST

[Zhao Liu <zhao1.liu@intel.com>]

>  static uint32_t glue(compute_aco_add, SUFFIX)(DATA_TYPE dst, DATA_TYPE src1)
>  {
>      DATA_TYPE src2 = dst - src1;
> diff --git a/target/i386/tcg/cc_helper.c b/target/i386/tcg/cc_helper.c
> index 6ddd64fcb07..a43b42badc0 100644
> --- a/target/i386/tcg/cc_helper.c
> +++ b/target/i386/tcg/cc_helper.c
> @@ -111,6 +111,13 @@ target_ulong helper_cc_compute_all(target_ulong dst, target_ulong src1,
>      case CC_OP_ADCOX:
>          return compute_all_adcox(dst, src1, src2);
>  
> +    case CC_OP_CCMPB:
> +        return compute_all_ccmpb(dst, src1, src2);
> +    case CC_OP_CCMPW:
> +        return compute_all_ccmpw(dst, src1, src2);
> +    case CC_OP_CCMPL:
> +        return compute_all_ccmpl(dst, src1, src2);
> +
>      case CC_OP_MULB:
>          flags = compute_aco_mul(src1);
>          goto psz_b;
> @@ -232,6 +239,9 @@ target_ulong helper_cc_compute_all(target_ulong dst, target_ulong src1,
>          goto psz_l;
>  
>  #ifdef TARGET_X86_64
> +    case CC_OP_CCMPQ:
> +        return compute_all_ccmpq(dst, src1, src2);
> +
>      case CC_OP_MULQ:
>          flags = compute_aco_mul(src1);
>          goto psz_q;

IIUC, it seems helper_cc_compute_c() missed CCMP ops, afterall it said
"should never happen" for default case:

target_ulong helper_cc_compute_c(target_ulong dst, target_ulong src1,
                                 target_ulong src2, int op)
{
    switch (op) {
    default: /* should never happen */
    ...

I think we would need a compute_c_ccmp helper.

Thanks,
Zhao