Re: [PATCH v3 04/29] media: v4l2-subdev: Allow releasing frame descriptors on return

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hej Linus,

Tack för dina kommentarer!

On Mon, Aug 31, 2026 at 02:54:29PM +0200, Linus Walleij wrote:
> Hi Sakari,
> 
> thanks for your patch!

Var så god!

> 
> On Mon, Aug 24, 2026 at 2:14 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> 
> > Use DEFINE_FREE() to allow using __free() to release frame descriptors
> > using v4l2_subdev_free_frame_desc().
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> 
> Clever with guards, I like it!
> 
> Should #include <linux/cleanup.h> be in this patch? I think I saw
> it in some other patch, or was it there already?

Hmm. It's there but added by the previous patch. I'll move it here.

> 
> 
> > @@ -1798,6 +1798,11 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l2_subdev *sd,
> >   * for each frame descriptor obtained by calling this function using
> >   * v4l2_subdev_free_frame_desc().
> >   *
> > + * Use __free() to release the frame descriptor automatically::
> > + *
> > + *    struct v4l2_mbus_frame_desc *desc __free(v4l2_subdev_free_frame_desc) =
> > + *            v4l2_subdev_get_frame_desc(sd, pad, desc);
> 
> the third argument to v4l2_subdev_get_frame_desc() from patch 3
> is "type" , the desc is what you return right?

Oops, indeed. I'll fix this for v4.

> 
> +/- these nitpicks (the code looks right):
> Reviewed-by: Linus Walleij <linusw@kernel.org>

Tack, tack!

-- 
Med trevliga hälsningar,

Sakari Ailus