Re: [PATCH v3 08/29] media: ds90ub913: Use v4l2_subdev_get_frame_desc_passthrough_csi2()

[Sakari Ailus <sakari.ailus@linux.intel.com>]

Hej Linus,

On Tue, Sep 01, 2026 at 03:12:02PM +0200, Linus Walleij wrote:
> Hi Sakari,
> 
> thanks for your patch?

Var så god! :-)

> 
> On Mon, Aug 24, 2026 at 2:14 PM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> 
> > Switch to v4l2_subdev_get_frame_desc_passthrough_csi2() in order to set
> > the frame descriptor type in the get_frame_desc() callback.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> (...)
> > -       .get_frame_desc = v4l2_subdev_get_frame_desc_passthrough,
> > +       .get_frame_desc = v4l2_subdev_get_frame_desc_passthrough_csi2,
> 
> But is this right?
> Shouldn't this be te _dvp (what I want to rename _parallel) version of
> the callback?
> I can't see anything CSI2-related in this driver.

I guess you're right. There are CSI-2 to DVP bridges that just pass through
the CSI-2 frame descriptor, but this certainly isn't one of them. I'll use
DVP for v4.

> 
> Look at commit d6113cdd221964ebcfd479f56b1b7e9c4e28e7d4
> "media: i2c: ds90ub913: Use v4l2_subdev_get_frame_desc_passthrough"
> by Tomi:
> 
> -       ret = v4l2_subdev_call(priv->source_sd, pad, get_frame_desc,
> -                              priv->source_sd_pad, &source_fd);
> -       if (ret)
> -               return ret;
> -
> -       fd->type = V4L2_MBUS_FRAME_DESC_TYPE_PARALLEL;
> -
> -       state = v4l2_subdev_lock_and_get_active_state(sd);
> 

-- 
Sakari Ailus